Re: [Development] Windows plugin customisation: QWindowsKeyMapper

2022-07-30 Thread Laszlo Papp
It would be better if the Qt application using Qt would not need to write platform specific code, like intercepting WM_APPCOMMAND or using DefWindowProc. So, I wonder if we can either: 1. Change the default behaviour to pass the event to the application and if it is not handled by the application

Re: [Development] Windows plugin customisation: QWindowsKeyMapper

2022-07-30 Thread Laszlo Papp
On Sat, Jul 30, 2022 at 5:38 PM Tor Arne Vestbø wrote: > I guess that depends on what your goal is. The default implementation > calls showSystemMenu(), so it doesn’t seem to pass through the app AFAICT. > I was wondering if the default implementation ought to give a chance to the app to handle

Re: [Development] Windows plugin customisation: QWindowsKeyMapper

2022-07-30 Thread Tor Arne Vestbø
On 30 Jul 2022, at 18:29, Laszlo Papp mailto:lp...@kde.org>> wrote: Thanks. Should the event first be sent to the application and only if not handled, passed to Windows? I guess that depends on what your goal is. The default implementation calls showSystemMenu(), so it doesn’t seem to pass

Re: [Development] Windows plugin customisation: QWindowsKeyMapper

2022-07-30 Thread Laszlo Papp
Thanks. Should the event first be sent to the application and only if not handled, passed to Windows? On Sat, Jul 30, 2022 at 5:15 PM Tor Arne Vestbø wrote: > Actually, you might be able to filter out the event via > > https://doc.qt.io/qt-6/qcoreapplication.html#installNativeEventFilter > > An

Re: [Development] Windows plugin customisation: QWindowsKeyMapper

2022-07-30 Thread Tor Arne Vestbø
Actually, you might be able to filter out the event via https://doc.qt.io/qt-6/qcoreapplication.html#installNativeEventFilter And pass it on manually to windows via DefWindowProc Tor Arne On 30 Jul 2022, at 18:12, Tor Arne Vestbø mailto:tor.arne.ves...@qt.io>> wrote: Hi, I don’t think there’

Re: [Development] Windows plugin customisation: QWindowsKeyMapper

2022-07-30 Thread Tor Arne Vestbø
Hi, I don’t think there’s any way to customize that behavior today, apart from maintaining a customized version of the Windows platform plugin. You could perhaps have some luck intercepting WM_APPCOMMAND before it reaches the Qt message proc? Tor Arne On 30 Jul 2022, at 14:12, Laszlo Papp mai

Re: [Development] Challenge: adding new method overloads when existing consumers use {} with args

2022-07-30 Thread Giuseppe D'Angelo via Development
Hi, On 30/07/2022 14:13, A. Pönitz wrote: Ultimately, I think that we simply don't "really" deal with this particular problem, and may accept the SIC. For instance, if we add a QStringView overload to a function taking QString, this is a SIC but I don't think we would reject the addition. I cert

[Development] Windows plugin customisation: QWindowsKeyMapper

2022-07-30 Thread Laszlo Papp
Hi, What is the recommended way to customise the behaviour of built-in plugins, like a windows plugin , QWindowsKeyMapper in particular? To be specific, if we wanted to pass this alt+space to the application rather than Qt forwarding it to Windows, the operating system? Like a potential break her

Re: [Development] [Announce] Security advisory: Freetype in Qt

2022-07-30 Thread Kevin Kofler via Development
Albert Astals Cid wrote: > El dijous, 28 de juliol de 2022, a les 18:13:02 (CEST), Volker Hilsheimer > va escriure: >> The agreement is that KDE maintains patches like this for Qt 5 so that >> they are available on top of the branches that are available to the Open >> Source community. > >> http

Re: [Development] Challenge: adding new method overloads when existing consumers use {} with args

2022-07-30 Thread Giuseppe D'Angelo via Development
On 28/07/2022 22:54, Thiago Macieira wrote: This case can be considered a Category B source incompatible change as per https://quips-qt-io.herokuapp.com/quip-0006.html, because it clearly introduces ambiguity. But {} is particularly special, so I don't know how we'd deal with it. I don't think t