Re: [Development] [RFO QTBUG-84739] QJsonValue::fromVariant containing QByteArray (Thiago Macieira)

2020-07-03 Thread Thiago Macieira
On Friday, 3 July 2020 05:16:11 PDT Arnaud Clère wrote: > > [1] https://tools.ietf.org/html/rfc7049#section-4.1 > > Even if non normative, these advices are useful and even more so when > implemented in such wide-spread library as Qt, so if it can be opted-in, I > would definitely prefer option c)

Re: [Development] [RFO QTBUG-84739] QJsonValue::fromVariant containing QByteArray (Thiago Macieira)

2020-07-03 Thread Arnaud Clère
Hi all, > (a) implies one change in behaviour (5.14.2 to 5.15.0) > > (b) implies two changes in behaviour (to and from 5.15.0) > > (c) implies three changes in behaviour: 5.14.2→5.15.0, 5.15.0→5.15.1, > 5.15.x→6.0 > I would appreciate option b) or c) We do not use x.x.0 versions so it would be tr

[Development] PSA: Tests need to pass in the CI for Qt 6 CMake configurations

2020-07-03 Thread Alexandru Croitor
Hi all, Previously tests were built and executed for CMake configurations, but in case of failure, the exit codes were ignored so the test jobs always passed from the CI's perspective. You had to look into the log to see if any test actually failed. I have now enabled enforcing working tests i