Re: [Development] GitHub Pull requests

2020-03-11 Thread Thiago Macieira
On Wednesday, 11 March 2020 03:48:24 PDT Edward Welbourne wrote: > Matthew Woehlke (10 March 2020 20:24) wrote: > > In an ideal world... > > [snip] > > > Note that I believe nothing needs to be done to "merge" the GitHub PR; > > if the commits become reachable from the target branch, it should >

Re: [Development] GitHub Pull requests

2020-03-11 Thread Thiago Macieira
On Tuesday, 10 March 2020 07:40:41 PDT Cristian Adam wrote: > Hi, > > With the “GitHub issues” E-Mail thread we made sure the Issues are gone > from the projects. > > What about Pull requests? > > For example qtbase has 7 pull requests. > Usually people point

Re: [Development] GitHub Pull requests

2020-03-11 Thread Konstantin Tokarev
11.03.2020, 15:18, "Oswald Buddenhagen" : > On Tue, Mar 10, 2020 at 02:40:41PM +, Cristian Adam wrote: >> What about Pull requests? > > before you continue reinventing the wheel, i recommend that you read the > comments on QTPM-314 (yes, all of them). "You can't view this issue It may have

Re: [Development] GitHub Pull requests

2020-03-11 Thread Alexandru Croitor
> On 11. Mar 2020, at 07:48, Richard Weickelt wrote: > >>> In an ideal world... >>> >>> - Alice opens a pull request on GitHub. >>> - A bot sees the PR and opens a corresponding request on Gerrit. >>> - Bob comments on the Gerrit request. >>> - A bot sees Bob's comment and replicates it to the

Re: [Development] GitHub Pull requests

2020-03-11 Thread Oswald Buddenhagen
On Tue, Mar 10, 2020 at 02:40:41PM +, Cristian Adam wrote: What about Pull requests? before you continue reinventing the wheel, i recommend that you read the comments on QTPM-314 (yes, all of them). you can open a task for the public gerrit component if you still feel revolutionary afterwa

Re: [Development] GitHub Pull requests

2020-03-11 Thread Edward Welbourne
Matthew Woehlke (10 March 2020 20:24) wrote: > In an ideal world... [snip] > Note that I believe nothing needs to be done to "merge" the GitHub PR; > if the commits become reachable from the target branch, it should > automatically get marked as "merged". Given that gerrit cherry-picks the change

Re: [Development] GitHub Pull requests

2020-03-11 Thread Max Paperno
Just wanted to chime in as a "could be" Qt dev. Lowering the barrier to entry by allowing use of familiar tools could be a benefit IF you're looking for more contributions. I'm sure there's effort involved to allow this, and maybe it's not practical in the end, but perhaps worth considering/loo

Re: [Development] Arttu Tarkiainen as approver

2020-03-11 Thread Kari Oikarinen
Seconding approver status proposals can officially be done by approvers and maintainers. As far as I can see, Tino, you are not one, so this doesn't count officially. See https://quips-qt-io.herokuapp.com/quip-0002.html#how-to-become-an-approver +1 for Arttu's approvership. On 11.3.2020 7.35,