Re: [Development] thread_local: replacing GCC with Clang for MinGW

2019-08-23 Thread Thiago Macieira
On Friday, 23 August 2019 11:27:12 PDT Jean-Michaël Celerier wrote: > I'm using this toolchain to build qtbase, declarative, svg, websockets, > serialport and a few other : https://github.com/mstorsjo/llvm-mingw > > I think that it has also been used for webengine. Interesting, it would rehabilit

Re: [Development] thread_local: replacing GCC with Clang for MinGW

2019-08-23 Thread Jean-Michaël Celerier
I'm using this toolchain to build qtbase, declarative, svg, websockets, serialport and a few other : https://github.com/mstorsjo/llvm-mingw I think that it has also been used for webengine. Jean-Michaël On Fri, Aug 23, 2019 at 8:16 PM Thiago Macieira wrote: > Restarting the thread since it cha

[Development] thread_local: replacing GCC with Clang for MinGW

2019-08-23 Thread Thiago Macieira
Restarting the thread since it changed subjects many times and has gone back and forth. Simon wrote: > I ran into the crash a while ago in the CI. See also > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83562 . That bug report shows that GCC does not properly implement thread_local on MinGW 32-

Re: [Development] Requiring minimum GCC 7/MinGW (was: Dropping MinGW support in Qt 6 (Was: HEADS-UP: QStringLiteral))

2019-08-23 Thread Thiago Macieira
On Friday, 23 August 2019 09:04:55 PDT Konstantin Tokarev wrote: > > libgcc on pure MinGW doesn't use winpthreads, it uses Win32. > > std::thread and co are not implemented for win32, so we use pthreads version > in Coin and distribute it with SDK. We don't use std::thread in Qt, so why are you t

Re: [Development] Requiring minimum GCC 7/MinGW (was: Dropping MinGW support in Qt 6 (Was: HEADS-UP: QStringLiteral))

2019-08-23 Thread Thiago Macieira
On Friday, 23 August 2019 08:58:09 PDT Simon Hausmann wrote: > Hi, > > I ran into the crash a while ago in the CI. See also > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83562 . That last comment in the bug report seems relevant to us. -- Thiago Macieira - thiago.macieira (AT) intel.com Soft

Re: [Development] Nominating David Edmundson as approver

2019-08-23 Thread Pier Luigi Fiorini
+1 Il giorno ven 23 ago 2019 alle ore 14:17 Johan Helsing ha scritto: > Hi all, > > I'd like to nominate David Edmundson as approver for the Qt Project. David > started contributing to Qt in 2013 and has been active contributing and > reviewing patches in QtWayland for the past two years. His pa

Re: [Development] Requiring minimum GCC 7/MinGW (was: Dropping MinGW support in Qt 6 (Was: HEADS-UP: QStringLiteral))

2019-08-23 Thread Konstantin Tokarev
23.08.2019, 18:11, "Thiago Macieira" : > On Friday, 23 August 2019 00:12:50 PDT Roland Winklmeier wrote: >>  Just for your awareness: There is an old bug related to thread_local in >>  MinGW which afaik was never fixed. It compiles correctly, but every >>  executable crashes during shutdown. Not

Re: [Development] Requiring minimum GCC 7/MinGW (was: Dropping MinGW support in Qt 6 (Was: HEADS-UP: QStringLiteral))

2019-08-23 Thread Simon Hausmann
Hi, I ran into the crash a while ago in the CI. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83562 . Simon On 23. Aug 2019, at 23:12, Thiago Macieira mailto:thiago.macie...@intel.com>> wrote: On Friday, 23 August 2019 00:12:50 PDT Roland Winklmeier wrote: Just for your awareness: The

Re: [Development] Qt 5 types under consideration for deprecation / removal in Qt 6

2019-08-23 Thread Thiago Macieira
On Friday, 23 August 2019 01:31:20 PDT Mutz, Marc via Development wrote: > Do I understand it correctly that the implementation of QWaitCondition > has _another_ mutex inside?! So, two mutexes? The one users pass in and > then the one that QWaitCondition uses internally, because it's > pthread_cond

Re: [Development] Requiring minimum GCC 7/MinGW (was: Dropping MinGW support in Qt 6 (Was: HEADS-UP: QStringLiteral))

2019-08-23 Thread Thiago Macieira
On Friday, 23 August 2019 00:12:50 PDT Roland Winklmeier wrote: > Just for your awareness: There is an old bug related to thread_local in > MinGW which afaik was never fixed. It compiles correctly, but every > executable crashes during shutdown. Not sure if this relevant in this case, > just mentio

Re: [Development] HEADS-UP: QStringLiteral

2019-08-23 Thread Thiago Macieira
On Thursday, 22 August 2019 23:44:02 PDT Ville Voutilainen wrote: > > This doesn’t solve the problem that you’re having when you want to use > > anything outside the ascii range inside “literal”, as the encoding of the > > source code on disk is not defined. u”…” or u8”…” defines the output > > enc

Re: [Development] Qt 5 types under consideration for deprecation / removal in Qt 6

2019-08-23 Thread Allan Sandfeld Jensen
On Friday, 23 August 2019 14:51:36 CEST Mutz, Marc via Development wrote: > On 2019-08-23 14:31, Allan Sandfeld Jensen wrote: > [...] > > > condition_variable_any::_M_mutex > > I didn't say _any :) > > > The std::conditional_variable has the same problem QWaitCondition has. > > I don't think so

Re: [Development] Qt 5 types under consideration for deprecation / removal in Qt 6

2019-08-23 Thread Mutz, Marc via Development
On 2019-08-23 14:31, Allan Sandfeld Jensen wrote: [...] condition_variable_any::_M_mutex I didn't say _any :) The std::conditional_variable has the same problem QWaitCondition has. I don't think so: https://code.woboq.org/gcc/libstdc++-v3/include/std/condition_variable.html#166 takes

Re: [Development] Nominating David Edmundson as approver

2019-08-23 Thread Shawn Rutledge
On 23 Aug 2019, at 14:15, Johan Helsing mailto:johan.hels...@qt.io>> wrote: Hi all, I'd like to nominate David Edmundson as approver for the Qt Project. David started contributing to Qt in 2013 and has been active contributing and reviewing patches in QtWayland for the past two years. His pa

Re: [Development] Nominating David Edmundson as approver

2019-08-23 Thread Paul Tvete
On Friday, 23 August 2019 14:15:59 CEST Johan Helsing wrote: > I'd like to nominate David Edmundson as approver for the Qt Project. +1 Consistently good contributions. I guess I just assumed he was already an approver :) - Paul ___ Development maili

Re: [Development] Qt 5 types under consideration for deprecation / removal in Qt 6

2019-08-23 Thread Allan Sandfeld Jensen
On Friday, 23 August 2019 10:31:20 CEST Mutz, Marc via Development wrote: > On 2019-05-29 12:53, Mutz, Marc via Development wrote: > > === QWaitCondition -> std::condition_variable(_any) === > > > > Plumbing that std::condition_variable can do better. > > So, I've looked at QWaitCondition because

[Development] Nominating David Edmundson as approver

2019-08-23 Thread Johan Helsing
Hi all, I'd like to nominate David Edmundson as approver for the Qt Project. David started contributing to Qt in 2013 and has been active contributing and reviewing patches in QtWayland for the past two years. His patches and reviews have a very high quality and I trust he will use his rights r

[Development] HEADS-UP: Branching from '5.12' to '5.12.5' complete

2019-08-23 Thread Jani Heikkinen
Hi! Final branching from '5.12' to '5.12.5' in now done and all changes targeted to Qt 5.12.5 release needs to be done in '5.12.5'. And from now on '5.12' is for Qt 5.12.6 Qt 5.12.5 blocker list is here: https://bugreports.qt.io/issues/?filter=21420 Please make sure all release blockers are vi

Re: [Development] Qt 5 types under consideration for deprecation / removal in Qt 6

2019-08-23 Thread Philippe
With the Windows implementation, there is indeed a mutex to protect an internal list of waiters. This is not a problem in itself, because std::condition_variable probably does the same... However, a problem with QWaitCondition that forced me to switch to std::condition_variable is the following

Re: [Development] Qt 5 types under consideration for deprecation / removal in Qt 6

2019-08-23 Thread Mutz, Marc via Development
On 2019-05-29 12:53, Mutz, Marc via Development wrote: === QWaitCondition -> std::condition_variable(_any) === Plumbing that std::condition_variable can do better. So, I've looked at QWaitCondition because I had a need to call wait() with a QBasicMutex instead of a QMutex, and that doesn't ex

Re: [Development] Requiring minimum GCC 7/MinGW (was: Dropping MinGW support in Qt 6 (Was: HEADS-UP: QStringLiteral))

2019-08-23 Thread Roland Winklmeier
Am Do., 22. Aug. 2019 um 22:47 Uhr schrieb Thiago Macieira < thiago.macie...@intel.com>: > On Thursday, 22 August 2019 12:05:39 PDT Danila Malyutin wrote: > > Isn't it already the case: > https://doc.qt.io/qt-5/supported-platforms.html > > ? > > Looks like it. > > I'll dust-off the Q_THREAD_LOCAL