Re: [Development] qtlottie build broken: "Missing CMake tests. Either create tests in tests/auto/cmake"

2019-07-22 Thread Thiago Macieira
On Monday, 22 July 2019 12:22:34 PDT Simon Hausmann wrote: > I think I fixed that last week. What’s your sha1? > > There is not C++ application linkage for the module in question so cmake app > linkage tests don’t make sense IMHO. commit 03b666a967fb7501248e9f40a5b187ec3a16c453 (HEAD -> master, o

Re: [Development] qtlottie build broken: "Missing CMake tests. Either create tests in tests/auto/cmake"

2019-07-22 Thread Liang Qi
https://codereview.qt-project.org/c/qt/qtlottie/+/268295 http://bugreports.qt.io/browse/QTBUG-77130 Liang > On 22 Jul 2019, at 21:22, Simon Hausmann wrote: > > I think I fixed that last week. What’s your sha1? > > There is not C++ application linkage for the module in question so cmake app >

Re: [Development] qtlottie build broken: "Missing CMake tests. Either create tests in tests/auto/cmake"

2019-07-22 Thread Simon Hausmann
I think I fixed that last week. What’s your sha1? There is not C++ application linkage for the module in question so cmake app linkage tests don’t make sense IMHO. Simon > On 22. Jul 2019, at 21:16, Thiago Macieira wrote: > > [the "or" part of the either is not applicable] > > Can someone pl

[Development] qtlottie build broken: "Missing CMake tests. Either create tests in tests/auto/cmake"

2019-07-22 Thread Thiago Macieira
[the "or" part of the either is not applicable] Can someone please add the tests? Treat as P0. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel System Software Products ___ Development mailing list Development@qt-proj