Re: [Development] Requesting a repository for Alexa integration

2019-05-08 Thread Frederik Gladhorn
Now I'm looking forward to seeing what you've come up with :) https://codereview.qt-project.org/#/admin/projects/qt/qtvoiceassistant Cheers, Frederik On onsdag 8. mai 2019 16:47:24 CEST Minenko, Vladimir wrote: > Thanks fort he feedback! > > > > "qt/qtvoiceassistant" > > > Sounds good! Thank

Re: [Development] Be careful with duplicate Change-Ids in multiple branches in gerrit

2019-05-08 Thread Frederik Gladhorn
On onsdag 8. mai 2019 16:06:02 CEST Edward Welbourne wrote: > On 8 May 2019, at 10:24, Liang Qi mentioned: > https://codereview.qt-project.org/260927 > > Shawn Rutledge (8 May 2019 15:43) replied > > > I don’t understand why a change that is just sitting there on Gerrit > > can affect the merge.

Re: [Development] Requesting a repository for UI analytics

2019-05-08 Thread Frederik Gladhorn
Hello Vladimir, On onsdag 10. april 2019 14:21:21 CEST Minenko, Vladimir wrote: > Hi, > > I would like to request for a new repository: > > Name of the repository: qt-labs/qtuianalytics.git > Description: An plugin for Qt Quick allowing collection of UI usage > analytics. Responsible person: Vl

Re: [Development] Requesting a repository for Alexa integration

2019-05-08 Thread Minenko, Vladimir
Thanks fort he feedback! > "qt/qtvoiceassistant" Sounds good! Thanks! -- Vladimir On 08.05.19, 16:41, "Frederik Gladhorn" wrote: Hi Vladimir, It's great to hear that you've been looking into integrating Alexa and other assistants as well, we have a few thoughts around this in Th

Re: [Development] Requesting a repository for Alexa integration

2019-05-08 Thread Frederik Gladhorn
Hi Vladimir, It's great to hear that you've been looking into integrating Alexa and other assistants as well, we have a few thoughts around this in The Qt Company and have been drawing how a rough abstraction for several assistants could look like. Sadly it's not easy to hook deeply into e.g. A

Re: [Development] Be careful with duplicate Change-Ids in multiple branches in gerrit

2019-05-08 Thread Edward Welbourne
On 8 May 2019, at 10:24, Liang Qi mentioned: https://codereview.qt-project.org/260927 Shawn Rutledge (8 May 2019 15:43) replied > I don’t understand why a change that is just sitting there on Gerrit > can affect the merge. Nobody ever staged that one onto the “wrong” > branch, right? None the le

Re: [Development] Be careful with duplicate Change-Ids in multiple branches in gerrit

2019-05-08 Thread Shawn Rutledge
> On 8 May 2019, at 10:24, Liang Qi wrote: > > > >> On 7 May 2019, at 22:13, Oswald Buddenhagen >> wrote: >> >> On Tue, May 07, 2019 at 01:52:48PM +, Liang Qi wrote: >>> This is a very common issue when I do the integraton work in qt5. >>> >>> For example, currently we have 5.12->5.13

Re: [Development] Be careful with duplicate Change-Ids in multiple branches in gerrit

2019-05-08 Thread Liang Qi
> On 7 May 2019, at 22:13, Oswald Buddenhagen wrote: > > On Tue, May 07, 2019 at 01:52:48PM +, Liang Qi wrote: >> This is a very common issue when I do the integraton work in qt5. >> >> For example, currently we have 5.12->5.13->dev merge order, and the last >> round 5.13->5.13.0 today. O

Re: [Development] unique_ptr and Qt, Take 2

2019-05-08 Thread Daniel Teske
The patch I propose does not take that into account and is indeed almost entirely source compatible. Scratch the "not". And while I'd encourage someone to try it out, I'm of the firm opinion that Qt should try to get over its NIH attitude. One of the issues with Qt in the real world is th