Re: [Development] Naming convention for (scoped) enums

2018-08-31 Thread Marco Bubke
Enumerations inside of classes makes dependency breaking harder. We don't use that in Qt but users of our interface may do. It's still possible but much more complex because you generally get much more dependencies. A simple header file for enumerations instead can simply be included without any

Re: [Development] QML API Review

2018-08-31 Thread Jason H
Is this why in Qt Creator some very basic things and non basic things are underlined/don't autocomplete on various platforms? Ex: (on iOS) import QtQuick 2.11 import QtQuick.Window 2.11 // QML module not found(...) import QtWebView 1.1 // QML module not found(...) import QtMultimedia 5.9

Re: [Development] Naming convention for (scoped) enums

2018-08-31 Thread Tor Arne Vestbø
Hey, > On 31 Aug 2018, at 14:50, Jan-Arve Sæther wrote: > > For me it seems that enum classes can help us create a more structured API, > because they also gives more semantic information, e.g: > QQuickPointerDevice::PointerType::Finger > gives more information than > QQuickPointerDevice::Finge

Re: [Development] Naming convention for (scoped) enums

2018-08-31 Thread Jan-Arve Sæther
For me it seems that enum classes can help us create a more structured API, because they also gives more semantic information, e.g: QQuickPointerDevice::PointerType::Finger gives more information than QQuickPointerDevice::Finger For example, when doing code completion if I type "QQuickPointerD

Re: [Development] QML API Review

2018-08-31 Thread Shawn Rutledge
> On 31 Aug 2018, at 13:39, Kai Koehne wrote: > > Hi, > > In addition to the C++ API review that Edward has been pushing, we also need > to review new/changed QML API. > > Most of our QML API is actually defined in C++, so one way to review them is > diffing the corresponding .h files; howev

[Development] QML API Review

2018-08-31 Thread Kai Koehne
Hi, In addition to the C++ API review that Edward has been pushing, we also need to review new/changed QML API. Most of our QML API is actually defined in C++, so one way to review them is diffing the corresponding .h files; however, because they are private (in the C++ sense), every module is

Re: [Development] Naming convention for (scoped) enums

2018-08-31 Thread Eike Ziller
> On 31. Aug 2018, at 11:56, Tor Arne Vestbø wrote: > > I think Simon’s reasoning in the review that spurred this discussion > summarises it nicely: > >> On 31 Aug 2018, at 10:24, Simon Hausmann (Code Review) >> wrote: >> >> Simon Hausmann has posted comments on this change. >> >> Change

[Development] Deprecation of Qt Canvas3D in 5.12

2018-08-31 Thread Pasi Keränen
We’ve maintained the Canvas3D (a WebGL like API for Qt Quick JavaScript) module with very minimal effort, but when we look at our future it seems clear we need to start supporting multiple low level APIs in Qt’s graphics stack and make our graphics stack less OpenGL centric. This was discussed i

Re: [Development] Naming convention for (scoped) enums

2018-08-31 Thread Tor Arne Vestbø
I think Simon’s reasoning in the review that spurred this discussion summarises it nicely: > On 31 Aug 2018, at 10:24, Simon Hausmann (Code Review) > wrote: > > Simon Hausmann has posted comments on this change. > > Change subject: Convert QQEventPoint and QQPointerDevice enums to enum classe

Re: [Development] Submitting Qt to oss-fuzz

2018-08-31 Thread Albert Astals Cid via Development
El divendres, 31 d’agost de 2018, a les 11:24:58 CEST, Robert Löhning va escriure: > Hi everybody, > > yes I did. So far I have been working on getting Qt into a better shape > for fuzzing at all, resulting in [1]. > > This prepares a Qt build for being fuzz tested with clang's libFuzzer, > the

Re: [Development] Submitting Qt to oss-fuzz

2018-08-31 Thread Albert Astals Cid via Development
El divendres, 31 d’agost de 2018, a les 11:31:16 CEST, Robert Löhning va escriure: > Am 30.08.2018 um 21:30 schrieb Albert Astals Cid via Development: > > El dijous, 30 d’agost de 2018, a les 8:59:40 CEST, André Pönitz va escriure: > >> On Thu, Aug 30, 2018 at 08:42:11PM +0200, Albert Astals Cid

Re: [Development] Naming convention for (scoped) enums

2018-08-31 Thread Alex Blasche
> -Original Message- > From: Development project.org> On Behalf Of Simon Hausmann > > I don't consider the longer names detrimental for writability and usability. > Writability is easily solved with code completion and readability is actually > better > because the type adds additiona

Re: [Development] Submitting Qt to oss-fuzz

2018-08-31 Thread Robert Löhning
Am 30.08.2018 um 21:30 schrieb Albert Astals Cid via Development: El dijous, 30 d’agost de 2018, a les 8:59:40 CEST, André Pönitz va escriure: On Thu, Aug 30, 2018 at 08:42:11PM +0200, Albert Astals Cid via Development wrote: I made a local test run of the undefined sanitizer and it found http

Re: [Development] Naming convention for (scoped) enums

2018-08-31 Thread Edward Welbourne
Simon Hausmann (31 August 2018 11:01) > If we decide to allow deciding on a case-by-case basis, then I encourage > everyone to carefully look at newly introduced enums, their values and > their context in the upcoming "API review season". or, indeed, s/upcoming/ongoing/ ;-) Eddy.

Re: [Development] Submitting Qt to oss-fuzz

2018-08-31 Thread Robert Löhning
Hi everybody, yes I did. So far I have been working on getting Qt into a better shape for fuzzing at all, resulting in [1]. This prepares a Qt build for being fuzz tested with clang's libFuzzer, the tool that Google also uses in oss-fuzz. The fuzzer I used for testing my setup already found

Re: [Development] Submitting Qt to oss-fuzz

2018-08-31 Thread Edward Welbourne
El divendres, 31 d’agost de 2018, a les 10:27:08 CEST, Edward Welbourne va escriure: >> By "fixed" do they mean "we have told them we've fixed it" or "we've >> released all currently releasing branches of Qt with fixes" ? Albert Astals Cid (31 August 2018 10:52) > Fixed means "the daily bot has r

Re: [Development] Naming convention for (scoped) enums

2018-08-31 Thread Simon Hausmann
On 8/15/18 9:32 AM, Alex Blasche wrote: -Original Message- From: Tor Arne Vestbø 1. Scoped enums (enum class) for the sake of avoiding name clashes is useful for global enums, but when the enum lives inside a class, the chance that we’ll see a naming clash is minor, and using scoped e

Re: [Development] Submitting Qt to oss-fuzz

2018-08-31 Thread Albert Astals Cid via Development
El divendres, 31 d’agost de 2018, a les 10:27:08 CEST, Edward Welbourne va escriure: > Albert Astals Cid (30 August 2018 20:42) wrote: > > oss-fuzz is an online fuzzing service run by Google. > > Sounds useful. > > > They test daily the code base and run fuzzying over it, maintaining a > > list

Re: [Development] Submitting Qt to oss-fuzz

2018-08-31 Thread Edward Welbourne
Albert Astals Cid (30 August 2018 20:42) wrote: > oss-fuzz is an online fuzzing service run by Google. Sounds useful. > They test daily the code base and run fuzzying over it, maintaining a > list of open and closed bugs. > > Found bugs are sent to a list of trusted address and kept private for >