Re: [Development] Urgent: increase timeout for tst_qcomplextext

2018-07-02 Thread Thiago Macieira
On Saturday, 30 June 2018 10:09:11 PDT Lars Knoll wrote: > Hi Thiago, > > maybe https://codereview.qt-project.org/#/c/233693/ helps with this case. It did help some. It went from PASS : tst_QComplexText::bidiTest(line #201771 (LTR) to PASS : tst_QComplexText::bidiTest(line #456371 (RTL))

Re: [Development] clang-format

2018-07-02 Thread Tor Arne Vestbø
> On 2 Jul 2018, at 16:49, Lars Knoll wrote: > > >> On 2 Jul 2018, at 13:35, Tor Arne Vestbø wrote: >> >> >>> On 2 Jul 2018, at 12:56, Svenn-Arne Dragly wrote: >>> >>> There are also many nice options set in the clang-format config found in Qt >>> Creator's sources[2] which I think are i

Re: [Development] clang-format

2018-07-02 Thread Lars Knoll
> On 2 Jul 2018, at 13:35, Tor Arne Vestbø wrote: > > >> On 2 Jul 2018, at 12:56, Svenn-Arne Dragly wrote: >> >> There are also many nice options set in the clang-format config found in Qt >> Creator's sources[2] which I think are interesting. For instance, >> "BinPackParameters: false" and

Re: [Development] clang-format

2018-07-02 Thread Tor Arne Vestbø
> On 2 Jul 2018, at 12:56, Svenn-Arne Dragly wrote: > > There are also many nice options set in the clang-format config found in Qt > Creator's sources[2] which I think are interesting. For instance, > "BinPackParameters: false" and "BinPackArguments: false" makes sure you to > either put al

Re: [Development] clang-format

2018-07-02 Thread Svenn-Arne Dragly
On 06/20/2018 01:01 PM, Tor Arne Vestbø wrote: Good point, I was imagining it used only to verify style, not to auto-format. Still, starting out with a few non-controversial rules would be a good thing. I agree. For instance, it is clear from the patch discussion[1] that line length/column co

Re: [Development] Urgent: increase timeout for tst_qcomplextext

2018-07-02 Thread Edward Welbourne
On 30 Jun 2018, at 18:14, Thiago Macieira wrote: >> I tried to add a change to increase the timeout >> https://codereview.qt-project.org/233691 >> but Liang pointed out that my inspiration is a change by Rohan McGovern back >> in 2012: >> >> dd3e4f1dbe8 tests/auto/network/access/qnetworkreply/test/