[Development] QtCS 2018: Third-party and security policy

2018-06-08 Thread Thiago Macieira
There's a session scheduled for Monday (unless it gets moved). Here's what I will propose. 0) Where not really necessary, delete the third-party code and force the use of a system library (see assimp discussion, can be applied to qtimageformats too). 1) Third-party bundled should be opt-in, no

Re: [Development] Did we have to remove cmake's qt5_use_modules?

2018-06-08 Thread Kai Koehne
> -Original Message- > From: Development [mailto:development-bounces+kai.koehne=qt.io@qt- > [...] > The Qt promise is to maintain not only source code, but upward binary > compatibility until a major version. > > When said promise is broken immediately after a major version release, as it

Re: [Development] Did we have to remove cmake's qt5_use_modules?

2018-06-08 Thread Thiago Macieira
On Friday, 8 June 2018 07:59:10 PDT Kevin Funk wrote: > I would lean towards restoring qt5_use_modules() in Qt 5.11.1 (and keep it > for the Qt5 lifetime). But I'd leave the other removals of > 02ed1b36daebed5f3997bb676cf5e818c0db9d3c (mainly removal of support of older > CMake versions) intact. >

Re: [Development] Did we have to remove cmake's qt5_use_modules?

2018-06-08 Thread Kevin Funk
On Thursday, 7 June 2018 08:03:40 CEST Thiago Macieira wrote: > Commit 02ed1b36daebed5f3997bb676cf5e818c0db9d3c was > > Remove CMake code for CMake < 3.1 > > This removes the following functions from Qt5CoreMacros: > - qt5_use_modules(...) > > Which follows 2013's d9ea4bb1441534cfb92

Re: [Development] Pinging Marco Bubke for QTCREATORBUG-20401 - Allow to build with system's SQLite

2018-06-08 Thread Marco Bubke
The Sqlite module is not a plugin but a library. It is linked to a plugin but this plugin is not build in release and normally disabled. Like I said, it can be simply not build for release. Please stick to KISS. On June 8, 2018 16:30:19 Edward Welbourne wrote: > Marco Bubke (7 June 2018 19:37)

Re: [Development] Did we have to remove cmake's qt5_use_modules?

2018-06-08 Thread qt . dantec
Le Wed, 06 Jun 2018 23:03:40 -0700, Thiago Macieira écrivait: >But it appears that in the 5 years since we deprecated it, people have not >stopped using it. Did we have to remove it? Or should we have kept >compatibility until Qt 6? The Qt promise is to maintain not only source code, but upwa

[Development] Maintainers, your action needed: Qt 5.11.1 changes files

2018-06-08 Thread Jani Heikkinen
Hi, Initial ones here: https://codereview.qt-project.org/#/q/message:%22Add+changes+file+for+Qt+5.11.1%22,n,z Please do needed updates & get approval as soon as possible; We need to get these in soon to be able to keep our release schedule (final packages next week, release 19.6.2018) br, Jan

Re: [Development] Pinging Marco Bubke for QTCREATORBUG-20401 - Allow to build with system's SQLite

2018-06-08 Thread Edward Welbourne
Marco Bubke (7 June 2018 19:37) wrote: > AFAIK the refactoring plugin is disabled for release. Just do the same for > the Sqlite library. Probably better to do as Thiago said: On June 7, 2018 23:54:43 Thiago Macieira wrote: >> So we just need a conditional to disable the building if the refacto

Re: [Development] Do we really need Assimp?

2018-06-08 Thread Mike Krus
Hi Using system assimp is probably the best scenario indeed. Except I think users would expect install packages to have that enabled so ideally assimp should be installed on CI systems. Mike > On 7 Jun 2018, at 17:24, Lisandro Damián Nicanor Pérez Meyer > wrote: > > El jueves, 7 de junio de