[Development] Branching from 'dev' to '5.11' started

2018-01-24 Thread Jani Heikkinen
Hi, We have now soft branched '5.11' from dev so please start using '5.11' now. Qt 5.11 feature freeze and final downmerge from 'dev' to '5.11' will happen Wed 31.1.2018 so there is still enough time to finalize ongoing changes in 'dev'. And let's keep the feature freeze now, it is key enabler

Re: [Development] API review request: CBOR Stream reader and writer

2018-01-24 Thread Thiago Macieira
On Wednesday, 24 January 2018 10:49:32 PST Thiago Macieira wrote: > I've added a CBOR dump tool example, which can help you with understanding > what you have: One more difference: since "convert" uses QCborValue, it will normalise a few items: $ ./convert/convert /tmp/test3.cbor [ 3

Re: [Development] API review request: CBOR Stream reader and writer

2018-01-24 Thread Thiago Macieira
On Wednesday, 17 January 2018 13:25:53 PST Thiago Macieira wrote: > I'm also interested in what I could write as an example. Please send > suggestions. I've added a CBOR dump tool example, which can help you with understanding what you have: $ convert/convert -o line-wrap=no /tmp/test3.cbor { "

Re: [Development] #pragma once

2018-01-24 Thread Henry Skoglund
On 2018-01-24 16:19, Ville Voutilainen wrote: On 24 January 2018 at 16:30, Oswald Buddenhagen wrote: but that's only tangentially related to the issue at hand, because the compiler would still pick only one of the files under normal circumstances. a problem would arise if different include styl

Re: [Development] #pragma once

2018-01-24 Thread Ville Voutilainen
On 24 January 2018 at 16:30, Oswald Buddenhagen wrote: > but that's only tangentially related to the issue at hand, because the > compiler would still pick only one of the files under normal > circumstances. a problem would arise if different include styles in > different files lead to different h

Re: [Development] #pragma once

2018-01-24 Thread Oswald Buddenhagen
On Wed, Jan 24, 2018 at 06:09:06AM -0800, Thiago Macieira wrote: > On Wednesday, 24 January 2018 03:53:18 PST Konstantin Tokarev wrote: > > That's said, if headers are never copied it's safer to use #pragma once than > > include guards > > And you know what copies headers? make install > > If you

Re: [Development] #pragma once

2018-01-24 Thread Konstantin Tokarev
24.01.2018, 17:09, "Thiago Macieira" : > On Wednesday, 24 January 2018 03:53:18 PST Konstantin Tokarev wrote: >>  That's said, if headers are never copied it's safer to use #pragma once than >>  include guards > > And you know what copies headers? make install > > If you do an installed build of

Re: [Development] #pragma once

2018-01-24 Thread Thiago Macieira
On Wednesday, 24 January 2018 03:53:18 PST Konstantin Tokarev wrote: > That's said, if headers are never copied it's safer to use #pragma once than > include guards And you know what copies headers? make install If you do an installed build of each module, then the compiler will have to add -I f

[Development] Change description of strict phase to match current practice

2018-01-24 Thread Tuukka Turunen
Hi, I would like to change QUIP5 (Choosing a branch) slightly to match our current practice: https://codereview.qt-project.org/#/c/215712/ QUIP5 currently states: “*strict* This period starts when the subsequent stable branch is created (for the 5.6 LTS, this would have been 5.7).” This does

Re: [Development] #pragma once

2018-01-24 Thread Ville Voutilainen
On 24 January 2018 at 14:24, Ville Voutilainen wrote: > On 24 January 2018 at 14:19, Mitch Curtis wrote: >>> > https://en.wikipedia.org/wiki/Pragma_once#Caveats >>> >>> That wikipedia link seems to describe the problems fairly accurately. >> >> Do we have that issue in Qt? > > I do not anticipate

Re: [Development] #pragma once

2018-01-24 Thread Ville Voutilainen
On 24 January 2018 at 14:19, Mitch Curtis wrote: >> > https://en.wikipedia.org/wiki/Pragma_once#Caveats >> >> That wikipedia link seems to describe the problems fairly accurately. > > Do we have that issue in Qt? I do not anticipate to like to debug it if we hit that issue in our CI, or in a cust

Re: [Development] #pragma once

2018-01-24 Thread Mitch Curtis
> -Original Message- > From: Ville Voutilainen [mailto:ville.voutilai...@gmail.com] > Sent: Wednesday, 24 January 2018 1:11 PM > To: Mitch Curtis > Cc: Alexander Nassian ; development@qt- > project.org > Subject: Re: [Development] #pragma once > > On 24 January 2018 at 12:34, Mitch Curt

Re: [Development] #pragma once

2018-01-24 Thread Ville Voutilainen
On 24 January 2018 at 12:34, Mitch Curtis wrote: > > >> -Original Message- >> From: Ville Voutilainen [mailto:ville.voutilai...@gmail.com] >> Sent: Wednesday, 24 January 2018 11:25 AM >> To: Alexander Nassian >> Cc: Mitch Curtis ; development@qt-project.org >> Subject: Re: [Development] #

Re: [Development] #pragma once

2018-01-24 Thread Konstantin Tokarev
24.01.2018, 14:33, "Jean-Michaël Celerier" : > I certainly have been bitten much more times by include guards that were the > same in different files (especially in old libraries where guards look like > #ifdef QUEUE_H because of course there is a single queue.h file in the whole > world, or b

Re: [Development] #pragma once

2018-01-24 Thread Alexander Nassian
Besides its possible flaws, it‘s simply nothing that the C++ standard defines. I also want to use some glibc features that maybe also commonly available but it is still not standard, even worse, the implementation is completely userdefined. That same discussion raises up once a year about STL co

Re: [Development] #pragma once

2018-01-24 Thread Jean-Michaël Celerier
I certainly have been bitten much more times by include guards that were the same in different files (especially in old libraries where guards look like #ifdef QUEUE_H because of course there is a single queue.h file in the whole world, or because someone just copy-pasted the content of a file to a

Re: [Development] #pragma once

2018-01-24 Thread Mitch Curtis
> -Original Message- > From: Ville Voutilainen [mailto:ville.voutilai...@gmail.com] > Sent: Wednesday, 24 January 2018 11:25 AM > To: Alexander Nassian > Cc: Mitch Curtis ; development@qt-project.org > Subject: Re: [Development] #pragma once > > On 24 January 2018 at 12:22, Alexander Na

Re: [Development] #pragma once

2018-01-24 Thread Ville Voutilainen
On 24 January 2018 at 12:22, Alexander Nassian wrote: > Maybe because it’s not part of the C++ standard? #pragma once is not a replacement for include guards. It's not part of the C++ standard because it doesn't always work, and modules are a superior solution anyway.

Re: [Development] #pragma once

2018-01-24 Thread Alexander Nassian
Maybe because it’s not part of the C++ standard? Beste Grüße / Best regards, Alexander Nassian > Am 24.01.2018 um 11:13 schrieb Mitch Curtis : > > Why don't we use #pragma once in Qt like Qt Creator does? If it's due to old > compilers that we have to support, which ones are the problem? > > -

[Development] #pragma once

2018-01-24 Thread Mitch Curtis
Why don't we use #pragma once in Qt like Qt Creator does? If it's due to old compilers that we have to support, which ones are the problem? - Someone who just spent too much time looking at a confusing compiler error caused by duplicated include guards. __