Re: [Development] API review request: CBOR Stream reader and writer

2018-01-22 Thread Thiago Macieira
On segunda-feira, 22 de janeiro de 2018 16:56:56 PST Thiago Macieira wrote: > After fixing the converter example to properly use mmap in all three cases, > plus refactoring the CBOR parser to operate on a pre-loaded array and use > larger buffer than single-digit byte counts, the numbers are: A ma

Re: [Development] API review request: CBOR Stream reader and writer

2018-01-22 Thread Thiago Macieira
On segunda-feira, 22 de janeiro de 2018 01:37:40 PST Thiago Macieira wrote: > Binary JSON validating: > 97,003559 task-clock:u (msec) >237.092.857 cycles >437.005.872 instructions > [15.2% was spent in QIODevice::readAll, 59.1% in fromBinaryData] > > JSON pa

Re: [Development] API review request: CBOR Stream reader and writer

2018-01-22 Thread Thiago Macieira
On segunda-feira, 22 de janeiro de 2018 01:37:40 PST Thiago Macieira wrote: > CBOR parsing: > 341,311535 task-clock >885.053.081 cycles > 2.548.803.851 instructions > > The string parser is still showing up at 70.5% of the full execution time, > of which 33.4% a

Re: [Development] Using native webview on OS X

2018-01-22 Thread Alberto Mardegan
On 22/01/2018 18:49, Konstantin Tokarev wrote: > From [1] it seems like QT_MAC_USE_NATIVE_WEBVIEW environment variable > is required to use native backend. > > [1] https://codereview.qt-project.org/#/c/162337/ Yes, but still QtWebEngine is required, as QtWebView is linking to it. I've now removed

Re: [Development] Using native webview on OS X

2018-01-22 Thread Konstantin Tokarev
22.01.2018, 18:37, "Alberto Mardegan" : > Hi all! >   I've developed a desktop application which uses the WebView QML > module, with the hope of publishing it in the Apple store. However, > unless I am seriously mistaken, this is just not possible (or maybe the > documentation needs some serious

[Development] Using native webview on OS X

2018-01-22 Thread Alberto Mardegan
Hi all! I've developed a desktop application which uses the WebView QML module, with the hope of publishing it in the Apple store. However, unless I am seriously mistaken, this is just not possible (or maybe the documentation needs some serious love). No matter what I try, it seems that QtWebEng

Re: [Development] Integrating Common Print Dialog project into Qt

2018-01-22 Thread Rithvik Patibandla
On Thursday 21 December 2017 02:35 PM, Rithvik Patibandla wrote: Hi This summer, OpenPrinting [1] has created a Common Print Dialog project via the Google Summer of Code (2017) program to improve the experience of printing in Linux systems with a modern UI and backend APIs that will be maint

Re: [Development] how to include further changes while previous commit is still under review?

2018-01-22 Thread Martin Smith
>Not to mention that it's not always possible to reorder sequential commits >without conflicts That would mean changes to the same file in different commits. But that would have been already handled with a git commit --amend using pick reordering. martin

Re: [Development] how to include further changes while previous commit is still under review?

2018-01-22 Thread Konstantin Tokarev
22.01.2018, 14:47, "Martin Smith" : >> You are doing it wrong. In rebase -i menu don't reorder anything, instead >> mark commits for edit > > But then you have to do the editing with the rebase paused and then continue > the rebase. I feel less anxiety reordering the picks and completing the >

Re: [Development] how to include further changes while previous commit is still under review?

2018-01-22 Thread Martin Smith
>You are doing it wrong. In rebase -i menu don't reorder anything, instead >mark commits for edit But then you have to do the editing with the rebase paused and then continue the rebase. I feel less anxiety reordering the picks and completing the rebase before beginning the editing. martin ___

Re: [Development] how to include further changes while previous commit is still under review?

2018-01-22 Thread Konstantin Tokarev
  22.01.2018, 14:34, "Martin Smith" :> When updating the documentation, I often do 2 or more different commits and pushes to a single branch. Then I wait for them to get approved. Often, a reviewer will require changes to the first pushed commit after I have pushed the second commit. Then I do:>> g

Re: [Development] how to include further changes while previous commit is still under review?

2018-01-22 Thread Martin Smith
When updating the documentation, I often do 2 or more different commits and pushes to a single branch. Then I wait for them to get approved. Often, a reviewer will require changes to the first pushed commit after I have pushed the second commit. Then I do: git rebase -i HEAD~2 ...and I reorder

Re: [Development] Setters: Clarifying the ownership

2018-01-22 Thread Marco Bubke
Using a standard from the Cpp Core Guidelines will have the advantage of better tooling support. And please don't use the preprocessor, it will down slow the refactoring or makes it impossible. From: Development on behalf of Eric Lemanisser Sent: Saturday, Jan

Re: [Development] how to include further changes while previous commit is still under review?

2018-01-22 Thread Konstantin Tokarev
22.01.2018, 09:34, "Daniel Savi" : > After reading some of the excellent documentation on git-scm.com, I'm > planning to create two branches, one for patch 1 and one for patch 2. So, I > would do "git branch fix1", "git checkout fix1", add some changes from > review, "git commit --amend", then

Re: [Development] API review request: CBOR Stream reader and writer

2018-01-22 Thread Thiago Macieira
On quarta-feira, 17 de janeiro de 2018 13:25:53 PST Thiago Macieira wrote: > My current idea is a command-line tool that converts between serialisation > formats: > * CBOR > * CBOR diagnostic notation (output only, since I won't write the parser) > * JSON > * XML > * Qt binary JSON > * Plain

Re: [Development] QHash

2018-01-22 Thread André Somers
Hi, As already pointed out by the other responders, this cannot be an error. However, perhaps it could be a Clazy check? Because I doubt QHash does what the writer intented in the general case. André Op 18/01/2018 om 15:12 schreef René J.V. Bertin: > Hi, > > It took me a while to figure out why