Re: [Development] QML and Qt Quick versioning of our modules

2018-01-10 Thread Frederik Gladhorn
Hi, I'll start turning this thread into a QUIP here (currently empty placeholder commit): https://codereview.qt-project.org/#/c/215625/ I'll update the list when I have written something. In the mean time I'd like to ask for this to become QUIP #99 and hereby reserve the number. Cheers, Freder

Re: [Development] [FYI] the new way to retarget gerrit changes

2018-01-10 Thread Benjamin TERRIER
2018-01-10 11:23 GMT+01:00 Oswald Buddenhagen : > On Wed, Jan 10, 2018 at 10:37:25AM +0100, Benjamin TERRIER wrote: > >What happens if the change already exists in the target branch? > > > the system would tell you to contact an admin if you tried nonetheless. > > >[3]https://codereview.qt

Re: [Development] [FYI] the new way to retarget gerrit changes

2018-01-10 Thread Oswald Buddenhagen
On Wed, Jan 10, 2018 at 10:37:25AM +0100, Benjamin TERRIER wrote: >What happens if the change already exists in the target branch? > the system would tell you to contact an admin if you tried nonetheless. >[3]https://codereview.qt-project.org/#/c/214657/ > it's gone.

Re: [Development] [FYI] the new way to retarget gerrit changes

2018-01-10 Thread Edward Welbourne
Benjamin TERRIER (10 January 2018 10:37) > What happens if the change already exists in the target branch? > > As a real example I have https://codereview.qt-project.org/#/c/197888/ > that should be retargeted to the dev branch. However, as I am quite > new to gerrit I have made the mistake to pus

Re: [Development] [FYI] the new way to retarget gerrit changes

2018-01-10 Thread Benjamin TERRIER
2018-01-09 19:09 GMT+01:00 Oswald Buddenhagen : > On Tue, Jan 09, 2018 at 04:42:51PM +0100, Robert Löhning wrote: > > Will changes keep their approvals or will those be lost so that > > approvers have to give them again on the new branch? > > > this implementation calls the same underlying script