Re: [Development] Review request

2017-10-29 Thread Alberto Mardegan
On 29/10/2017 22:45, Thiago Macieira wrote: > I wish I could help in the reviews, but those are not things I understand at > all. But I can give this advice: the three changes targetting pre-5.9 need to > be updated. All three should be retargetted at 5.9. Good to know! I'll resubmit them, thank

Re: [Development] Repository request: MaterialWidgets

2017-10-29 Thread iman ahmadvand
Any reaction ? ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Getting build flags for platforms without pkg-config

2017-10-29 Thread Thiago Macieira
On domingo, 29 de outubro de 2017 14:57:44 PDT Jeandet Alexis wrote: > Hello, > > Previously I asked about getting some defines from pkg-config, I pushed > some code on gerrit to fix that. > > Now I would like to care about platforms where we don't use pkg-config, > at first I thought that we cou

[Development] Getting build flags for platforms without pkg-config

2017-10-29 Thread Jeandet Alexis
Hello, Previously I asked about getting some defines from pkg-config, I pushed some code on gerrit to fix that. Now I would like to care about platforms where we don't use pkg-config, at first I thought that we could get compile flags from qmake but it seems that no. Did I miss something? Would

Re: [Development] Review request

2017-10-29 Thread Thiago Macieira
On Sunday, 29 October 2017 11:52:02 PDT Alberto Mardegan wrote: > Hi there! > I've got a few merge proposals which were recently closed by the Qt > cleanup bot due to lack of activity; I've reopened them and ping a few > people, but to no avail. > All but one are tiny, and I would appreciate if s

[Development] Review request

2017-10-29 Thread Alberto Mardegan
Hi there! I've got a few merge proposals which were recently closed by the Qt cleanup bot due to lack of activity; I've reopened them and ping a few people, but to no avail. All but one are tiny, and I would appreciate if someone could spend a couple of minutes to give the final +2 or to advise a