Re: [Development] Documentation typo fixes

2017-02-06 Thread Sze Howe Koh
On 7 February 2017 at 08:39, Ch'Gans wrote: > > Hi there, > > It's been a while that I notice some typos here and there in Qt5 > documentation (mainly qtbase), and i decided that i would start > correcting them in the source code. > Most of them are really straight forward, eg. in QGraphicsView::s

[Development] Documentation typo fixes

2017-02-06 Thread Ch'Gans
Hi there, It's been a while that I notice some typos here and there in Qt5 documentation (mainly qtbase), and i decided that i would start correcting them in the source code. Most of them are really straight forward, eg. in QGraphicsView::setTransform: "To simplify interation with items using a tr

Re: [Development] Nominate Mike Krus as approver

2017-02-06 Thread Thiago Macieira
On segunda-feira, 6 de fevereiro de 2017 18:39:19 PST Oswald Buddenhagen wrote: > On Mon, Feb 06, 2017 at 02:54:53PM +, Alexander Blasche wrote: > > >There were no objections and maintainer of a module implies approver, so > > >could somebody do the honours and grant Mike the rights please? Th

Re: [Development] Nominate Mike Krus as approver

2017-02-06 Thread Oswald Buddenhagen
On Mon, Feb 06, 2017 at 02:54:53PM +, Alexander Blasche wrote: > >There were no objections and maintainer of a module implies approver, so > >could > >somebody do the honours and grant Mike the rights please? The necessary > >period > >has long since passed. > > I am sorry but being the main

Re: [Development] Nominate Mike Krus as approver

2017-02-06 Thread Jake Petroules
+1 for Mike Krus as Approver. > On Feb 6, 2017, at 8:11 AM, Sergio Martins wrote: > > On 2017-02-06 14:54, Alex Blasche wrote: >>> There were no objections and maintainer of a module implies approver, so >>> could >>> somebody do the honours and grant Mike the rights please? The necessary >>>

Re: [Development] HEADS-UP: 5.6 / LTS is now open for business

2017-02-06 Thread Thiago Macieira
On segunda-feira, 6 de fevereiro de 2017 07:34:35 PST Alex Blasche wrote: > Hi, > > It would help to actually state the rules the bot is following. > > This case below is an assumption since you don't really name the rules and I > am interpreting in between your lines: > > How do I stage a chang

Re: [Development] Feature Freeze Exception: QStringView

2017-02-06 Thread Thiago Macieira
On segunda-feira, 6 de fevereiro de 2017 10:33:52 PST Edward Welbourne wrote: > Thiago Macieira (3 February 2017 17:45) > > > It's irrelevant when the function called is one of ours, in a library > > of ours that got compiled with -fno-exceptions. It'll never > > throw. Even the few libraries we c

[Development] [Announcement] QtWebKit Technology Preview 5

2017-02-06 Thread Konstantin Tokarev
Hi all, QtWebKit Technology Preview 5 is out. Highlights of these release are: * WebGL, accelerated compositing and accelerated 2D canvas are supported now. Accelerated compositing is disabled by default for now, it is known to cause minor artifacts on some sites. * MinGW compiler is now full

Re: [Development] Nominate Mike Krus as approver

2017-02-06 Thread Sergio Martins
On 2017-02-06 14:54, Alex Blasche wrote: There were no objections and maintainer of a module implies approver, so could somebody do the honours and grant Mike the rights please? The necessary period has long since passed. I am sorry but being the maintainer does not imply approver rights. h

Re: [Development] Nominate Mike Krus as approver

2017-02-06 Thread Sean Harmer
On Monday 06 February 2017 14:54:53 Alex Blasche wrote: > >There were no objections and maintainer of a module implies approver, so > >could somebody do the honours and grant Mike the rights please? The > >necessary period has long since passed. > > I am sorry but being the maintainer does not imp

Re: [Development] Nominate Mike Krus as approver

2017-02-06 Thread Milian Wolff
On Monday, February 6, 2017 1:29:18 PM CET Bogdan Vatra wrote: > On luni, 6 februarie 2017 12:26:03 EET Sean Harmer wrote: > > Hi, > > > > I'd like to nominate Mike Krus as an approver. Mike contributed support > > for > > Qt on tvOS along with the refactoring that went in as part of this. Mike >

Re: [Development] Nominate Mike Krus as approver

2017-02-06 Thread Alex Blasche
>There were no objections and maintainer of a module implies approver, so could >somebody do the honours and grant Mike the rights please? The necessary period >has long since passed. I am sorry but being the maintainer does not imply approver rights. At most it implies approver rights for the c

Re: [Development] Nominate Mike Krus as approver

2017-02-06 Thread Sean Harmer
Hi, in fact, I've just been reminded we already proposed and voted for Mike as maintainer of the tvOS system last year: http://lists.qt-project.org/pipermail/development/2016-August/026903.html There were no objections and maintainer of a module implies approver, so could somebody do the honou

Re: [Development] Nominate Mike Krus as approver

2017-02-06 Thread Bogdan Vatra
On luni, 6 februarie 2017 12:26:03 EET Sean Harmer wrote: > Hi, > > I'd like to nominate Mike Krus as an approver. Mike contributed support for > Qt on tvOS along with the refactoring that went in as part of this. Mike > has done a lot of work within Qt 3D too. > > Disclaimer: Mike is a colleague

[Development] Nominate Mike Krus as approver

2017-02-06 Thread Sean Harmer
Hi, I'd like to nominate Mike Krus as an approver. Mike contributed support for Qt on tvOS along with the refactoring that went in as part of this. Mike has done a lot of work within Qt 3D too. Disclaimer: Mike is a colleague at KDAB. Cheers, Sean -- Dr Sean Harmer | sean.har...@kdab.com | M

Re: [Development] HEADS-UP: 5.6 / LTS is now open for business

2017-02-06 Thread André Hartmann
Hi Oswald, > look at the changes' review comments? Sorry for the noise. Now I got it :) Thanks, André Am 06.02.2017 um 10:59 schrieb Oswald Buddenhagen: On Mon, Feb 06, 2017 at 09:24:33AM +0100, André Hartmann wrote: and what about changes already uploaded to Gerrit, containing a cherry-pick

Re: [Development] Feature Freeze Exception: QStringView

2017-02-06 Thread Edward Welbourne
>>> [followed by exception handling code irrelevant for us] >> >> I disagree. The exception code is not irrelevant for our users (and >> not for us, either, e.g. in QtCore). Thiago Macieira (3 February 2017 17:45) > It's irrelevant when the function called is one of ours, in a library > of ours th

Re: [Development] HEADS-UP: 5.6 / LTS is now open for business

2017-02-06 Thread Oswald Buddenhagen
On Mon, Feb 06, 2017 at 12:56:24PM +0300, Konstantin Tokarev wrote: > 04.02.2017, 01:23, "Oswald Buddenhagen" : > > note that there is an exception to the policy as well: the qt5 super > > repo continues to operate in forward-merge mode also for the LTS branch. > > you probably don't care unless yo

Re: [Development] HEADS-UP: 5.6 / LTS is now open for business

2017-02-06 Thread Oswald Buddenhagen
On Mon, Feb 06, 2017 at 09:24:33AM +0100, André Hartmann wrote: > and what about changes already uploaded to Gerrit, containing a > cherry-pick line? > look at the changes' review comments? ___ Development mailing list Development@qt-project.org http://

Re: [Development] HEADS-UP: 5.6 / LTS is now open for business

2017-02-06 Thread Konstantin Tokarev
04.02.2017, 01:23, "Oswald Buddenhagen" : > moin, > > we finally managed to add a cherry-pick validator to the sanity bot, so > i dared to open the 5.6 branch for staging again. > > caveat: patchsets created before the final forward merge got a positive > review while they aren't cherry-picks. i

Re: [Development] HEADS-UP: 5.6 / LTS is now open for business

2017-02-06 Thread Oswald Buddenhagen
On Mon, Feb 06, 2017 at 07:34:35AM +, Alexander Blasche wrote: > How do I stage a change that is not a cherry-pick? Yes, they do exist > and I can name a few cases where this makes sense especially since we > are talking about 3 minor releases of Qt in between. > you override the bot, clearly

Re: [Development] HEADS-UP: 5.6 / LTS is now open for business

2017-02-06 Thread André Hartmann
Hi, and what about changes already uploaded to Gerrit, containing a cherry-pick line? They cannot be uploaded again without changing at least the commit message. What should happen there? Best regards, André Am 06.02.2017 um 08:34 schrieb Alex Blasche: Hi, It would help to actually state