> The leading comma's are also helpful if we have some part of the
> initializer list protected by a preprocessor conditional (or might be
> needed in the future).
This is right.
This is what CLangFormat proposed me by default.
I thought is was a bit strange when I started to use this, but now I
w
> only the value of around 50ms gives a stable result in my case.
Hehh.. I warned the QtSerialBus team that introduction of 3.5 timeouts
will lead to bugs and that it doesn't make sense (though, it is
described in the Modbus specification). We do not need to rely on this
'characters timeouts',
On quarta-feira, 1 de junho de 2016 21:05:09 BRT Thiago Macieira wrote:
> On quarta-feira, 1 de junho de 2016 15:49:20 BRT Jędrzej Nowacki wrote:
> > Btw. How often do you
> >
> > _read_ commas? My brain automatically skips them... In the end it simply
> > doesn't matter much.
>
> Quite often. T
On quarta-feira, 1 de junho de 2016 12:56:12 BRT Simon Hausmann wrote:
> Hi,
>
> I'm in favorof changing our coding style to adopt the model you call "butt
> ugly" because I find it more appealing and I find that it makes diffs
> easier to read.
I object to that, I have rejected patches to QtCore
On quarta-feira, 1 de junho de 2016 15:06:16 BRT Mark Gaiser wrote:
> The "butt-ugly" style looks more readable to me.
> And imho it reduces the possibility of forgetting a forgetting a comma in
> the begin since then your arguments will look out of alignment.
The compiler won't let you forget, so
On quarta-feira, 1 de junho de 2016 15:49:20 BRT Jędrzej Nowacki wrote:
> Btw. How often do you
> _read_ commas? My brain automatically skips them... In the end it simply
> doesn't matter much.
Quite often. There's this author I'm reading that often forgets commas when
writing things like:
And another +1
cu
Robert
On 01.06.2016 14:56, Simon Hausmann wrote:
Hi,
I'm in favorof changing our coding style to adopt the model you call
"butt ugly" because I find it more appealing and I find that it makes
diffs easier to read.
Simon
The leading comma's are also helpful if we have some part of the
initializer list protected by a preprocessor conditional (or might be
needed in the future).
QFoo::QFoo()
: QBase()
, m_f1()
#ifdef XYZ
, m_f2()
#endif
, m_f3()
Although I'm not sure if we have many (of any at all) such inst
On 6/1/16, 5:27 PM, "Development on behalf of Marc Mutz"
wrote:
...
>Semicolons and commas are visually *designed* to be
>trailing. And consequently every C++ text book uses trailing commas.
The pros that have been cited include code review and diffs for leading commas.
One nice thing about
On Wednesday 01 June 2016 16:33:39 Sergio Martins wrote:
> On Wednesday, 1 June 2016 15:44:22 WEST Marc Mutz wrote:
> > On Wednesday 01 June 2016 15:15:17 Sergio Martins wrote:
> > > Subjective reasons against leading commas:
> > > - It's ugly
> > >
> > > Subjective reasons against trailling comma
And another +1 from me.
--
Robin Burchell
On Wed, Jun 1, 2016, at 09:23 PM, Andy Nichols wrote:
> +1 to specify the coding style to be the "butt ugly" one.
>
> I'm one of those who has (not so secretly) been committing and approving
> the offending style after all ;-) Though for the record I
+1 to specify the coding style to be the "butt ugly" one.
I'm one of those who has (not so secretly) been committing and approving the
offending style after all ;-) Though for the record I did not think it
mattered and was not covered by the style guideline you cited.
Andy Nichols
> On 01 Jun
On 01/06/2016 18:12, Mathias Hasselmann wrote:
> Yes, when it comes to initializer lists the trailing comma looks ugly to
> me. Because of the inconsistent two-space indent for the first
> initializer. Because line starts of are not aligned.
In my projects I use this style:
MyObject::MyObject():
Okay. I think i found the source of problem. Calculation of send timeout is
incorrect.
Here is the calculation code:
http://code.qt.io/cgit/qt/qtserialbus.git/tree/src/serialbus/qmodbusrtuserialmaster_p.h#n294
// Example: 9600 baud, 11 bit per packet -> 872 char/sec
// so
In previous projects I have worked on, the "leading comma" was done because it
makes it easier if you have #ifdef'ed variables that need initialization.
You are less likely to introduce a syntax error when the defined variable is
not set..
Ie, the first one causes a syntax error
QFoo::QFoo()
Am 01.06.2016 um 15:15 schrieb Sergio Martins:
On Wednesday, 1 June 2016 14:41:30 WEST Marc Mutz wrote:
Hi,
There seems to have been a silent underground move to uglify the Qt sources
, by using commas to introduce lines
. I have no idea where this came from
, but it looks butt
-ugly and it i
First of all: Thank you Marc for raising that topic. Actually it also
concerned me quite often, but so far I was to shy to mention this very
opinionated topic.
Am 01.06.2016 um 15:44 schrieb Marc Mutz:
> On Wednesday 01 June 2016 15:15:17 Sergio Martins wrote:
>> On Wednesday, 1 June 2016 14:41
+1 from me as well.
The argument about natural language makes no sense to me;
Nothing in C++ resembles natural grammar, nor should it;
It might take some getting used to,
like any change in style,
but after a while you won't think it is ugly anymore,
and then we can reap the benefits o
Jędrek remarked:
>> argument about how similar code is to natural language is a bit odd
>> to me, I'm not aware of any successful programing language that
>> simulates natural grammar :-) .
On 1st June 2016 at 16:17 Konstantin Tokarev added to the discussion:
> For example, Perl is somewhat closer
On Wednesday, 1 June 2016 15:44:22 WEST Marc Mutz wrote:
> On Wednesday 01 June 2016 15:15:17 Sergio Martins wrote:
> > Subjective reasons against leading commas:
> > - It's ugly
> >
> > Subjective reasons against trailling commas:
> > - It's ugly
>
> I beg your pardon? Trailing commas are ugly?
01.06.2016, 16:50, "Jędrzej Nowacki" :
> On Wednesday 01 of June 2016 15:16:01 Andreas Aardal Hanssen wrote:
>> > Den 1. jun. 2016 kl. 15.06 skrev Mark Gaiser :
>> > ...
>> > Funny in the coding style you mention. For operators: "An operator at the
>> > end of the line is easy to miss if the
On Wednesday 01 of June 2016 15:44:22 Marc Mutz wrote:
> > Subjective reasons against trailling commas:
> > - It's ugly
>
> I beg your pardon? Trailing commas are ugly? So where's the text editor
> that folds prose text to have commas on the next line?
Aesthetics are subjective by definition, you
On Wednesday 01 of June 2016 15:16:01 Andreas Aardal Hanssen wrote:
> > Den 1. jun. 2016 kl. 15.06 skrev Mark Gaiser :
> > ...
> > Funny in the coding style you mention. For operators: "An operator at the
> > end of the line is easy to miss if the editor is too narrow." The exact
> > same could be
On Wednesday 01 June 2016 15:15:17 Sergio Martins wrote:
> On Wednesday, 1 June 2016 14:41:30 WEST Marc Mutz wrote:
> > Hi,
> >
> > There seems to have been a silent underground move to uglify the Qt
> > sources , by using commas to introduce lines
> > . I have no idea where this came from
> > , b
On Mittwoch, 1. Juni 2016 12:56:12 CEST Simon Hausmann wrote:
> Hi,
>
> I'm in favorof changing our coding style to adopt the model you call "butt
> ugly" because I find it more appealing and I find that it makes diffs
> easier to read.
>
> Simon
+1 as well, if someone counts the votes!
Also
On Wednesday, June 1, 2016 12:56:12 PM CEST Simon Hausmann wrote:
> Hi,
>
> I'm in favorof changing our coding style to adopt the model you call "butt
> ugly" because I find it more appealing and I find that it makes diffs
> easier to read.
+1, less diff noise when an initializer is added/removed
> Den 1. jun. 2016 kl. 15.06 skrev Mark Gaiser :
> ...
> Funny in the coding style you mention. For operators: "An operator at the end
> of the line is easy to miss if the editor is too narrow." The exact same
> could be said for commas at the end of the line.
Silly point, it's pretty much a gi
On Wednesday, 1 June 2016 14:41:30 WEST Marc Mutz wrote:
> Hi,
>
> There seems to have been a silent underground move to uglify the Qt sources
> , by using commas to introduce lines
> . I have no idea where this came from
> , but it looks butt
> -ugly and it is in violation of http
> (http://wiki.
On Wed, Jun 1, 2016 at 2:41 PM, Marc Mutz wrote:
> Hi,
>
> There seems to have been a silent underground move to uglify the Qt sources
> , by using commas to introduce lines
> . I have no idea where this came from
> , but it looks butt
> -ugly and it is in violation of http
> ://wiki
> .qt
> .io
+1 for changing they coding style
Am 06/01/2016 um 02:56 PM schrieb Simon Hausmann:
> Hi,
>
> I'm in favorof changing our coding style to adopt the model you call
> "butt ugly" because I find it more appealing and I find that it makes
> diffs easier to read.
>
> Simon
>
>
> --
Hi,
I'm in favorof changing our coding style to adopt the model you call "butt
ugly" because I find it more appealing and I find that it makes diffs easier to
read.
Simon
From: Marc Mutz
Sent: Jun 1, 2016 14:41
To: development@qt-project.org
Subject: [Develop
Hi,
There seems to have been a silent underground move to uglify the Qt sources
, by using commas to introduce lines
. I have no idea where this came from
, but it looks butt
-ugly and it is in violation of http
://wiki
.qt
.io
/Qt_Coding_Style
QFoo::QFoo()
: QBase(),
m_f1(),
m_f2()
{
Hi all,
We have finally Qt 5.7.0 rc packages for testing:
Windows: http://download.qt.io/snapshots/qt/5.7/5.7.0-rc/482/
Linux: http://download.qt.io/snapshots/qt/5.7/5.7.0-rc/442/
Mac: http://download.qt.io/snapshots/qt/5.7/5.7.0-rc/376/
src: http://download.qt.io/snapshots/qt/5.7/5.7.0-rc/l
Congratulations to Alexandru. Approver rights have been granted.
--
Alex
From: Development
on behalf of Michael Brüning
Sent: Wednesday, 11 May 2016 1:14:09 PM
To: development@qt-project.org
Subject: [Development] Nominating Alexandru Croitor for Approv
34 matches
Mail list logo
