Re: [Development] crash in qt_mac_create_imagemask while printing from KDE application

2015-06-06 Thread René J . V . Bertin
René J.V. Bertin wrote: In addition to px->pixels==NULL (which it isn't always when the crash occurs), I also notice that px->bytesPerRow has a suspicious value. When I see the line `srow = sptr + (y * (sbpr / 4));`, I think that sbpr (px->bytesPerRow) should be equal or a known multiple of th

[Development] crash in qt_mac_create_imagemask while printing from KDE application

2015-06-06 Thread René J . V . Bertin
Hello, Is there anything that can be done with a backtrace like the one below that would make it worthwhile to file a bug report? Some prodding after liberal use of `volatile` in qt_mac_create_imagemask suggests that px->pixels==NULL R. (lldb) bt all * thread #1: tid = 0x6280a, 0x7fff8914

Re: [Development] Fwd: [Qt bugreports] (QTBUG-46505) assertion failure (=> crash) in harfbuzz-shaper

2015-06-06 Thread René J . V . Bertin
On Saturday June 06 2015 13:25:10 Thiago Macieira wrote: > If you're hitting an assert, disabling the assert will make the problem > worse. Of course, but that doesn't mean by definition that the assert was there to avoid a crash. I've already seen them used as a cheap way to verify assumptio

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Thiago Macieira
On Saturday 06 June 2015 14:22:20 Giuseppe D'Angelo wrote: > Il 06/06/2015 13:27, Thiago Macieira ha scritto: > > Then why do we need them in QSslSocket? > > Technically they are be needed there, indeed, but I didn't want to cause > an API asymmetry with the other functions for ciphers, certificat

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Giuseppe D'Angelo
Il 06/06/2015 13:27, Thiago Macieira ha scritto: Then why do we need them in QSslSocket? Technically they are be needed there, indeed, but I didn't want to cause an API asymmetry with the other functions for ciphers, certificates and so on, that's all. -- Giuseppe D'Angelo | giuseppe.dang..

Re: [Development] Qt 5.5.0 header diff: QtXml.diff

2015-06-06 Thread Knoll Lars
Looks good. Cheers, Lars On 05/06/15 10:11, "development-bounces+lars.knoll=theqtcompany@qt-project.org on behalf of Frederik Gladhorn" wrote: > ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/list

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Thiago Macieira
On Saturday 06 June 2015 11:30:39 Giuseppe D'Angelo wrote: > Il 06/06/2015 11:20, Thiago Macieira ha scritto: > > These should be in QSslConfiguration, not QSslSocket. > > They're in both, just like ciphers, certificates etc. Then why do we need them in QSslSocket? -- Thiago Macieira - thiago.ma

Re: [Development] Qt 5.5.0 header diff: QtGui.diff

2015-06-06 Thread Thiago Macieira
On Saturday 06 June 2015 11:03:43 Allan Sandfeld Jensen wrote: > On the topic of qpen.h, I am a little concerned about the addition of > Q_DECL_NOTHROW to the two non-inlined methods QPen(const QPen &pen) and > QPen &operator=(const QPen &pen). Q_DECL_NOEXCEPT should be fine I think, > but throw(

Re: [Development] Fwd: [Qt bugreports] (QTBUG-46505) assertion failure (=> crash) in harfbuzz-shaper

2015-06-06 Thread Thiago Macieira
On Saturday 06 June 2015 10:20:56 René J.V. Bertin wrote: > On Saturday June 06 2015 00:36:14 Thiago Macieira wrote: > > Yes, I noticed that Qt4 doesn't use the system harfbuzz for whatever reason. > >> As asked in the bug report below: is it necessary to handle this > >> situation > >> with an as

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Giuseppe D'Angelo
Il 06/06/2015 11:20, Thiago Macieira ha scritto: These should be in QSslConfiguration, not QSslSocket. They're in both, just like ciphers, certificates etc. -- Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Software Engineer KDAB (UK) Ltd., a KDAB Group company | Tel: UK +44-1625-809908 KDAB

Re: [Development] Qt 5.5.0 header diff: QtDeclarative.diff

2015-06-06 Thread Liang Qi
On 6 June 2015 at 10:52, Allan Sandfeld Jensen wrote: > On Friday 05 June 2015, Frederik Gladhorn wrote: > > > > Would there be any way to generate diffs or changes for QML APIs? > Perhaps a diff for all plugins.qmltypes files? But I guess that not all were updated yet. -- http://www.qiliang.n

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:29 Frederik Gladhorn wrote: > +// EC settings. > +QVector ellipticCurves() const; > +void setEllipticCurves(const QVector &curves); > +static void setDefaultEllipticCurves(const QVector > &curves); +static QVector defaultEllipticCurves(); > +stat

Re: [Development] Qt 5.5.0 header diff: QtQml.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 12:24:36 Simon Hausmann wrote: > Those changes were not on qqmlerror.h but on qqmlfile.h. However the class > in question - while exported - is marked as \internal in the docs. > > If it's ok with everyone, then I'll rename qqmfile.h into qqmlfile_p.h. If it is not used, s

Re: [Development] Qt 5.5.0 header diff: QtCore.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:28 Frederik Gladhorn wrote: > I can't tell if the qmetatype.h template magic is binary compatible or not. As evidenced by a recent push [1] about the IsGadget flag, it isn't. I'm going to put a stop to this. qmetatype.h template magic is now frozen as of Qt 5.5 and

Re: [Development] Qt 5.5.0 header diff: QtGui.diff

2015-06-06 Thread Allan Sandfeld Jensen
On Friday 05 June 2015, Frederik Gladhorn wrote: > Something is wrong with the diff. The qpen.h diff is listed as src/gui/painting/qpdfwriter.h. On the topic of qpen.h, I am a little concerned about the addition of Q_DECL_NOTHROW to the two non-inlined methods QPen(const QPen &pen) and QPen &op

Re: [Development] Qt 5.5.0 header diff: QtDeclarative.diff

2015-06-06 Thread Allan Sandfeld Jensen
On Friday 05 June 2015, Frederik Gladhorn wrote: > Would there be any way to generate diffs or changes for QML APIs? `Allan ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Fwd: [Qt bugreports] (QTBUG-46505) assertion failure (=> crash) in harfbuzz-shaper

2015-06-06 Thread René J . V . Bertin
On Saturday June 06 2015 00:36:14 Thiago Macieira wrote: Reminds me: configure --help suggests that even when building without -harfbuzz, one can activate harfbuzz by using an env. variable. From what I recall I never even found trace of the env. variable name in the code, so if that's still su

Re: [Development] Fwd: [Qt bugreports] (QTBUG-46505) assertion failure (=> crash) in harfbuzz-shaper

2015-06-06 Thread René J . V . Bertin
On Saturday June 06 2015 00:36:14 Thiago Macieira wrote: Yes, I noticed that Qt4 doesn't use the system harfbuzz for whatever reason. >> As asked in the bug report below: is it necessary to handle this situation >> with an assert/abort, instead of simply returning (with whatever error the >> void

Re: [Development] Qt 5.5.0 header diff: QtSql.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:26 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtBluetooth.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:25 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtOpenGL.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:23 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtScriptTools.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:22 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtPrintSupport.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:21 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtQuick.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:20 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtWebSockets.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:11:19 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtMultimediaWidgets.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:53 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtX11Extras.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:54 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:52 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtDeclarative.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:49 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtScript.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:51 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtPositioning.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:50 Frederik Gladhorn wrote: > -qreal distanceTo(const QGeoCoordinate &other) const; > -qreal azimuthTo(const QGeoCoordinate &other) const; > +Q_INVOKABLE qreal distanceTo(const QGeoCoordinate &other) const; > +Q_INVOKABLE qreal azimuthTo(const QGeoCoordi

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:47 Frederik Gladhorn wrote: > +Q_TESTLIB_EXPORT QString qExtractTestData(const QString &dirName); > This API isn't finished. The function needs to return a QTemporaryDir (which implies passing in by output parameter) so that the caller properly cleans up the ex

Re: [Development] Qt 5.5.0 header diff: QtSerialPort.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:47 Frederik Gladhorn wrote: > +#if QT_DEPRECATED_SINCE(5, 2) > +QT_DEPRECATED void dataErrorPolicyChanged(QSerialPort::DataErrorPolicy > policy); > +#endif > void dataTerminalReadyChanged(bool set); > void requestToSendChanged(bool set); > void error

Re: [Development] Qt 5.5.0 header diff: QtQuickWidgets.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:46 Frederik Gladhorn wrote: > +#ifndef QT_NO_DRAGANDDROP > +virtual void dragEnterEvent(QDragEnterEvent *); > +virtual void dragMoveEvent(QDragMoveEvent *); > +virtual void dragLeaveEvent(QDragLeaveEvent *); > +virtual void dropEvent(QDropEvent *); > +#e

Re: [Development] Qt 5.5.0 header diff: QtXmlPatterns.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:45 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtWebChannel.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:43 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtSvg.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:44 Frederik Gladhorn wrote: > No changes, good. We ought to stop revving the version number for libraries that did not update at all... -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center __

Re: [Development] Qt 5.5.0 header diff: QtMultimediaQuick_p.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:42 Frederik Gladhorn wrote: > Private library. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://li

Re: [Development] Qt 5.5.0 header diff: QtNfc.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:41 Frederik Gladhorn wrote: > +//TODO Qt 6 the mimetype should be QString as it is UTF-8 Looks good, except the comment. We usually use "### Qt6" as a marker, not "TODO". -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source

Re: [Development] Qt 5.5.0 header diff: QtConcurrent.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:39 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtGui.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:38 Frederik Gladhorn wrote: > +++ b/src/gui/accessible/qaccessible.h > @@ -60,7 +60,6 @@ class QTextCursor; > class Q_GUI_EXPORT QAccessible > @@ -635,6 +636,12 @@ public: > static const QString &showMenuAction(); > static const QString &setFocusAction(); >

Re: [Development] Qt 5.5.0 header diff: QtLocation.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:37 Frederik Gladhorn wrote: > Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.q

Re: [Development] Qt 5.5.0 header diff: QtQuickTest.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:37 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l

Re: [Development] Qt 5.5.0 header diff: QtSensors.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:34 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://

Re: [Development] Qt 5.5.0 header diff: QtOpenGLExtensions.diff

2015-06-06 Thread Thiago Macieira
On Friday 05 June 2015 10:10:35 Frederik Gladhorn wrote: > No changes, good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://l