On Friday 06 March 2015 17:42:00 Oswald Buddenhagen wrote:
> 1) i'd like to propose the introduction of the code review score -3.
> -1: "I would prefer this is not merged as is", advisory, non-sticky
> -2: "This shall not be merged as is", blocking, non-sticky
> -3: "This shall not be merged [at a
On Fri, Mar 06, 2015 at 06:10:46PM +0100, Christian Kandeler wrote:
> On 03/06/2015 05:42 PM, Oswald Buddenhagen wrote:
> > -1: "I would prefer this is not merged as is", advisory, non-sticky
> > -2: "This shall not be merged as is", blocking, non-sticky
> > -3: "This shall not be merged [at all]",
On Fri, 6 Mar 2015, Oswald Buddenhagen wrote:
> 1) i'd like to propose the introduction of the code review score -3.
I often wished for Gerrit have a non-sticky -2. The proposed introduction
of -3 is a good solution.
> 2) i'd like to propose the introduction of the code review score +3.
Could
On 03/06/2015 05:42 PM, Oswald Buddenhagen wrote:
> 1) i'd like to propose the introduction of the code review score -3.
>
> rationale: it's quite common that a particular patchset is so broken
> that it must not be merged. this is typically done by giving a -2 score,
> in particular when it's need
moin,
1) i'd like to propose the introduction of the code review score -3.
rationale: it's quite common that a particular patchset is so broken
that it must not be merged. this is typically done by giving a -2 score,
in particular when it's needed to counterweight a pre-existing +2 score
(yes, pe
On 06/03/15 09:54, "Marc Mutz" wrote:
>On Tuesday 03 March 2015 11:30:51 Guido Seifert wrote:
>> Why not make different example categories?
>
>a) because it's more work, less fun, and people don't work on examples
>anyway,
> but they might, when they can modernize them.
>b) because one reason w
On Tuesday 03 March 2015 11:30:51 Guido Seifert wrote:
> Why not make different example categories?
a) because it's more work, less fun, and people don't work on examples anyway,
but they might, when they can modernize them.
b) because one reason we want to have this is to experiment with C++11
Hi!
I see that the first decisive commit is already merged but I'd like to
comment on it anyway:
On Mon, 2 Mar 2015, Rutledge Shawn wrote:
It may be a surprise though, for some applications, that
QGuiApplication::primaryScreen() can return null in the case where there
is really no screen at
