Re: [Development] Qt 4.x and Qt 5 frameworks should use @rpath (QTBUG-31814)

2014-08-08 Thread Thiago Macieira
On Friday 08 August 2014 15:22:44 Jake Petroules wrote: > In qmake, can you explain why we can't use: > QCoreApplication::applicationFilePath() + "/../bin", etc.? Because that might be completely different on other machines. The prefix to the bin directory is a user choice on configuring, just as

Re: [Development] Qt 4.x and Qt 5 frameworks should use @rpath (QTBUG-31814)

2014-08-08 Thread Jake Petroules
On 2014-08-08, at 11:20 AM, Thiago Macieira wrote: > On Thursday 07 August 2014 17:11:49 Jake Petroules wrote: Next steps: (1) changes to macdeployqt (removing absolute rpath & rewrite) (2) remove rewriting in installer-framework >>> >>> Please don't remove the rewriting of qmake

Re: [Development] Feature Freeze Exception Request for QVersionNumber and QVolumeInfo

2014-08-08 Thread Knoll Lars
Yes, you still have the weekend. I don’t think we’ll create the 5.4 branch before Monday. Cheers, Lars On 08/08/14 17:28, "Thiago Macieira" wrote: >On Friday 08 August 2014 19:26:25 Иван Комиссаров wrote: >> Should i continue pushing changes to dev branch or switch to 5.4? > >5.4 once it exists

Re: [Development] Feature Freeze Exception Request for QVersionNumber and QVolumeInfo

2014-08-08 Thread Thiago Macieira
On Friday 08 August 2014 19:26:25 Иван Комиссаров wrote: > Should i continue pushing changes to dev branch or switch to 5.4? 5.4 once it exists, dev until then. > > Is there anyone who will review during weekend? :-P I'm around. I'm not receiving Gerrit email, but I am looking at the Dashboard

Re: [Development] Feature Freeze Exception Request for QVersionNumber and QVolumeInfo

2014-08-08 Thread Иван Комиссаров
Should i continue pushing changes to dev branch or switch to 5.4? Is there anyone who will review during weekend? :-P Иван Комиссаров 08 авг. 2014 г., в 19:21, Thiago Macieira написал(а): > On Friday 08 August 2014 11:13:47 Marc Mutz wrote: >> Hi Lars, >> >> the above two classes are next to

Re: [Development] Feature Freeze Exception Request for QVersionNumber and QVolumeInfo

2014-08-08 Thread Thiago Macieira
On Friday 08 August 2014 11:13:47 Marc Mutz wrote: > Hi Lars, > > the above two classes are next to compled, but will fail the deadline by a > few hours, max. The're both in the seventies, change-set wise, and have at > one point or another been already accepted. > > https://codereview.qt-proje

Re: [Development] Qt 4.x and Qt 5 frameworks should use @rpath (QTBUG-31814)

2014-08-08 Thread Thiago Macieira
On Thursday 07 August 2014 17:11:49 Jake Petroules wrote: > >> Next steps: > >> (1) changes to macdeployqt (removing absolute rpath & rewrite) > >> (2) remove rewriting in installer-framework > > > > Please don't remove the rewriting of qmake itself. > > Please elaborate? qmake is an executable a

Re: [Development] Nominating Milian Wolff as approver

2014-08-08 Thread Milian Wolff
On Friday 08 August 2014 13:24:20 Frederik Gladhorn wrote: > It's been ~15 working days, congrats Milian :) > > Alex, can you flip the jira bit? Thanks for the support everyone! Bye -- Qt Developer Days 2014 - October 6 - 8 at BCC, Berlin Milian Wolff | milian.wo...@kdab.com | Software Enginee

Re: [Development] Nominating Milian Wolff as approver

2014-08-08 Thread Frederik Gladhorn
It's been ~15 working days, congrats Milian :) Alex, can you flip the jira bit? Cheers, Frederik On Tuesday, July 15, 2014 08:08:39 PM Gladhorn Frederik wrote: > Hi all, > > it’s my pleasure to nominate Milian Wolff as approver. He’s a great guy, > works for KDAB and has done interesting work o

[Development] Feature Freeze Exception Request for QVersionNumber and QVolumeInfo

2014-08-08 Thread Marc Mutz
Hi Lars, the above two classes are next to compled, but will fail the deadline by a few hours, max. The're both in the seventies, change-set wise, and have at one point or another been already accepted. https://codereview.qt-project.org/73945 https://codereview.qt-project.org/82170 I think

Re: [Development] Qt 4.x and Qt 5 frameworks should use @rpath (QTBUG-31814)

2014-08-08 Thread Adam Strzelecki
> How does a launched application find the Qt frameworks that were installed by > the SDK? And how do those frameworks find the plugins? "Phase I" changes does not change workflow, so all apps built with Qt find Qt libraries as before. Since all Qt libraries are now using @rpath id prefix they