On Thursday 2. January 2014 09.34.21 Konstantin Ritt wrote:
> 1. In cpp, we typically use enums for numeric constants. In Qt coding
> style, enums are in CamelCase.
> 2. Just a wasting of time. Simply use generated documentation rather than
> scroll over the header files (Qt docs are very good, you
1. In cpp, we typically use enums for numeric constants. In Qt coding
style, enums are in CamelCase.
2. Just a wasting of time. Simply use generated documentation rather than
scroll over the header files (Qt docs are very good, you know).
Regards,
Konstantin
2014/1/2 Jiergir Ogoerg
> Hi,
>
> 1
Hi,
1. Constant names
Typically constants are named UPPER_CASE which is slightly annoying
(looks like shouting) and look like macros which are also named upper case.
I'd propose naming constants with a lowercase "k" followed by camel case:
const int kMonthCount = 12;
It makes it easy to distingu
On Thu, Jan 2, 2014 at 10:36 AM, Jiergir Ogoerg wrote:
> Found, thanks. I submitted "Patch Set 3" with corrections from their
> comments, do the reviewers get notified of the new patch submission or
> do I have to poke them?
Gerrit will inform them! :) Any updates to the review page will go as
em
Found, thanks. I submitted "Patch Set 3" with corrections from their
comments, do the reviewers get notified of the new patch submission or
do I have to poke them?
The patch set 3 is here:
https://codereview.qt-project.org/#change,74537
On Thu, Jan 2, 2014 at 3:21 AM, Sze Howe Koh wrote:
> On 2
On 2 January 2014 09:05, Jiergir Ogoerg wrote:
>
> Thanks,
> On gerrit there are 5 buttons the related to reply:
> Reply...
> Reply Done
> Discard
> Cancel
> Save
>
> Which one actually send the reply so the reviewer views my reply?
After you Save all your your replies, you need to Publish Commen
Thanks,
On gerrit there are 5 buttons the related to reply:
Reply...
Reply Done
Discard
Cancel
Save
Which one actually send the reply so the reviewer views my reply?
On Wed, Jan 1, 2014 at 7:37 AM, Mandeep Sandhu
wrote:
> Hi,
>
> You should probably add a reviewer in Gerrit first. Look at the
