Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Thiago Macieira
On segunda-feira, 25 de novembro de 2013 14:49:43, Alan Alpert wrote: > My apologies, I did not notice. That raises two questions: > > 1) Should the qtbase changelog contain all changes from essential > modules, or just the ones in the qtbase repository? i.e. should I > merge the qtdeclarative cha

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Alan Alpert
On Mon, Nov 25, 2013 at 2:29 PM, Thiago Macieira wrote: > On segunda-feira, 25 de novembro de 2013 13:21:15, Alan Alpert wrote: >> The * is for some interesting things I noticed. Of the 3 usages, 2 of >> them were after Thiago's original email. Which means that if he had >> run the script on QtDec

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Thiago Macieira
On segunda-feira, 25 de novembro de 2013 13:21:15, Alan Alpert wrote: > The * is for some interesting things I noticed. Of the 3 usages, 2 of > them were after Thiago's original email. Which means that if he had > run the script on QtDeclarative as well, he'd have gotten only 1 hit. > 2 of them had

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Thiago Macieira
On segunda-feira, 25 de novembro de 2013 13:08:28, Alan Alpert wrote: > I'm happy to have it warn though. That's +0, and a comment along the > lines of "ChangeLog: Commit message references a task but does not > include a ChangeLog message. If the task is >=P2 and affected previous > versions, plea

Re: [Development] QML and JavaScript extensions

2013-11-25 Thread Kuba Ober
On Nov 15, 2013, at 4:58 PM, Richard Moore wrote: > The idea that QML deprecates ui files is frankly utter rubbish. UI > files offer many advantages over QML - decent widgets, keyboard > navigation, stability, faster coding for the common case in non-mobile > applications (to name just a few of

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Alan Alpert
On Mon, Nov 25, 2013 at 11:43 AM, Thiago Macieira wrote: > On segunda-feira, 25 de novembro de 2013 07:49:03, Thiago Macieira wrote: >> On segunda-feira, 25 de novembro de 2013 12:49:11, Marc Mutz wrote: >> > I have found that significantly more than 50% of commits that touched >> > qtbase/src/wid

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Alan Alpert
On Mon, Nov 25, 2013 at 10:47 AM, Marc Mutz wrote: > On Monday, November 25, 2013 06:26:38 PM Alan Alpert wrote: >> On Mon, Nov 25, 2013 at 7:49 AM, Thiago Macieira >> >> wrote: >> > On segunda-feira, 25 de novembro de 2013 12:49:11, Marc Mutz wrote: >> >> I have found that significantly more tha

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Thiago Macieira
On segunda-feira, 25 de novembro de 2013 20:44:13, Oswald Buddenhagen wrote: > On Mon, Nov 25, 2013 at 11:31:07AM -0800, Thiago Macieira wrote: > > On segunda-feira, 25 de novembro de 2013 19:47:24, Marc Mutz wrote: > > > I don't see a contradiction to what I was proposing: -1 if task-number > > >

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Thiago Macieira
On segunda-feira, 25 de novembro de 2013 07:49:03, Thiago Macieira wrote: > On segunda-feira, 25 de novembro de 2013 12:49:11, Marc Mutz wrote: > > I have found that significantly more than 50% of commits that touched > > qtbase/src/widgets since v5.1.0 end up in the change log. It could be a > > c

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Oswald Buddenhagen
On Mon, Nov 25, 2013 at 11:31:07AM -0800, Thiago Macieira wrote: > On segunda-feira, 25 de novembro de 2013 19:47:24, Marc Mutz wrote: > > I don't see a contradiction to what I was proposing: -1 if task-number is > > present, too, otherwise just warn. > > Warn if a task-number is present, no mess

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Thiago Macieira
On segunda-feira, 25 de novembro de 2013 19:47:24, Marc Mutz wrote: > I don't see a contradiction to what I was proposing: -1 if task-number is > present, too, otherwise just warn. Warn if a task-number is present, no message otherwise. -- Thiago Macieira - thiago.macieira (AT) intel.com Softw

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Marc Mutz
On Monday, November 25, 2013 06:26:38 PM Alan Alpert wrote: > On Mon, Nov 25, 2013 at 7:49 AM, Thiago Macieira > > wrote: > > On segunda-feira, 25 de novembro de 2013 12:49:11, Marc Mutz wrote: > >> I have found that significantly more than 50% of commits that touched > >> qtbase/src/widgets sinc

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Alan Alpert
On Mon, Nov 25, 2013 at 7:49 AM, Thiago Macieira wrote: > On segunda-feira, 25 de novembro de 2013 12:49:11, Marc Mutz wrote: >> I have found that significantly more than 50% of commits that touched >> qtbase/src/widgets since v5.1.0 end up in the change log. It could be a >> comment unless a Task

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Thiago Macieira
On segunda-feira, 25 de novembro de 2013 12:49:11, Marc Mutz wrote: > I have found that significantly more than 50% of commits that touched > qtbase/src/widgets since v5.1.0 end up in the change log. It could be a > comment unless a Task-number is also present, in which case the bot could > -1 t

Re: [Development] Qt 5.2rc1(165) iOS problems

2013-11-25 Thread Tor Arne Vestbø
Please file bug reports for each individual problem, with test-cases and/or detailed descriptions of the issue. Thanks! tor arne On 11/24/13 6:23 , Ynon Perek wrote: > Hi, > > Well, I just tried (167) as well, and I can confirm Yang’s report. > > In addition, building apps for iOS simulator stil

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Marc Mutz
On Monday, November 25, 2013 12:20:05 PM Joerg Bornemann wrote: > On 25.11.2013 10:53, Marc Mutz wrote: > >> There were exactly 31 commits with [ChangeLog]. Please start using it > >> more. > > > > Samuel Gaist (thanks) suggested in PM to add a check to the sanity bot. > > How would the bot know

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Joerg Bornemann
On 25.11.2013 10:53, Marc Mutz wrote: >> There were exactly 31 commits with [ChangeLog]. Please start using it more. > > Samuel Gaist (thanks) suggested in PM to add a check to the sanity bot. How would the bot know whether a change is worth a changelog entry? Cheers, Joerg ___

Re: [Development] ChangeLog updated for 5.2.0

2013-11-25 Thread Marc Mutz
On Tuesday, November 19, 2013 05:02:32 AM Thiago Macieira wrote: > There were exactly 31 commits with [ChangeLog]. Please start using it more. Samuel Gaist (thanks) suggested in PM to add a check to the sanity bot. Good idea? I think it is. Thanks, Marc -- Marc Mutz | Senior Software Engineer