[Development] Fwd: [Interest] Qt5.0.1 regressions

2013-03-15 Thread Thiago Macieira
Forwarding to dev, though I think the qtwebkit development mailing list might also be relevant. -- Forwarded message -- Subject: [Interest] Qt5.0.1 regressions Date: sexta-feira, 15 de março de 2013, 19.06.30 From: Sundareson, Prabindh Para: inter...@qt-project.org While movi

Re: [Development] QtMof playground repository renaming and CI activation ?

2013-03-15 Thread Sandro Andrade
On Fri, Mar 15, 2013 at 12:37 PM, Oswald Buddenhagen wrote: > On Fri, Mar 15, 2013 at 12:03:43PM -0300, Sandro Andrade wrote: >> I'm not sure whether this request is actually feasible but would we >> have too much impact if we rename qtmof playground repository to qtmodeling ? >> > i have it figur

Re: [Development] QtMof playground repository renaming and CI activation ?

2013-03-15 Thread Oswald Buddenhagen
On Fri, Mar 15, 2013 at 12:03:43PM -0300, Sandro Andrade wrote: > I'm not sure whether this request is actually feasible but would we > have too much impact if we rename qtmof playground repository to qtmodeling ? > i have it figured out now, so actually renaming it is trivial and lossless. however

Re: [Development] White space / coding style patches welcome?

2013-03-15 Thread Thiago Macieira
On sexta-feira, 15 de março de 2013 12.49.55, Axel Waggershauser wrote: > > Put the semi-colon if the semi-colon is necessary. Otherwise, don't. This > > is not optional. > It obviously did not. Here is the file: > examples/widgets/graphicsview/boxes/glextensions.cpp. So the macro is > defined in

[Development] QtMof playground repository renaming and CI activation ?

2013-03-15 Thread Sandro Andrade
Hi there, I'm not sure whether this request is actually feasible but would we have too much impact if we rename qtmof playground repository to qtmodeling ? If that would demand too much work to keep history consistent than I can stick with qtmof until it eventually graduates to qt repo. The reason

Re: [Development] White space / coding style patches welcome?

2013-03-15 Thread Alberto Mardegan
On 03/15/2013 02:51 PM, Oswald Buddenhagen wrote: > On Fri, Mar 15, 2013 at 12:49:55PM +0100, Axel Waggershauser wrote: >> On Fri, Mar 15, 2013 at 8:11 AM, Thiago Macieira >> wrote: 4) What about consistent placement of the ',' in class member initialization lists? I've seen

Re: [Development] White space / coding style patches welcome?

2013-03-15 Thread Oswald Buddenhagen
On Fri, Mar 15, 2013 at 12:49:55PM +0100, Axel Waggershauser wrote: > On Fri, Mar 15, 2013 at 8:11 AM, Thiago Macieira > wrote: > >> 4) What about consistent placement of the ',' in class member > >> initialization lists? I've seen > >> > >> : GvbWidget(parent), > >> > >> m_background()

Re: [Development] White space / coding style patches welcome?

2013-03-15 Thread Oswald Buddenhagen
On Fri, Mar 15, 2013 at 04:16:46AM +0100, Axel Waggershauser wrote: > 3) I came across a macro that had a semicolon at the end. I think this > is sub-optimal. Without special support in the IDE (like for the > Q_OBJECT macro) this leads to the following auto indented code: > > RESOLVE_GL_FUNC(

Re: [Development] White space / coding style patches welcome?

2013-03-15 Thread Oswald Buddenhagen
On Fri, Mar 15, 2013 at 12:11:00AM -0700, Thiago Macieira wrote: > On sexta-feira, 15 de março de 2013 04.16.46, Axel Waggershauser wrote: > > 2 a) I found a place with 8 spaces indent but QtCreator would indent > > it further to 12 so that the following 'Q' aligns with the 's' > > > > viewpor

Re: [Development] White space / coding style patches welcome?

2013-03-15 Thread Axel Waggershauser
On Fri, Mar 15, 2013 at 8:11 AM, Thiago Macieira wrote: >> 2 c) if vs. while lines seem obviously inconsistent >> >> if (test == true >> && 1 == 0) // 8 spaces == 4 relative to the '(' > > This is a special case because of a { > > If you write: > if (test == true > && 1

Re: [Development] Improving package distribution

2013-03-15 Thread Turunen Tuukka
Hi all, There was a problem in download.qt-project.org settings and rsync did not work. It is now fixed, and everything should work as intended. So, please re-try to mirror. If you have problems, let us know at: sysad...@qt-project.org Yours, Tuukka

Re: [Development] White space / coding style patches welcome?

2013-03-15 Thread Thiago Macieira
On sexta-feira, 15 de março de 2013 04.16.46, Axel Waggershauser wrote: > With the trailing whitespace issue pretty much fixed, the next step is > eliminating leading tabs. A few questions about that: > > 1) If in doubt, is it generally fair to assume that whatever > QtCreator's CTRL+i in the defau