[PATCH v3 0/1] Resubmission of patch previously submitted Sept 2020

patch includes the following revisions after feedback from Chris Johns: - improved documentation - addition of void* user argument to interrupt callback - addition of position value arg to interrupt callback James Fitzsimons (1): Adding QEP driver support to BeagleBoneBlack BSP bsps/arm

[PATCH v3 1/1] Adding QEP driver support to BeagleBoneBlack BSP

hen added). + */ + +/** + * Copyright (c) 2020 James Fitzsimons + * + * The license and distribution terms for this file may be + * found in the file LICENSE in this distribution or at + * http://www.rtems.org/license/LICENSE. + *. + */ + +#ifndef LIBBSP_ARM_BEAGLE_PWMSS_H +#define LIBBSP_ARM_BEAGLE_PWMSS_H + +#ifdef _

Re: [PATCH v3 0/1] Resubmission of patch previously submitted Sept 2020

faces a lot. > So I would say it is OK. I'll give it two or three more days of review > before pushing it. > > Please remind me again in a week in case I forget to push it. > > Best regards > > Christian > > On 21/02/2021 10:29, James Fitzsimons wrote: > >

[PATCH v4 1/2] bsps/beagle: Adding QEP driver support to BeagleBoneBlack BSP

hen added). + */ + +/** + * Copyright (c) 2020 James Fitzsimons + * + * The license and distribution terms for this file may be + * found in the file LICENSE in this distribution or at + * http://www.rtems.org/license/LICENSE. + *. + */ + +#ifndef LIBBSP_ARM_BEAGLE_PWMSS_H +#define LIBBSP_ARM_BEAGLE_PWMSS_H + +#ifdef _

[PATCH v4 2/2] bsps/beagle: Updating licences to latest BSD 2 clause

h @@ -6,13 +6,31 @@ * @brief Shared PWMSS module functions used by PWM, eQEP and eCAP (when added). */ -/** - * Copyright (c) 2020 James Fitzsimons +/* + * SPDX-License-Identifier: BSD-2-Clause + * + * Copyright (c) 2020, 2021 James Fitzsimons + * + * Redistribution and use in source and bi

Re: [PATCH v3 0/1] Resubmission of patch previously submitted Sept 2020

be updated to the latest template with the 2-clause BSD license? It > will > say us having to include them in the sweep when we get to that task. I see > a mix > in the files provided. > > Thanks > Chris > > On 21/2/21 8:29 pm, James Fitzsimons wrote: > > This patch add

[PATCH] Fix for Beaglebone BSP PWM bug

--- Fixed incorrect register offset values for EHRPWM1A on P9_14 and EHRPWM1B on P9_16 bsps/arm/beagle/pwm/pwm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsps/arm/beagle/pwm/pwm.c b/bsps/arm/beagle/pwm/pwm.c index 0bc5d125bf..9a346995aa 100644 --- a/bsps/arm/beagle

Re: [PATCH] Fix for Beaglebone BSP PWM bug

ebone BSP. Is this list where should I ask questions on BSP changes (coding style, API design etc), or should I do that on the users list? Many thanks, James Fitzsimons On Sun, 5 Jul 2020 at 22:41, James Fitzsimons wrote: > --- > Fixed incorrect register offset values for EHRPWM1A on P

[PATCH] Changing pwm pinmux to use better register definitions

--- bsps/arm/beagle/pwm/pwm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bsps/arm/beagle/pwm/pwm.c b/bsps/arm/beagle/pwm/pwm.c index 9a346995aa..81ace1254e 100644 --- a/bsps/arm/beagle/pwm/pwm.c +++ b/bsps/arm/beagle/pwm/pwm.c @@ -102,9 +102,9 @@ bool beagle_pwm_pinmux

Re: [PATCH] Fix for Beaglebone BSP PWM bug

did actually calculate the correct register offset - I confirmed this both by printing the register value in a debug statement and by physically measuring a PWM output signal on the pins. Cheers, James > Best regards > > Christian > > > On 05/07/2020 12:39, James Fitz

Re: [PATCH] Fix for Beaglebone BSP PWM bug

Hi Christian, Thanks very much for that, much appreciated. Cheers, James On Tue, 14 Jul 2020, 03:52 Christian Mauderer, wrote: > > > On 13/07/2020 11:55, James Fitzsimons wrote: > > Hi Christian and Chris, > > > > On Sun, 12 Jul 2020 at 06:27, Christian Mauderer &

Beaglebone QEP driver design question

(bbb_eqep_t* eqep); int32_t beagle_qep_get_position(bbb_eqep_t* eqep); Is that in keeping with the RTEMS approach? Looking at some of the other BSPs I see similar approaches for other drivers that need to track state for multiple instances of hardware. Your advice is appreciated. Cheers, James Fitzsimons

[PATCH 1/1] Adding QEP driver to Beaglebone bsp

0644 index 00..3a9dcbb70a --- /dev/null +++ b/bsps/arm/beagle/include/bsp/pwmss.h @@ -0,0 +1,54 @@ +/** + * @file + * + * @ingroup arm_beagle + * + * @brief Shared PWMSS module functions used by PWM, eQEP and eCAP (when added). + */ + +/** + * Copyright (c) 2020 James Fitzsimons + * + * T

[PATCH 0/1] Adds QEP driver to Beaglebone BSP

gratefully received. I will send a follow up email including some sample test programs with their associated output. Regards, James James Fitzsimons (1): Adding QEP driver to Beaglebone bsp bsps/arm/beagle/headers.am | 2 + bsps/arm/beagle/include/bsp/bbb-pwm.h | 11 - bsps/arm

QEP driver patch example programs and output

Hi all, Further to the patch I have just submitted I thought it would be useful for any reviewers to have the following example programs and output as a reference when reviewing the patch. Thanks in advance for your review and feedback. Regards, James Fitzsimons U-Boot SPL 2019.04-2

Re: [PATCH 1/1] Adding QEP driver to Beaglebone bsp

Hi Chris, On Sat, 22 Aug 2020 at 20:41, Chris Johns wrote: > On 21/8/20 8:01 pm, James Fitzsimons wrote: > ... > > + > > + > > +typedef void (*bbb_eqep_timer_callback)(BBB_PWMSS); > > What is BBB_PWMSS used for as an argument? > The BBB_PWMSS argument is provid

[PATCH v2 2/2] bsp: improved documentation in Beaglebone qep driver

--- bsps/arm/beagle/include/bsp/qep.h | 59 --- bsps/arm/beagle/qep/qep.c | 14 ++-- 2 files changed, 67 insertions(+), 6 deletions(-) diff --git a/bsps/arm/beagle/include/bsp/qep.h b/bsps/arm/beagle/include/bsp/qep.h index 671d9cca6c..fc086e3c80 100644 --

[PATCH v2 0/2] Adds QEP driver to Beaglebone BSP

This second version of the patch includes: - improved documentation - addition of void* user argument to interrupt callback - addition of position value arg to interrupt callback James Fitzsimons (2): Adding QEP driver to Beaglebone bsp bsp: improved documentation in Beaglebone qep driver

[PATCH v2 1/2] Adding QEP driver to Beaglebone bsp

0644 index 00..3a9dcbb70a --- /dev/null +++ b/bsps/arm/beagle/include/bsp/pwmss.h @@ -0,0 +1,54 @@ +/** + * @file + * + * @ingroup arm_beagle + * + * @brief Shared PWMSS module functions used by PWM, eQEP and eCAP (when added). + */ + +/** + * Copyright (c) 2020 James Fitzsimons + * + * T

Re: [PATCH v2 0/2] Adds QEP driver to Beaglebone BSP

Hi all, I realise people have been busy with the recent release etc so I hadn't followed this up. Are the changes I made in this new version sufficient or is there still work to do on this driver? Cheers James On Tue, 25 Aug 2020, 21:57 James Fitzsimons, wrote: > This second versio