Re: [PATCH 2/5] testsuites/libtests: Remove floats from libdl tests

2023-08-28 Thread Alex White
On Sun, Aug 27, 2023 at 11:48 PM Chris Johns wrote: > > On 28/8/2023 2:12 pm, Alex White wrote: > > On Sun, Aug 27, 2023 at 8:38 PM Chris Johns wrote: > >> The floats need to stay to make sure there are no issues with this type. I > >> see > >> the tests with floats as valid. > >> > >> Is the on

Re: [PATCH 2/5] testsuites/libtests: Remove floats from libdl tests

2023-08-28 Thread Sam Price
Just curious instead of doing #ifdef __microblaze__ could you do #ifndef __extendsfdf2 Or something similar to determine if the floating point symbols are known? This would make it more portable. On Mon, Aug 28, 2023 at 10:11 AM Alex White wrote: > > On Sun, Aug 27, 2023 at 11:48 PM Chris Johns

Re: [PATCH 2/5] testsuites/libtests: Remove floats from libdl tests

2023-08-28 Thread Sam Price
Nevermind that would be done at the linker and not at compile time. On Mon, Aug 28, 2023 at 11:04 AM Sam Price wrote: > > Just curious instead of doing #ifdef __microblaze__ > could you do > #ifndef __extendsfdf2 > > Or something similar to determine if the floating point symbols are known? > > T

Re: [PATCH 2/5] testsuites/libtests: Remove floats from libdl tests

2023-08-28 Thread Alex White
On Mon, Aug 28, 2023 at 10:31 AM Sam Price wrote: > > Nevermind that would be done at the linker and not at compile time. I searched for some way to check if soft float routines are being used, but I couldn't find anything. Maybe we just remove the conditional altogether? I don't think it's a pr

Re: [PATCH 2/5] testsuites/libtests: Remove floats from libdl tests

2023-08-28 Thread Kinsey Moore
(cross posted from discord) I did some digging and it looks like the right macros/defines to gate on are CPU_SOFTWARE_FP and CPU_HARDWARE_FP. The FP code in the loadable module should only be present if at least one of those is available and the definition in the host binary should only be present

[RSB PATCH] rtems/tools: Shell execute fixes

2023-08-28 Thread chrisj
From: Chris Johns Updates #4951 --- rtems/config/tools/rtems-tools-6.cfg | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rtems/config/tools/rtems-tools-6.cfg b/rtems/config/tools/rtems-tools-6.cfg index 6eed755..b360f7e 100644 --- a/rtems/config/tools/rtems-tools-6.cfg +

Re: [RSB PATCH] rtems/tools: Shell execute fixes

2023-08-28 Thread Joel Sherrill
Looks ok to push On Mon, Aug 28, 2023, 9:14 PM wrote: > From: Chris Johns > > Updates #4951 > --- > rtems/config/tools/rtems-tools-6.cfg | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/rtems/config/tools/rtems-tools-6.cfg > b/rtems/config/tools/rtems-tools-6.cfg >

[PATCH 0/4] New UART drivers for PL011 and Mini UART

2023-08-28 Thread Utkarsh Verma
This patch series adds two drivers, PL011 and Mini UART. Both support interrupts and implement the termios API. Why add a new driver for the PL011 when we already have one? The existing driver is a very basic one and uses memory-mapped structs to access the registers. This proved to be problemati

[PATCH 1/4] bsps/shared: Add new PL011 driver with IRQ support

2023-08-28 Thread Utkarsh Verma
This commit adds a new driver for the PL011. It uses the termios API with support for setting attributes and interrupts. Interrupts can be enabled using the BSP_CONSOLE_USE_INTERRUPTS macro. --- bsps/include/dev/serial/arm-pl011-regs.h | 143 -- .../dev/serial/{arm-pl011.h => pl011.h}

[PATCH 2/4] bsps/shared: Add new Mini UART driver

2023-08-28 Thread Utkarsh Verma
This commit adds a new driver for the Mini UART peripheral present on Raspberry Pi devices. It implements the termios API with support for setting attributes. It supports interrupts through the BSP_CONSOLE_USE_INTERRUPTS macro. --- bsps/include/dev/serial/mini-uart.h | 54 + bsps/shared/dev/s

[PATCH 3/4] bsps: Update BSPs to use the new PL011 driver

2023-08-28 Thread Utkarsh Verma
This commit updates the existing BSPs to use the new PL011 driver. --- bsps/aarch64/a53/console/console.c| 14 +- bsps/aarch64/a72/console/console.c| 14 +- bsps/aarch64/raspberrypi/console/console.c| 14 +- bsps/arm/raspberrypi/console/console-c

[PATCH 4/4] spec: Add Mini UART and PL011 drivers to build spec

2023-08-28 Thread Utkarsh Verma
This commit updates the build spec to include the new UART drivers for PL011 and Mini UART. --- spec/build/bsps/aarch64/raspberrypi/bspraspberrypi4.yml | 1 - spec/build/bsps/obj.yml | 7 --- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/spec/bu