[PATCH 1/5] bsp/lpc32xx: Fix warning

The type is a pointer. --- bsps/arm/lpc32xx/include/bsp/lpc-ethernet-config.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsps/arm/lpc32xx/include/bsp/lpc-ethernet-config.h b/bsps/arm/lpc32xx/include/bsp/lpc-ethernet-config.h index 14282fd578..df74b085b1 100644 --- a/bsps/

[PATCH 0/5] Prepare bsp/lpc32xx for RTMES 6 release

Sebastian Huber (5): bsp/lpc32xx: Fix warning bsp/lpc32xx: Restore lpc32xx_set_translation_table_entries() bsp/lpc32xx: Remove hard to maintain comments bsp/lpc32xx: Increase SDRAM size to 64MiB bsp/lpc32xx: Fix lpc32xx_magic_zero_size .../lpc32xx/include/bsp/lpc-ethernet-config.h | 2

[PATCH 2/5] bsp/lpc32xx: Restore lpc32xx_set_translation_table_entries()

This implementation disables the MMU during the modification of the translation table. This behaviour is required by boot loaders for these boards. --- bsps/arm/lpc32xx/include/bsp/mmu.h | 7 +-- bsps/arm/lpc32xx/start/mmu.c| 81 + spec/build/bsps/arm/lpc32xx

[PATCH 3/5] bsp/lpc32xx: Remove hard to maintain comments

These comments duplicate the memory and region definitions of the linker command file. --- bsps/arm/lpc32xx/start/linkcmds.lpc32xx_mzx | 20 -- .../start/linkcmds.lpc32xx_mzx_stage_1| 20 -- .../start/linkcmds.lpc32xx_mzx_stage_2| 20 --

[PATCH 4/5] bsp/lpc32xx: Increase SDRAM size to 64MiB

Increase stage 2 bootloader size to 16MiB. --- bsps/arm/lpc32xx/start/linkcmds.lpc32xx_mzx | 2 +- bsps/arm/lpc32xx/start/linkcmds.lpc32xx_mzx_stage_2 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bsps/arm/lpc32xx/start/linkcmds.lpc32xx_mzx b/bsps/arm/lpc32xx/star

[PATCH 5/5] bsp/lpc32xx: Fix lpc32xx_magic_zero_size

--- bsps/arm/lpc32xx/start/linkcmds.lpc32xx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsps/arm/lpc32xx/start/linkcmds.lpc32xx b/bsps/arm/lpc32xx/start/linkcmds.lpc32xx index 200e7f3e04..f38f7903b2 100644 --- a/bsps/arm/lpc32xx/start/linkcmds.lpc32xx +++ b/bsps/arm/lpc32x

Re: [PATCH 1/2] bsps/aarch64/raspberrypi: Refactor code base

I would say that the content here is easily worth several patches. You've got header rearrangements and other formatting changes mixed in with macro renamings, build system changes, and other things. One comment below on the .gitignore. You've also got inconsistencies in usage of (C) vs (c). On Su

Re: [PATCH 1/2] bsps/aarch64/raspberrypi: Refactor code base

Hi Kinsey, Thanks for the suggestions. I'll break it up into several commits as you suggested. Shall I break it down as follows? - Build spec changes - Formatting changes - Macro renamings Regards, Utkarsh On Mon, Aug 7, 2023 at 8:49 PM Kinsey Moore wrote: > I would say that the content here

Re: [PATCH 1/2] bsps/aarch64/raspberrypi: Refactor code base

That sounds fine to me. Thanks, Kinsey On Mon, Aug 7, 2023 at 10:53 AM Utkarsh Verma wrote: > Hi Kinsey, > > Thanks for the suggestions. I'll break it up into several commits as > you suggested. Shall I break it down as follows? > > - Build spec changes > - Formatting changes > - Macro renaming

[PATCH 0/3] Refactor the aarch64/raspberryp4b BSP

This patch series refactors the BSP and build spec for Raspberry Pi 4B with the following goals in mind: - IWYU(include what you use) includes - Modularity in BSP and the build spec - Strict MMU mapping This is my first code contribution to RTEMS, therefore suggestions of any kind would be highly

[PATCH 1/3] gitignore: Ignore clangd and clang-format files

--- .gitignore | 4 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 8b28b186e1..d0144f6737 100644 --- a/.gitignore +++ b/.gitignore @@ -12,3 +12,7 @@ Makefile.in /testsuites/build/build /testsuites/build/wscript .waf* +.clangd +.clang-format +compile_commands.js

[PATCH 2/3] bsps/aarch64/raspberrypi: Refactor the BSP

This commit restructures the BSP to be more modular and introduces IWYU(include what you use) includes alongwith some formatting changes. build: Update spec for aarch64/raspberrypi --- bsps/aarch64/raspberrypi/console/console.c| 39 +- bsps/aarch64/raspberrypi/include/bsp.h| 37 +-

[PATCH 3/3] build: Modularize the aarch64/raspberrypi spec

--- spec/build/bsps/aarch64/raspberrypi/abi.yml | 39 ++ spec/build/bsps/aarch64/raspberrypi/bsp4b.yml | 23 ++ .../aarch64/raspberrypi/bspraspberrypi4.yml | 75 --- spec/build/bsps/aarch64/raspberrypi/grp.yml | 25 +++ spec/build/bsps/aarch64/raspberrypi/grp4

Re: [PATCH 0/3] Refactor the aarch64/raspberryp4b BSP

Changes are also on my GitHub fork: https://github.com/UtkarshVerma/rtems/tree/refactor. Regards, Utkarsh On Tue, Aug 8, 2023 at 8:35 AM Utkarsh Verma wrote: > This patch series refactors the BSP and build spec for Raspberry Pi 4B > with the following goals in mind: > > - IWYU(include what you

Re: [PATCH] build: Add PROGRAM_PREFIX option

On 7/8/2023 4:06 pm, Sebastian Huber wrote: > On 07.08.23 00:25, Chris Johns wrote: >> On 4/8/2023 4:39 pm, Sebastian Huber wrote: >>> On 04.08.23 08:22, Chris Johns wrote: On 4/8/2023 3:16 pm, Sebastian Huber wrote: > On 04.08.23 00:27, Chris Johns wrote: >> On 2/8/2023 6:49 pm, Chr

Re: [PATCH 1/3] gitignore: Ignore clangd and clang-format files

On 8/8/2023 1:05 pm, Utkarsh Verma wrote: > --- > .gitignore | 4 > 1 file changed, 4 insertions(+) > > diff --git a/.gitignore b/.gitignore > index 8b28b186e1..d0144f6737 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -12,3 +12,7 @@ Makefile.in > /testsuites/build/build > /testsuites/b

Re: [PATCH 1/3] gitignore: Ignore clangd and clang-format files

On 8/8/2023 4:07 pm, Chris Johns wrote: > On 8/8/2023 1:05 pm, Utkarsh Verma wrote: >> --- >> .gitignore | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/.gitignore b/.gitignore >> index 8b28b186e1..d0144f6737 100644 >> --- a/.gitignore >> +++ b/.gitignore >> @@ -12,3 +12,7 @@ Makef