[PATCH] eng: Clarify use of extern "C"

Close #4806. --- eng/coding-file-hdr.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/eng/coding-file-hdr.rst b/eng/coding-file-hdr.rst index 3167670..e6f5b30 100644 --- a/eng/coding-file-hdr.rst +++ b/eng/coding-file-hdr.rst @@ -98,6 +98,9 @@ Use the following guidelines and template fo

Re: [PATCH v2 1/1] RSB: Mitigate too short error reports

Thanks Frank and Chris. I pushed the patch. Best regards Christian On 2023-01-20 22:53, Chris Johns wrote: OK to push. Thanks Chris On 21/1/2023 2:06 am, Frank Kuehndel wrote: From: Frank Kühndel Close #4642 --- source-builder/sb/ereport.py | 4 +++- 1 file changed, 3 insertions(+), 1

formal: Fixes Licenses

Patches to fix licenses for formal material are attached. The main issue was missing/wrong SPDX identifiers Best regards, Andrew Butterfield -cover-letter.patch Description: -cover-letter.patch 0001-formal-fix-licenses.patch Description: 0001-formal-fix-licenses.patch ___

[PATCH] score: Clarify code block

Do not use a chained assignment for code clarity. Update #4818. --- cpukit/score/src/threadcreateidle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/score/src/threadcreateidle.c b/cpukit/score/src/threadcreateidle.c index cb15d5cc3c..4f16a57099 100644 --- a/cpukit/s

Prioritizing and documenting libbsd development goals (was: libbsd updates)

Hello, like suggested earlier in the original discussion I would suggest to prioritize our development goals for libbsd and later evaluate the two problems discussed in the thread based on this. Let's first agree on development goals (that also can be added to the libbsd documentation). From

[PATCH] tm27: Avoid function pointer casts

Add TM27_USE_VECTOR_HANDLER to select the interrupt handler type used by the implementation. Close #4820. --- bsps/arm/lpc32xx/include/tm27.h | 4 +-- bsps/bfin/TLL6527M/include/tm27.h| 2 ++ bsps/bfin/eZKit533/include/tm27.h| 2 ++ bsps/include/dev/irq/ar

Re: [PATCH] eng: Clarify use of extern "C"

Following that comment precisely means we should remove them if there are no functions. That ignores data items and the simple maintenance issue of not having an extern C, adding something in the future and forgetting to add extern C. IMO it's just part of the header file template we should always

[PATCH] Add clock driver implementation group

Use standard wording in Clock Driver related files. --- bsps/arm/raspberrypi/clock/clockdrv.c | 7 +++ bsps/or1k/generic_or1k/clock/clockdrv.c | 7 +++ bsps/riscv/riscv/clock/clockdrv.c | 5 +++-- bsps/shared/dev/clock/clockimpl.h | 23 +-- cpukit/inclu

[PATCH] cpuuse: Use standard wording and group name

Use standard wording in CPU usage reporting files. --- cpukit/include/rtems/cpuuse.h | 16 cpukit/libmisc/cpuuse/cpuusagedata.c | 7 +++ cpukit/libmisc/cpuuse/cpuusagereport.c | 5 +++-- cpukit/libmisc/cpuuse/cpuusagereset.c | 5 +++-- cpukit/libmisc/cpuuse/cpuu

Re: [PATCH] eng: Clarify use of extern "C"

On 23.01.23 15:01, Joel Sherrill wrote: Following that comment precisely means we should remove them if there are no functions. That ignores data items and the simple maintenance issue of not having an extern C, adding something in the future and forgetting to add extern C. IMO it's just part

Re: [PATCH] eng: Clarify use of extern "C"

On Mon, Jan 23, 2023 at 8:51 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 23.01.23 15:01, Joel Sherrill wrote: > > Following that comment precisely means we should remove them if there > > are no functions. That ignores data items and the simple maintenance > > issue of not

[PATCH] intr: Add Interrupt Manager implementation group

The shared BSP interrupt controller support code actually implements parts of the Interrupt Manager. Update #3706. --- bsps/arm/altera-cyclone-v/include/bsp/irq.h | 2 +- bsps/arm/beagle/irq/irq.c | 2 +- bsps/arm/lpc176x/include/bsp/irq.h | 4 +-- bsps/arm/lpc176x/i

Re: [PATCH] tm27: Avoid function pointer casts

looks fine On Mon, Jan 23, 2023 at 6:58 AM Sebastian Huber wrote: > > Add TM27_USE_VECTOR_HANDLER to select the interrupt handler type used by > the implementation. > > Close #4820. > --- > bsps/arm/lpc32xx/include/tm27.h | 4 +-- > bsps/bfin/TLL6527M/include/tm27.h|

Re: [PATCH] score: Clarify code block

ok. also ok would have been merging the lines. On Mon, Jan 23, 2023 at 6:18 AM Sebastian Huber wrote: > > Do not use a chained assignment for code clarity. > > Update #4818. > --- > cpukit/score/src/threadcreateidle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cpuki

Re: [PATCH] cpuuse: Use standard wording and group name

These doxygen patches look fine. On Mon, Jan 23, 2023 at 7:35 AM Sebastian Huber wrote: > > Use standard wording in CPU usage reporting files. > --- > cpukit/include/rtems/cpuuse.h | 16 > cpukit/libmisc/cpuuse/cpuusagedata.c | 7 +++ > cpukit/libmisc/cpuuse/cpuu

Re: [docs] eng: Use a recommendation for requirement texts

On Sun, Jan 22, 2023 at 11:58 PM Sebastian Huber wrote: > > On 20.01.23 23:55, Gedare Bloom wrote: > > I understand this change. I wonder if there are some terms that you > > definitely want to avoid though? > > > > Do you have tooling to warn on the use of these terms in requirements? > > If not,

Re: [PATCH] score: Fix minor Rhe->The typo in doxygen

Thanks. Sebastian can you pick this up with your doxygen changes? On Sun, Jan 22, 2023 at 4:02 PM Martin Erik Werner wrote: > > --- > Intentionally not part of commit message: > Another minor typo in documentation, discovered by chance while browsing > the doxygen site. > > cpukit/include/rtems/

Re: [PATCH] score: Fix minor Rhe->The typo in doxygen

On 23.01.23 16:28, Gedare Bloom wrote: Thanks. Sebastian can you pick this up with your doxygen changes? I think I checked it in already? -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax

Re: [PATCH] score: Fix minor Rhe->The typo in doxygen

you sure did, my apologies. VC is in a separate folder for me. On Mon, Jan 23, 2023 at 8:29 AM Sebastian Huber wrote: > > On 23.01.23 16:28, Gedare Bloom wrote: > > Thanks. Sebastian can you pick this up with your doxygen changes? > > I think I checked it in already? > > -- > embedded brains GmbH

Re: Prioritizing and documenting libbsd development goals (was: libbsd updates)

Hello, since we are maintaining an RTOS: IMHO Real time capabilities would need a higher level, even above code/RAM sizes. Meaining that the libbsd functionality should not have a (significant) negative impact on RTEMS tasks NOT using libbsd. wkr, Thomas. Am 23.01.23 um 14:33 schrieb Chri

Re: Prioritizing and documenting libbsd development goals (was: libbsd updates)

On 23.01.23 16:39, Thomas DOERFLER wrote: since we are maintaining an RTOS: IMHO Real time capabilities would need a higher level, even above code/RAM sizes. Meaining that the libbsd functionality should not have a (significant) negative impact on RTEMS tasks NOT using libbsd. There is act

Re: [PATCH] score: Clarify code block

On Mon, Jan 23, 2023, 9:18 AM Gedare Bloom wrote: > ok. also ok would have been merging the lines. > I like not chaining the assignments. I think simple lines are easier for review. I suspect some coding style wouldn't like it anyway. > > On Mon, Jan 23, 2023 at 6:18 AM Sebastian Huber > wrote

[PATCH 0/3] bsps/xilinx-zynqmp: Add JFFS2 GQSPI NOR driver

This patchset adds a JFFS2 driver for NOR flash using the Xilinx GQSPI controller. It includes an imported XQspipsu driver from Xilinx, a series of helper functions to interface with NOR flash, and a JFFS2 driver that uses the helper functions. Alex White (3): bsps: Import Xilinx GQSPI driver

[PATCH 2/3] bsps: Add Xilinx GQSPI flash helper

This adds helper functions for working with NOR flash connected to the Xilinx GQSPI controller. The helper functions are based on Xilinx's QSPIPSU flash interrupt example. --- bsps/include/dev/spi/xqspipsu-flash-helper.h | 81 + bsps/shared/dev/spi/xqspipsu-flash-helper.c | 2005 +++

[PATCH 3/3] bsps/xilinx-zynqmp: Add JFFS2 GQSPI NOR driver

--- bsps/aarch64/xilinx-zynqmp/include/bsp/irq.h | 1 + .../include/bsp/jffs2_xqspipsu.h | 62 ++ bsps/aarch64/xilinx-zynqmp/jffs2_xqspipsu.c | 186 ++ spec/build/bsps/aarch64/xilinx-zynqmp/grp.yml | 2 + .../aarch64/xilinx-zynqmp/objjffs2qspinor.yml | 22

Re: [PATCH] Add clock driver implementation group

Aren't there more files that belong to this group? On Mon, Jan 23, 2023 at 8:27 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Use standard wording in Clock Driver related files. > --- > bsps/arm/raspberrypi/clock/clockdrv.c | 7 +++ > bsps/or1k/generic_or1k/clock/clock

Re: [PATCH] intr: Add Interrupt Manager implementation group

Isn't there anything in the aarch64 or microblaze that should be in this list? Seems like there should be more files. On Mon, Jan 23, 2023 at 9:13 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > The shared BSP interrupt controller support code actually implements > parts of the

Re: [PATCH] intr: Add Interrupt Manager implementation group

On 24.01.23 01:10, Joel Sherrill wrote: Isn't there anything in the aarch64 or microblaze that should be in this list? Seems like there should be more files. Yes, there is a lot more to do in the BSP area if it comes to Doxygen grouping. I think the BSP-specific parts should be a subgroup.