Re: GSoC - Code Formatting and Style Checking for RTEMS score

Hello Ida, On 10/07/2021 01:08, Ida Delphine wrote: I added the functionality for my script to ignore certain directories like /bsps/, /testsuites/, '/cpukit/zlib', '/cpukit/mghttpd'. https://github.com/Idadelveloper/rtems/blob/master/hooks/pre-commit

Re: GSoC - Code Formatting and Style Checking for RTEMS score

Hello Ida, It would be great if you make a README.md at https://github.com/Idadelveloper/rtems/tree/master/hooks to guide potential users how to use your pre-commit hook and provide some examples. I tried to find the information from your blog, but the update stopped at the second week (https://i

[PATCH 04/41] rtems: Add rtems_interrupt_cause_on()

Document the currently not implemented rtems_interrupt_cause() and rtems_interrupt_clear(). Update #3269. --- cpukit/include/rtems/rtems/intr.h | 162 +++--- 1 file changed, 125 insertions(+), 37 deletions(-) diff --git a/cpukit/include/rtems/rtems/intr.h b/cpukit/includ

[PATCH 06/41] rtems: Add rtems_interrupt_get_attributes()

Add a directive to query the attributes of an interrupt vector. This be used for generic tests and system diagnostics. Update #3269. --- cpukit/include/rtems/irq-extension.h | 198 +++ 1 file changed, 198 insertions(+) diff --git a/cpukit/include/rtems/irq-extension.h

[PATCH 01/41] bsps/irq: Move get/set affinity to separate file

Update #3269. --- bsps/shared/irq-default-sources.am | 1 + bsps/shared/irq-sources.am | 1 + bsps/shared/irq/irq-affinity.c | 90 bsps/shared/irq/irq-generic.c| 52 --- c/src/lib/libbsp/m68k/genmcf548x/Makefi

[PATCH 00/41] Document, enhance, and test Interrupt Manager Extension

This patch set enhances the Interrupt Manager Extension so that it can be tested with generic tests. The following new directives are introduced for this purpose: * rtems_interrupt_get_attributes() * rtems_interrupt_vector_is_enabled() * rtems_interrupt_vector_enable() * rtems_interrupt_vector

[PATCH 02/41] bsps/irq: Canonicalize get/set affinity errors

Bring the error conditions and status in line with rtems_task_get_affinity() and rtems_task_set_affinity(). Update #3269. --- bsps/shared/irq/irq-affinity.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/bsps/shared/irq/irq-affinity.c b/bsps/shared/irq/irq-affin

[PATCH 08/41] rtems: Add rtems_interrupt_vector_is_enabled()

Update #3269. --- cpukit/include/rtems/irq-extension.h | 50 1 file changed, 50 insertions(+) diff --git a/cpukit/include/rtems/irq-extension.h b/cpukit/include/rtems/irq-extension.h index 2df18b2b0d..4a8f0b7879 100644 --- a/cpukit/include/rtems/irq-extension.h +++ b

[PATCH 03/41] bsps/irq: Move handler iterate to separate file

Update #3269. --- bsps/include/bsp/irq-generic.h | 57 bsps/shared/irq-default-sources.am | 1 + bsps/shared/irq-sources.am | 1 + bsps/shared/irq/irq-generic.c| 86 +- bsps/shared/irq/irq-handler-iterate.c

[PATCH 07/41] rtems: Add rtems_interrupt_vector_enable()

Add rtems_interrupt_vector_disable(). Update #3269. --- bsps/shared/irq-default-sources.am | 1 + bsps/shared/irq-sources.am | 1 + bsps/shared/irq/irq-enable-disable.c | 59 + c/src/lib/libbsp/m68k/genmcf548x/Makefile.am | 1 + c/src/lib/libbsp/

[PATCH 17/41] bsps/irq: bsp_interrupt_get_affinity()

Return a status code for bsp_interrupt_get_affinity(). Update #3269. --- bsps/include/dev/irq/arm-gic-irq.h | 2 +- bsps/powerpc/qoriq/include/bsp/irq.h | 2 +- bsps/powerpc/qoriq/irq/irq.c | 5 +++-- bsps/powerpc/t32mppc/include/bsp/irq.h | 3 ++- bsps/riscv/griscv/include/bsp/ir

[PATCH 15/41] bsps/irq: bsp_interrupt_vector_enable()

Return a status code for bsp_interrupt_vector_enable(). Update #3269. --- bsps/arm/beagle/irq/irq.c | 3 ++- bsps/arm/csb336/irq/irq.c | 4 +++- bsps/arm/csb337/irq/irq.c | 3 ++- bsps/arm/edb7312/irq/irq.c| 4 +++- bsps/arm/gums

[PATCH 05/41] rtems: Generate

Use which just provides the data types and avoid a dependency on which contains the full chain implementation. Change license to BSD-2-Clause according to file histories and documentation re-licensing agreement. Update #3269. Update #3899. Update #3993. --- cpukit/include/rtems/irq-extension.h

[PATCH 27/41] validation: Add CallWithinISR()

Update #3269. --- .../testsuites/validation/libvalidation.yml | 1 + testsuites/validation/tx-call-within-isr.c| 134 ++ testsuites/validation/tx-support.h| 14 ++ 3 files changed, 149 insertions(+) create mode 100644 testsuites/validation/tx-call-within-isr.c

[PATCH 11/41] bsps/irq: Add rtems_interrupt_vector_is_enabled()

Add a default implementation which just returns RTEMS_UNSATISFIED for valid parameters. Update #3269. --- bsps/arm/beagle/irq/irq.c | 11 +++ bsps/arm/csb336/irq/irq.c | 11 +++ bsps/arm/csb337/irq/irq.c | 11 +++ bsps/arm/ed

[PATCH 12/41] bsps/irq: Add rtems_interrupt_cause()

Add rtems_interrupt_cause_on() and rtems_interrupt_clear(). Add a default implementation which just returns RTEMS_UNSATISFIED for valid parameters. Update #3269. --- bsps/arm/beagle/irq/irq.c| 12 +++ bsps/arm/csb336/irq/irq.c| 12 +++ bsps/arm/csb337/irq/

[PATCH 10/41] rtems: Add RTEMS_FATAL_SOURCE_SPURIOUS_INTERRUPT

Add RTEMS_FATAL_SOURCE_SPURIOUS_INTERRUPT as the fatal source for spurious interrupts. Use the interrupt vector number of the spurious interrupt for the fatal code. Update #3269. --- bsps/shared/irq/irq-default-handler.c | 12 +--- cpukit/include/rtems/score/interr.h | 7 +

[PATCH 25/41] bsps/irq: Add rtems_interrupt_entry_install()

Add rtems_interrupt_entry_remove(). Split up irq-generic.c into several files. In particular, place all functions which use dynamic memory into their own file. Add optional macros to let the BSP customize the vector installation after installing the first entry and the vector removal before remov

[PATCH 31/41] validation: rtems_interrupt_vector_is_enabled()

Update #3269. --- .../testsuites/validation/validation-0.yml| 1 + .../validation/tc-intr-vector-is-enabled.c| 627 ++ 2 files changed, 628 insertions(+) create mode 100644 testsuites/validation/tc-intr-vector-is-enabled.c diff --git a/spec/build/testsuites/validation/v

[PATCH 20/41] sparc/irq: Implement new interrupt directives

Update #3269. --- bsps/sparc/leon3/start/eirq.c | 86 +++--- bsps/sparc/shared/irq/irq-shared.c | 17 -- 2 files changed, 91 insertions(+), 12 deletions(-) diff --git a/bsps/sparc/leon3/start/eirq.c b/bsps/sparc/leon3/start/eirq.c index d6373bf00a..4f5f910106 1006

[PATCH 19/41] bsps/irq: Implement new directives for GICv2/3

Update #3269. --- bsps/include/dev/irq/arm-gic-irq.h | 3 + bsps/shared/dev/irq/arm-gicv2.c| 93 +--- bsps/shared/dev/irq/arm-gicv3.c| 131 - 3 files changed, 194 insertions(+), 33 deletions(-) diff --git a/bsps/include/dev/irq/arm-gic-irq.h

[PATCH 34/41] validation: Test rtems_interrupt_entry_install()

Update #3269. --- .../testsuites/validation/validation-0.yml|1 + testsuites/validation/tc-intr-entry-install.c | 1222 + 2 files changed, 1223 insertions(+) create mode 100644 testsuites/validation/tc-intr-entry-install.c diff --git a/spec/build/testsuites/validation/val

[PATCH 36/41] validation: Test rtems_interrupt_cause()

Update #3269. --- .../testsuites/validation/validation-0.yml| 1 + testsuites/validation/tc-intr-cause.c | 577 ++ 2 files changed, 578 insertions(+) create mode 100644 testsuites/validation/tc-intr-cause.c diff --git a/spec/build/testsuites/validation/validation-0.

[PATCH 38/41] validation: Test rtems_interrupt_is_pending()

Update #3269. --- .../testsuites/validation/validation-0.yml| 1 + testsuites/validation/tc-intr-is-pending.c| 630 ++ 2 files changed, 631 insertions(+) create mode 100644 testsuites/validation/tc-intr-is-pending.c diff --git a/spec/build/testsuites/validation/validati

[PATCH 13/41] bsps/irq: Add rtems_interrupt_get_attributes()

Add a default implementation which clears the attributes to zero and just returns RTEMS_SUCCESSFUL for valid parameters. Update #3269. --- bsps/arm/beagle/irq/irq.c | 8 ++ bsps/arm/csb336/irq/irq.c | 8 ++ bsps/arm/csb337/irq/irq.c | 8 +

[PATCH 18/41] bsps/irq: bsp_interrupt_set_affinity()

Return a status code for bsp_interrupt_set_affinity(). Update #3269. --- bsps/include/dev/irq/arm-gic-irq.h | 2 +- bsps/powerpc/qoriq/include/bsp/irq.h | 2 +- bsps/powerpc/qoriq/irq/irq.c | 5 +++-- bsps/powerpc/t32mppc/include/bsp/irq.h | 3 ++- bsps/riscv/griscv/include/bsp/ir

[PATCH 22/41] bsps/irq: Use rtems_interrupt_entry

Update #3269. --- bsps/include/bsp/irq-generic.h| 15 +++ bsps/shared/irq/irq-generic.c | 24 bsps/shared/irq/irq-handler-iterate.c | 2 +- 3 files changed, 16 insertions(+), 25 deletions(-) diff --git a/bsps/include/bsp/irq-generic.h b/bsps/i

[PATCH 21/41] rtems: Add rtems_interrupt_entry_install()

Add RTEMS_INTERRUPT_ENTRY_INITIALIZER(), rtems_interrupt_entry_initialize(), and rtems_interrupt_entry_remove(). This allows to install interrupt handlers using user-provides storage as an alternative to rtems_interrupt_handler_install() which has to allocate memory. Update #3269. --- cpukit/inc

[PATCH 16/41] bsps/irq: bsp_interrupt_vector_disable()

Return a status code for bsp_interrupt_vector_disable(). Update #3269. --- bsps/arm/beagle/irq/irq.c | 3 ++- bsps/arm/csb336/irq/irq.c | 4 +++- bsps/arm/csb337/irq/irq.c | 3 ++- bsps/arm/edb7312/irq/irq.c| 4 +++- bsps/arm/gum

[PATCH 23/41] bsps/irq: Add bsp_interrupt_check_and_lock()

Return RTEMS_INCORRECT_STATE instead of RTEMS_INCORRECT_STATE in case the interrupt support is not initialized. This is similar to rtems_timer_server_fire_after() for example. Update #3269. --- bsps/include/bsp/irq-generic.h| 25 +++ bsps/shared/irq/irq-generic.c | 60 +++

[PATCH 29/41] validation: GetValidInterruptVectorNumber()

Update #3269. --- testsuites/validation/tx-interrupt.c | 26 ++ testsuites/validation/tx-support.h | 5 + 2 files changed, 31 insertions(+) diff --git a/testsuites/validation/tx-interrupt.c b/testsuites/validation/tx-interrupt.c index d056af5abc..0ff5ec017f 100644

[PATCH 24/41] bsps/irq: Move bsp_interrupt_handler_is_empty()

This function is only used by one BSP. Update #3269. --- bsps/i386/shared/irq/irq.c | 11 +++ bsps/include/bsp/irq-generic.h | 11 --- bsps/shared/irq/irq-generic.c | 19 --- 3 files changed, 11 insertions(+), 30 deletions(-) diff --git a/bsps/i386/shared/irq

[PATCH 30/41] validation: Test rtems_interrupt_get_attributes()

Update #3269. --- .../testsuites/validation/validation-0.yml| 1 + .../validation/tc-intr-get-attributes.c | 445 ++ 2 files changed, 446 insertions(+) create mode 100644 testsuites/validation/tc-intr-get-attributes.c diff --git a/spec/build/testsuites/validation/vali

[PATCH 28/41] validation: HasInterruptVectorEntriesInstalled()

Update #3269. --- .../testsuites/validation/libvalidation.yml | 1 + testsuites/validation/tx-interrupt.c | 79 +++ testsuites/validation/tx-support.h| 2 + 3 files changed, 82 insertions(+) create mode 100644 testsuites/validation/tx-interrupt.c diff --g

[PATCH 14/41] bsps/irq: Add rtems_interrupt_is_pending()

Add a default implementation which just returns RTEMS_UNSATISFIED. Update #3269. --- bsps/arm/beagle/irq/irq.c | 11 ++ bsps/arm/csb336/irq/irq.c | 11 ++ bsps/arm/csb337/irq/irq.c | 11 ++ bsps/arm/edb7312/irq/irq.c

[PATCH 33/41] validation: Test rtems_interrupt_vector_disable()

Update #3269. --- .../testsuites/validation/validation-0.yml| 1 + .../validation/tc-intr-vector-disable.c | 608 ++ 2 files changed, 609 insertions(+) create mode 100644 testsuites/validation/tc-intr-vector-disable.c diff --git a/spec/build/testsuites/validation/vali

[PATCH 09/41] rtems: Add rtems_interrupt_is_pending()

Update #3269. --- cpukit/include/rtems/irq-extension.h | 54 1 file changed, 54 insertions(+) diff --git a/cpukit/include/rtems/irq-extension.h b/cpukit/include/rtems/irq-extension.h index 4a8f0b7879..c96dfd7d5c 100644 --- a/cpukit/include/rtems/irq-extension.h +++ b

[PATCH 40/41] validation: Test rtems_interrupt_get_affinity()

Update #3269. --- .../testsuites/validation/validation-0.yml| 1 + testsuites/validation/tc-intr-get-affinity.c | 639 ++ 2 files changed, 640 insertions(+) create mode 100644 testsuites/validation/tc-intr-get-affinity.c diff --git a/spec/build/testsuites/validation/valida

[PATCH 41/41] validation: Test rtems_interrupt_set_affinity()

Update #3269. --- .../testsuites/validation/validation-0.yml| 1 + testsuites/validation/tc-intr-set-affinity.c | 670 ++ 2 files changed, 671 insertions(+) create mode 100644 testsuites/validation/tc-intr-set-affinity.c diff --git a/spec/build/testsuites/validation/valida

[PATCH 35/41] validation: Test rtems_interrupt_entry_remove()

Update #3269. --- .../testsuites/validation/validation-0.yml|1 + testsuites/validation/tc-intr-entry-remove.c | 1302 + 2 files changed, 1303 insertions(+) create mode 100644 testsuites/validation/tc-intr-entry-remove.c diff --git a/spec/build/testsuites/validation/vali

[PATCH 37/41] validation: Test rtems_interrupt_clear()

Update #3269. --- .../testsuites/validation/validation-0.yml| 1 + testsuites/validation/tc-intr-clear.c | 586 ++ 2 files changed, 587 insertions(+) create mode 100644 testsuites/validation/tc-intr-clear.c diff --git a/spec/build/testsuites/validation/validation-0.

[PATCH 39/41] validation: Test rtems_interrupt_cause_on()

Update #3269. --- .../testsuites/validation/validation-0.yml| 1 + testsuites/validation/tc-intr-cause-on.c | 710 ++ testsuites/validation/ts-default.h| 12 +- testsuites/validation/ts-validation-0.c | 2 +- 4 files changed, 723 insertions(+), 2 del

[PATCH 26/41] bsp/raspberrypi: Add interrupt get/set affinity

Add default implementations for bsp_interrupt_get_affinity() and bsp_interrupt_set_affinity() which are required to link all tests in SMP configurations. Update #3269. --- bsps/arm/raspberrypi/include/bsp/irq.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/bsps/a

[PATCH 32/41] validation: Test rtems_interrupt_vector_enable()

Update #3269. --- .../testsuites/validation/validation-0.yml| 1 + testsuites/validation/tc-intr-vector-enable.c | 641 ++ 2 files changed, 642 insertions(+) create mode 100644 testsuites/validation/tc-intr-vector-enable.c diff --git a/spec/build/testsuites/validation/valid

Re: [PATCH rtems-libbsd v2 1/2] freebsd/if_cgem: Fail probe for unterminated MII

On 7/11/2021 19:47, Chris Johns wrote: On 10/7/21 12:53 am, Kinsey Moore wrote: When the MII bus is unterminated on unused interfaces, it results in PHY read timeouts which manifest as spurious PHYs during the attach call. Detect these timeouts during the probe so the device can be ignored. ---

[PATCH v1] Reports: Convert to C++

--- tester/covoar/ReportsBase.cc | 296 ++-- tester/covoar/ReportsBase.h | 118 +++-- tester/covoar/ReportsHtml.cc | 1074 +- tester/covoar/ReportsHtml.h | 94 ++-- tester/covoar/ReportsText.cc | 261 +- tester/covoar/ReportsText.h |

Re: GSoC - Code Formatting and Style Checking for RTEMS score

Hello, What I did was copy and paste the script into my local rtems/.git/hooks/pre-commit file, intentionally made some wrong style changes in some files and tried making a commit. I have documented how it works here https://github.com/Idadelveloper/rtems-docs/commit/a30407e159726ce745df7ab4813c5b3

[PATCH rtems-libbsd v1] nexus: Added SDHCI driver to ZynqMP

Made ZynqMP build with the SDHCI driver. --- rtemsbsd/include/bsp/nexus-devices.h | 4 +++ .../include/machine/rtems-bsd-nexus-bus.h | 29 +++ 2 files changed, 33 insertions(+) diff --git a/rtemsbsd/include/bsp/nexus-devices.h b/rtemsbsd/include/bsp/nexus-devices.h

Re: [PATCH 19/41] bsps/irq: Implement new directives for GICv2/3

Comments inline below. On 7/12/2021 07:49, Sebastian Huber wrote: Update #3269. --- bsps/include/dev/irq/arm-gic-irq.h | 3 + bsps/shared/dev/irq/arm-gicv2.c| 93 +--- bsps/shared/dev/irq/arm-gicv3.c| 131 - 3 files changed, 194 inserti

Re: [PATCH 19/41] bsps/irq: Implement new directives for GICv2/3

On 13/07/2021 04:46, Kinsey Moore wrote: index a1ba5e9112..6f5d4015e4 100644 --- a/bsps/shared/dev/irq/arm-gicv2.c +++ b/bsps/shared/dev/irq/arm-gicv2.c @@ -1,5 +1,5 @@   /* - * Copyright (c) 2013, 2019 embedded brains GmbH.  All rights reserved. + * Copyright (c) 2013, 2021 embedded brains GmbH.