[PATCH] sb/config.py: Fix operator reconstruction

Close #4335 --- source-builder/sb/config.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/source-builder/sb/config.py b/source-builder/sb/config.py index d3ba6cd..5bc96e2 100644 --- a/source-builder/sb/config.py +++ b/source-builder/sb/config.py @@ -991,9 +991,9 @@ clas

Can no longer find the _edata symbol in the linkcmd's for qoriq_e500

Is there an equivalent to _edata (I still use it for beatnik)? Danke Heinz smime.p7s Description: S/MIME cryptographic signature ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: GSoC Introduction

On Wed, Mar 10, 2021 at 7:47 PM Ida Delphine wrote: > > Is it okay I assign a task to myself? > The way it works is that you will discuss the open projects (here) with mentors, and identify one to develop into a proposal. It will not be assigned until later maybe, but we aim to prevent multiple st

Re: [PATCH] sb/config.py: Fix operator reconstruction

Looks alright, Vijay can you push? On Thu, Mar 11, 2021 at 12:32 AM Ricardo Cárdenes wrote: > > Close #4335 > --- > source-builder/sb/config.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/source-builder/sb/config.py b/source-builder/sb/config.py > index d3ba6cd

RE: [PATCH] shell.c: Dereference after null check (CID #26083)

After talking with Joel, we determined that 'out' shouldn’t be NULL by the time it gets to rtems_shell_login(). We think that we should put in an assert to check whether stdin and stdout is NULL at https://git.rtems.org/rtems/tree/cpukit/libmisc/shell/shell.c#n968. Instead of the check that I p

RE: [PATCH 1/2] covoar: Fix NOP execution marking

Hi Chris, Good catch. That looks to be left over from some debugging I was doing. I noticed that I had changed the contents of that "catch" in a later patch that I have not sent out yet. I have rolled that change into this patch and will send out a v2 of this set. -Original Message- Fr

[PATCH v2 2/2] covoar/Target_i386: Add NOP patterns

A couple of NOP patterns found with the pc686 BSP were not detected. This has been fixed. --- tester/covoar/Target_i386.cc | 9 + 1 file changed, 9 insertions(+) diff --git a/tester/covoar/Target_i386.cc b/tester/covoar/Target_i386.cc index e0c9c0f..4567c1e 100644 --- a/tester/covoar/Targ

[PATCH v2 1/2] covoar: Fix NOP execution marking

Some NOP instructions were not being marked as executed because they are located at the end of uncovered ranges. This has been fixed. --- tester/covoar/CoverageMapBase.cc | 10 +++ tester/covoar/CoverageMapBase.h | 4 ++ tester/covoar/DesiredSymbols.cc | 38 -- tester/covoar/Desir

[PATCH v2 0/2] Fix NOP recognition

v2: - Fix leftover debugging code in Coverage::finalizeSymbol() This patch set fixes a couple cases where NOP instructions were showing up as unexecuted in coverage reports. Alex White (2): covoar: Fix NOP execution marking covoar/Target_i386: Add NOP patterns tester/covoar/CoverageMapBase.

Re: [PATCH] shell.c: Dereference after null check (CID #26083)

On Thu, Mar 11, 2021 at 8:56 AM Ryan Long wrote: > > After talking with Joel, we determined that 'out' shouldn’t be NULL by the > time it gets to rtems_shell_login(). > > We think that we should put in an assert to check whether stdin and stdout is > NULL at https://git.rtems.org/rtems/tree/cpuk

Re: [PATCH 1/2] covoar: Fix NOP execution marking

On Thu, Mar 11, 2021 at 9:01 AM Alex White wrote: > > Hi Chris, > > Good catch. That looks to be left over from some debugging I was doing. > I caught what you did there. Ha, ha, ha, I hope you don't take exception to my pun. I tried to restrain myself. > I noticed that I had changed the contents

[PATCH] covoar/TargetBase: Rename branchInstructions to conditionalBranchInstructions

The TargetBase class contains a member variable named branchInstructions. The name omits the fact that it is only meant to contain conditional branch instructions. Its name has been changed to conditionalBranchInstructions to avoid confusion. --- tester/covoar/TargetBase.cc | 10 +++- tester/c

Re: [PATCH] covoar/TargetBase: Rename branchInstructions to conditionalBranchInstructions

looks ok On Thu, Mar 11, 2021 at 9:25 AM Alex White wrote: > > The TargetBase class contains a member variable named > branchInstructions. The name omits the fact that it is only meant to > contain conditional branch instructions. Its name has been changed to > conditionalBranchInstructions to av

Re: [PATCH v2 0/2] Fix NOP recognition

Looks ok to me, might wait for Chris to ACK the change to the exception logic but it appears to be throwing the original exception up the stack so this should be good. On Thu, Mar 11, 2021 at 9:15 AM Alex White wrote: > > v2: > - Fix leftover debugging code in Coverage::finalizeSymbol() > > This

Re: [PATCH] sb/config.py: Fix operator reconstruction

Hi Ricardo and Gedare, On Thu, Mar 11, 2021 at 8:27 AM Gedare Bloom wrote: > > Looks alright, Vijay can you push? > Tested with PowerPC tool chain and net legacy build. Works great. I'll push the patch to upstream and to 5 with a different ticket. > On Thu, Mar 11, 2021 at 12:32 AM Ricardo Cárde

Re: [PATCH] sb/config.py: Fix operator reconstruction

Hi, Pushed the patches to upstream and 5. Thank you! Best regards, Vijay On Thu, Mar 11, 2021 at 9:46 AM Vijay Kumar Banerjee wrote: > > Hi Ricardo and Gedare, > > On Thu, Mar 11, 2021 at 8:27 AM Gedare Bloom wrote: > > > > Looks alright, Vijay can you push? > > > Tested with PowerPC tool chai

Re: [PATCH 00/26] leon: various fixes and TN0018 errata workaround

On 2021-03-08 16:43, Joel Sherrill wrote: On Sun, Mar 7, 2021 at 9:51 AM Daniel Hellstrom > wrote: On 2020-09-23 17:05, Gedare Bloom wrote: On Wed, Sep 23, 2020 at 4:34 AM Daniel Hellstrom wrote: Hi Sebastian, Thanks

[PATCH] covoar/Target_arm: Add THUMB branch instructions

The ".n" and ".w" variants of the THUMB branch instructions were not included in the list of conditional branch instructions. They have been added. --- tester/covoar/Target_arm.cc | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tester/covoar/Target_arm.cc b/

[PATCH 0/2] Fix QEMU branch analysis

This patch set contains a couple of fixes for issues that were found while using covoar to analyze branch coverage in QEMU. Alex White (2): covoar/CoverageReaderQEMU: Fix infinite loop covoar/TargetBase: Fix QEMU branch info tester/covoar/CoverageReaderQEMU.cc | 11 +-- tester/covoar

[PATCH 2/2] covoar/TargetBase: Fix QEMU branch info

The taken/not taken bit was being interpreted incorrectly. This led to branches being marked "always taken" when they were never taken. This has been fixed. --- tester/covoar/TargetBase.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tester/covoar/TargetBase.cc b/tester/

[PATCH 1/2] covoar/CoverageReaderQEMU: Fix infinite loop

There was a potential that the branch info loop never terminated. This has been fixed by adding a more reliable termination condition and logging an error if it cannot find the branch target. --- tester/covoar/CoverageReaderQEMU.cc | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-)

[PATCH] covoar: Fix DWARF reading

There were a couple of issues with the way the DWARF info was being read. The first issue was that it inefficiently included all symbols, even symbols that were not desired. The second issue is that it did not handle inline functions correctly. These have been fixed. --- tester/covoar/ExecutableIn

ftw() Test Additions May Require rtems6 Tool Update

Hi First, this does NOT impact rtems5. On February 3, Eshan Dhawan posted additions to the RTEMS test suite for ftw() and nftw() which he had previously worked to add to newlib. There have been multiple updates to the rtems6 tool recipes in the RSB since then so if you may already have ftw() and

Re: [PATCH] sb/config.py: Fix operator reconstruction

On 12/3/21 3:55 am, Vijay Kumar Banerjee wrote: > Hi, > > Pushed the patches to upstream and 5. Thank you! > Thank you for the testing and Ricardo thank you for the fix. Excellent work. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.o

[PATCH v2] shell.c: Fix Dereference after null check (CID #26083)

CID 26083: Dereference after null check in rtems_shell_login(). Closes #4327 --- cpukit/libmisc/shell/shell.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cpukit/libmisc/shell/shell.c b/cpukit/libmisc/shell/shell.c index 1e5962b..ad47460 100644 --- a/cpukit/libmisc/shell/shell.c +++ b

Re: [PATCH v2] shell.c: Fix Dereference after null check (CID #26083)

OK On Thu, Mar 11, 2021 at 3:17 PM Ryan Long wrote: > > CID 26083: Dereference after null check in rtems_shell_login(). > > Closes #4327 > --- > cpukit/libmisc/shell/shell.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/cpukit/libmisc/shell/shell.c b/cpukit/libmisc/shell/shell.c

Re: Installing rtems on 32 bit windows host machine

Re-adding devel@ to keep things recorded. On Thu, Mar 11, 2021 at 1:23 PM Alireza Banejad wrote: > Hello Joel, > thank you for responding, > so basically I installed the msys2 i686 and downloaded the packages and > finally downloaded themingw-w64-i686-toolchain, after exporting the > proper path

Re: [PATCH] sb/config.py: Fix operator reconstruction

Thanks Chris, Looking forward to future contributions :-) Regards, Ricardo On Thu, Mar 11, 2021 at 9:14 AM Chris Johns wrote: > On 12/3/21 3:55 am, Vijay Kumar Banerjee wrote: > > Hi, > > > > Pushed the patches to upstream and 5. Thank you! > > > > Thank you for the testing and Ricardo thank y

[PATCH] score: Add Thread_Configuration::cpu_time_budget

Move the CPU time budget to the thread configuration. This simplifies _Thread_Initialize(). --- cpukit/include/rtems/posix/pthreadimpl.h | 26 +++--- cpukit/include/rtems/score/threadimpl.h | 5 +++ cpukit/posix/src/psxtransschedparam.c| 23 +++-- cpukit/posix/src/pthreadcre