RE: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi

> -Original Message- > From: devel On Behalf Of Chris Johns > Sent: Tuesday, February 16, 2021 10:53 PM > To: Gedare Bloom ; Peter Dufault > Cc: devel@rtems.org > Subject: Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi > [...] > > We haven't really made anything o

RE: [PATCH 1/1] zynq-uart: Fix set_attributes implementation

> -Original Message- > From: Chris Johns > Sent: Wednesday, February 10, 2021 12:08 AM > To: Sommer, Jan ; devel@rtems.org > Subject: Re: [PATCH 1/1] zynq-uart: Fix set_attributes implementation > > On 9/2/21 11:42 pm, Jan Sommer wrote: > > From: Kinsey Moore > > > > The zynq-uart set

RE: splinkersets01 test assumptions

On 2021/02/17 00:15, Sebastian Huber wrote: > On 16/02/2021 22:26, Kinsey Moore wrote: >> In verifying AArch64/ILP32 on hardware I ran across quite a few alignment >> issues, some of which were caused by the use of SUBALIGN() in the linker >> scripts mentioned here: >> https://devel.rtems.org/tic

Re: splinkersets01 test assumptions

On 17/02/2021 16:32, Kinsey Moore wrote: .section.rtemsroset.s.begin,"a" .align 8 .type _Linker_set_s_begin, %object .size _Linker_set_s_begin, 0 _Linker_set_s_begin: .section.rtemsroset.s.end,"a" .align 8

Re: [PATCH 1/1] misc: tools: fix mkimage.py script type processing

On Wed, Feb 17, 2021 at 12:35 AM wrote: > > Hi Chris, > > as far as my understanding of python goes this does not make any difference. > Strings are essentially arrays in python which would make the parenthesis > obsolete. > > When this condition should catch another type in the future it would b

RE: splinkersets01 test assumptions

> On 17/02/2021 16:32, Kinsey Moore wrote: >>> .section.rtemsroset.s.begin,"a" >>> .align 8 >>> .type _Linker_set_s_begin, %object >>> .size _Linker_set_s_begin, 0 >>> _Linker_set_s_begin: >>> .section.rtemsroset.s.end,"a" >>>

Re: [PATCH v2 12/12] c-user: Generate clock manager documentation

On 11/02/2021 14:31, Frank Kühndel wrote: +rtems_status_code rtems_clock_set( const rtems_time_of_day *time ); A comment only: The above is a change in the signature of the function (adding `const`). Not that I object to it - on the contrary. Yet, it may break existing code (e.g. code which

Re: splinkersets01 test assumptions

On 17/02/2021 17:41, Kinsey Moore wrote: I would remove the SUBALIGN() from the linker script. You can also add a new test case for splinkersets01 similar to struct s from above. Then we should check if the test fails on aarch64 and why it fails. The example above actually shows the issue I'm h

Re: [PATCH v2 00/12] Generate documentation for managers

On 10/02/2021 21:33, Gedare Bloom wrote: On Wed, Feb 10, 2021 at 9:46 AM Sebastian Huber > wrote: On 10/02/2021 17:42, Gedare Bloom wrote: > Is (will be) there a section to explain the Constraints and how to > interpret them? Mainly, wh

Coverity Reports on Passing NULL to fileno()

Hi Ryan has been investigating some Coverity reports where fileno(FILE *) could be passed a NULL. I asked about adding a NULL check in newlib and was reminded that POSIX leaves passing a NULL pointer as undefined behavior. I don't want to ignore calls to fileno() and other methods from RTEMS code

Re: Coverity Reports on Passing NULL to fileno()

On 17/02/2021 18:58, Joel Sherrill wrote: I don't want to ignore calls to fileno() and other methods from RTEMS code that potentially could pass a NULL in. I only see a few options:   + Use an rtems_fileno() wrapper which does check for NULL. I don't like this because it opens a path of doi

Re: Coverity Reports on Passing NULL to fileno()

On Wed, Feb 17, 2021 at 11:21 AM Sebastian Huber wrote: > > On 17/02/2021 18:58, Joel Sherrill wrote: > > > > > I don't want to ignore calls to fileno() and other methods from RTEMS > > code that potentially could pass a NULL in. I only see a few options: > > > > + Use an rtems_fileno() wrapper

Project Status: #3333

Hello, I went through the list of open projects and found project. # Automate Conversion of Newlib Markup to Sphinx I would be very grateful to know the work done/needed to be done in it. Thanks -Dev ___ devel m

Re: [PATCH 1/1] misc: tools: fix mkimage.py script type processing

On 18/2/21 3:26 am, Gedare Bloom wrote: > On Wed, Feb 17, 2021 at 12:35 AM wrote: >> >> Hi Chris, >> >> as far as my understanding of python goes this does not make any difference. >> Strings are essentially arrays in python which would make the parenthesis >> obsolete. >> >> When this condition

[PATCH] c-user: Generate signal manager documentation

The documentation is a consolidation of the comments in Doxygen markup and the documentation sources in Sphinx markup. The documentation was transfered to interface specification items. The documentation source files were generated from the items by a script. Update #3993. --- c-user/signal/dir

[PATCH 00/13] Avoid potential recursion in ASR handling

This patch set adds validation tests for the signal manager and fixes a potential issue with a recursion in the ASR handling. The main issue is that _Signal_Action_handler() used rtems_task_mode() to save, set, and restore the task mode during ASR processing. This is effectively a recursive call

[PATCH 03/13] score: Change thread action locking

Require that the corresponding lock is acquired before the action handler returns. This helps to avoid recursion in the signal processing. Update #4244. --- cpukit/include/rtems/score/thread.h | 19 +++ cpukit/posix/src/psignalunblockthread.c | 2 ++ cpukit/rtems/src/signalc

[PATCH 12/13] rtems: Add _Modes_Set_timeslice()

Update #4244. --- cpukit/include/rtems/rtems/modesimpl.h | 15 +++ cpukit/rtems/src/taskmode.c| 8 +--- 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/cpukit/include/rtems/rtems/modesimpl.h b/cpukit/include/rtems/rtems/modesimpl.h index 5677c7f13d..f6

[PATCH 13/13] rtems: Avoid potential recursion in ASR handling

Do the mode changes necessary for the ASR processing directly under protection of the thread state lock to avoid the recursive calls to thread dispatching done in rtems_task_mode(). Update #4244. --- cpukit/rtems/src/signalsend.c | 89 --- 1 file changed, 82 insert

[PATCH 10/13] rtems: Simplify signal handling

Remove superfluous ASR_Information::signals_posted. Move code out of trivial inline functions. Update #4244. --- cpukit/headers.am | 1 - cpukit/include/rtems/rtems/asrdata.h| 2 - cpukit/include/rtems/rtems/asrimpl.h| 90 - cpukit/include/

[PATCH 05/13] posix: Remove superfluous check

The api pointer is never NULL. Update #4244. --- cpukit/posix/src/psignalunblockthread.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/cpukit/posix/src/psignalunblockthread.c b/cpukit/posix/src/psignalunblockthread.c index 63ed823ab3..a1af20a5af 100644 --- a/cpukit/posix/src/psignalun

[PATCH 04/13] score: Add _Thread_Append_post_switch_action()

Update #4244. --- cpukit/include/rtems/score/threadimpl.h | 38 ++--- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/cpukit/include/rtems/score/threadimpl.h b/cpukit/include/rtems/score/threadimpl.h index e76f9c3972..e9d44526da 100644 --- a/cpukit/include/rtems

[PATCH 01/13] validation: Add Validation1 test suite

Update #4244. --- spec/build/bsps/tstsmallmem.yml | 1 + spec/build/testsuites/validation/grp.yml | 2 + .../testsuites/validation/validation-1.yml| 19 + testsuites/validation/ts-default.h| 4 +- testsuites/validation/ts-validation-0.c | 4 +- test

[PATCH 08/13] rtems: Remove unused ASR_Information::nest_level

Update #4244. --- cpukit/include/rtems/rtems/asrdata.h | 2 -- cpukit/rtems/src/signalcatch.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/cpukit/include/rtems/rtems/asrdata.h b/cpukit/include/rtems/rtems/asrdata.h index caf29a0863..b0cb8f3bbc 100644 --- a/cpukit/include/rtems/rtem

[PATCH 02/13] validation: Add signal manager tests

Update #4244. --- .../testsuites/validation/validation-0.yml|2 + .../testsuites/validation/validation-1.yml|2 + testsuites/validation/tc-signal-catch.c | 1017 +++ testsuites/validation/tc-signal-send.c| 1146 + 4 files changed, 2167 inse

[PATCH 11/13] rtems: New errors for rtems_signal_catch()

Ensure that no invalid modes are set during ASR processing. Update #4244. --- cpukit/rtems/src/signalcatch.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/cpukit/rtems/src/signalcatch.c b/cpukit/rtems/src/signalcatch.c index 8ee22e5ec1..da56d26dc5 100644 --- a/c

[PATCH 07/13] rtems: Remove unused _Modes_Change()

Update #4244. --- cpukit/include/rtems/rtems/modesimpl.h | 26 -- 1 file changed, 26 deletions(-) diff --git a/cpukit/include/rtems/rtems/modesimpl.h b/cpukit/include/rtems/rtems/modesimpl.h index db98cb419f..5677c7f13d 100644 --- a/cpukit/include/rtems/rtems/modesimpl.h

[PATCH 06/13] rtems: Remove unused _Modes_Mask_changed()

Update #4244. --- cpukit/include/rtems/rtems/modesimpl.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/cpukit/include/rtems/rtems/modesimpl.h b/cpukit/include/rtems/rtems/modesimpl.h index 5a147b10b9..db98cb419f 100644 --- a/cpukit/include/rtems/rtems/modesimpl.h +++ b/cpukit

[PATCH 09/13] rtems: Move _Signal_Action_handler()

Move _Signal_Action_handler() and signal MP initialization to rtems_signal_send(). The goal is to make _Signal_Action_handler() a static function in a follow up patch. Update #4244. --- cpukit/rtems/src/signalcatch.c | 54 -- cpukit/rtems/src/signalsend.c | 54 ++

RE: splinkersets01 test assumptions

Thanks for taking a look at this. I'll push this up to GCC. In the meantime, I'll remove SUBALIGN and adjust things as necessary. Kinsey -Original Message- From: Sebastian Huber Sent: Wednesday, February 17, 2021 11:20 To: Kinsey Moore ; devel@rtems.org Subject: Re: splinkersets01 test

Fwd: Buildbot failure in RTEMS on powerpc/psim FreeBSD 10.1-STABLE GCC 7.3.0 POSIX

Any idea why psim fails on buildbot but not the other BSPs run through buildbot? Did Amar miss updating the powerpc tools? -- Forwarded message - From: Date: Wed, Feb 17, 2021 at 2:02 PM Subject: Buildbot failure in RTEMS on powerpc/psim FreeBSD 10.1-STABLE GCC 7.3.0 POSIX To:

Re: [PATCH 1/1] zynq-uart: Fix set_attributes implementation

On 17/2/21 11:47 pm, jan.som...@dlr.de wrote: >> -Original Message- >> From: Chris Johns >> Sent: Wednesday, February 10, 2021 12:08 AM >> To: Sommer, Jan ; devel@rtems.org >> Subject: Re: [PATCH 1/1] zynq-uart: Fix set_attributes implementation >> >> On 9/2/21 11:42 pm, Jan Sommer wrote:

Re: Fwd: Buildbot failure in RTEMS on powerpc/psim FreeBSD 10.1-STABLE GCC 7.3.0 POSIX

On 18/2/21 7:18 am, Joel Sherrill wrote: > Any idea why psim fails on buildbot but not the other BSPs run through > buildbot? > > Did Amar miss updating the powerpc tools? Autoconf vs waf? Buildbot is still on autoconf. Chris > > -- Forwarded message - > From: mailto:build...@

Re: Fwd: Buildbot failure in RTEMS on powerpc/psim FreeBSD 10.1-STABLE GCC 7.3.0 POSIX

On Wed, Feb 17, 2021, 2:56 PM Chris Johns wrote: > On 18/2/21 7:18 am, Joel Sherrill wrote: > > Any idea why psim fails on buildbot but not the other BSPs run through > buildbot? > > > > Did Amar miss updating the powerpc tools? > > Autoconf vs waf? Buildbot is still on autoconf. > That's it. Po

Re: Fwd: Buildbot failure in RTEMS on powerpc/psim FreeBSD 10.1-STABLE GCC 7.3.0 POSIX

On Wed, Feb 17, 2021 at 2:12 PM Joel Sherrill wrote: > > > > On Wed, Feb 17, 2021, 2:56 PM Chris Johns wrote: >> >> On 18/2/21 7:18 am, Joel Sherrill wrote: >> > Any idea why psim fails on buildbot but not the other BSPs run through >> > buildbot? >> > >> > Did Amar miss updating the powerpc too

Re: Fwd: Buildbot failure in RTEMS on powerpc/psim FreeBSD 10.1-STABLE GCC 7.3.0 POSIX

On Wed, Feb 17, 2021 at 3:36 PM Gedare Bloom wrote: > On Wed, Feb 17, 2021 at 2:12 PM Joel Sherrill wrote: > > > > > > > > On Wed, Feb 17, 2021, 2:56 PM Chris Johns wrote: > >> > >> On 18/2/21 7:18 am, Joel Sherrill wrote: > >> > Any idea why psim fails on buildbot but not the other BSPs run >