Re: [PATCH v3] bsps/shared/ofw: Fix coverity reported defects

On Fri, Feb 5, 2021 at 12:22 AM Christian Mauderer wrote: > > > On 04/02/2021 17:34, Gedare Bloom wrote: > > > > > > On Thu, Feb 4, 2021 at 1:58 AM Niteesh G. S. > > wrote: > > > > > > > > On Thu, Feb 4, 2021 at 1:21 AM Gedare Bloom >

Re: [PATCH v3] bsps/shared/ofw: Fix coverity reported defects

Am 05.02.21 um 09:45 schrieb Niteesh G. S.: On Fri, Feb 5, 2021 at 12:22 AM Christian Mauderer mailto:cont...@c-mauderer.de>> wrote: On 04/02/2021 17:34, Gedare Bloom wrote: > > > On Thu, Feb 4, 2021 at 1:58 AM Niteesh G. S. mailto:niteesh...@gmail.com> >

[PATCH 1/3] score: Constify Thread_queue_First_operation

Update #4230. --- cpukit/include/rtems/score/threadq.h | 13 +++-- cpukit/score/src/threadqops.c| 12 ++-- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/cpukit/include/rtems/score/threadq.h b/cpukit/include/rtems/score/threadq.h index de7ca8391b..5234019

[PATCH 2/3] score: Make FIFO thread queue ops public

Update #4230. --- cpukit/include/rtems/score/threadqops.h | 134 cpukit/score/src/threadqops.c | 17 +-- 2 files changed, 143 insertions(+), 8 deletions(-) create mode 100644 cpukit/include/rtems/score/threadqops.h diff --git a/cpukit/include/rtems/score/threa

[PATCH 3/3] score: Add barrier thread queue operations

This fixes a missing decrement of the number of waiting threads during a barrier wait timeout. Close #4230. --- cpukit/include/rtems/score/corebarrierimpl.h | 4 ++- cpukit/score/src/corebarrierrelease.c| 1 - cpukit/score/src/corebarrierwait.c | 30 3 fil

Re: [PATCH v2] Test suite for FTW.H methods

Does the waf support actually build psxftw01.tar or is that a constant magic file? I might have missed it but I didn't see any logic to create it. Other than that, I don't have any issues. --joel On Wed, Feb 3, 2021 at 3:34 PM Eshan Dhawan wrote: > From: Eshan dhawan > > Signed-off-by: Eshan

Re: [PATCH v5] Confstr support for RTEMS

On Wed, Feb 3, 2021 at 3:46 PM Eshan Dhawan wrote: > From: Eshan dhawan > > Signed-off-by: Eshan Dhawan > --- > cpukit/Makefile.am| 1 + > cpukit/posix/src/confstr.c| 103 + > spec/build/cpukit/librtemscpu.yml | 1 + >

[PATCH 1/2] libtest: Add T_get_thread_timer_state()

--- cpukit/include/rtems/test.h| 11 ++- cpukit/libtest/t-test-rtems-objs.c | 29 + 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/cpukit/include/rtems/test.h b/cpukit/include/rtems/test.h index f96a5a6892..b42bf5f058 100644 --- a/cpukit/

[PATCH 2/2] validation: Tests for barrier manager

--- .../testsuites/validation/validation-0.yml| 4 + testsuites/validation/tc-barrier-create.c | 745 ++ testsuites/validation/tc-barrier-delete.c | 451 +++ testsuites/validation/tc-barrier-release.c| 588 ++ testsuites/validation/tc-barrier-w

Zynq Qemu with rtems-tester?

Hi Has anyone tried this lately on the master? My test script ended up with 100% failures. --joel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v2] Test suite for FTW.H methods

On Fri, Feb 5, 2021 at 7:31 PM Joel Sherrill wrote: > Does the waf support actually build psxftw01.tar or is that a constant > magic file? > I might have missed it but I didn't see any logic to create it. > Its the constant magic file modified from libtests/tar01 > > Other than that, I don't hav

Re: [PATCH v5] Confstr support for RTEMS

On Fri, Feb 5, 2021 at 7:41 PM Joel Sherrill wrote: > > > On Wed, Feb 3, 2021 at 3:46 PM Eshan Dhawan > wrote: > >> From: Eshan dhawan >> >> Signed-off-by: Eshan Dhawan >> --- >> cpukit/Makefile.am| 1 + >> cpukit/posix/src/confstr.c| 103

Re: [PATCH 3/3] score: Add barrier thread queue operations

On Fri, Feb 5, 2021 at 6:37 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > This fixes a missing decrement of the number of waiting threads during a > barrier wait timeout. > > Close #4230. > Is this bug a problem that should be fixed on any open branch(es)? Otherwise, the 3 pat

[PATCH 0/4] bsps/shared/ofw: Bug and Coverity defect fixes

The following series of patches fix bugs and coverity reported defect in bsps/shared/ofw.c. G S Niteesh Babu (4): bsps/shared/ofw: Fix coverity reported defects bsps/shared/ofw: Use memcpy instead of strncpy bsps/shared/ofw: Make rtems_ofw_get_effective_phandle iterative bsps/shared/ofw: B

[PATCH 1/4] bsps/shared/ofw: Fix coverity reported defects

Fixed use after free and null pointer dereference defects FIXES: 1) CID 1472601 (NULL_RETURNS) 2) CID 1472600 (USE_AFTER_FREE) 3) CID 1472599 (USE_AFTER_FREE) 4) CID 1472598 (USE_AFTER_FREE) 5) CID 1472596 (USE_AFTER_FREE) The below two defects have to marked false positive 1) CID 1472597 (ARRAY_

[PATCH 2/4] bsps/shared/ofw: Use memcpy instead of strncpy

Changed rtems_ofw_get_prop to use memcpy instead of strncpy --- bsps/shared/ofw/ofw.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.c index fa94bfbf05..9dec310247 100644 --- a/bsps/shared/ofw/ofw.c +++ b/bsps/shared/ofw/of

[PATCH 3/4] bsps/shared/ofw: Make rtems_ofw_get_effective_phandle iterative

Refactored recursive rtems_ofw_get_effective_phandle into a iterative function. --- bsps/shared/ofw/ofw.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.c index 9dec310247..e3626747fa 100644 --- a/bsps/shared/ofw/ofw.c +++ b

[PATCH 4/4] bsps/shared/ofw: Bug fixes

Fixed bugs in rtems_ofw_get_prop, rtems_ofw_get_prop_len and removed hardcoded value. --- bsps/shared/ofw/ofw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.c index e3626747fa..8b7f77311d 100644 --- a/bsps/shared/ofw/ofw.c ++

Re: [PATCH 2/4] bsps/shared/ofw: Use memcpy instead of strncpy

On Fri, Feb 5, 2021 at 10:41 AM G S Niteesh Babu wrote: > Changed rtems_ofw_get_prop to use memcpy instead of strncpy > --- > bsps/shared/ofw/ofw.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.c > index fa94bfbf05.

Re: [PATCH 3/4] bsps/shared/ofw: Make rtems_ofw_get_effective_phandle iterative

On Fri, Feb 5, 2021 at 10:41 AM G S Niteesh Babu wrote: > Refactored recursive rtems_ofw_get_effective_phandle into a > iterative function. > --- > bsps/shared/ofw/ofw.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/bsps/shared/ofw/ofw.c b/bsps/shared/ofw/ofw.

Re: [PATCH 0/4] bsps/shared/ofw: Bug and Coverity defect fixes

I'm good with everything except my comment on #2 On Fri, Feb 5, 2021 at 10:41 AM G S Niteesh Babu wrote: > The following series of patches fix bugs and coverity reported > defect in bsps/shared/ofw.c. > > G S Niteesh Babu (4): > bsps/shared/ofw: Fix coverity reported defects > bsps/shared/of

Standalone repository for libnetworking stack

Hello, I'm currently working on separating the libnetworking stack into its standalone repository that can be built separately with waf. The current status of the project is that I have a working rtems-libnetworking repository [1] that builds with waf (hasn't been tested with any test cases yet).

Re: [PATCH 3/3] score: Add barrier thread queue operations

On 05/02/2021 18:16, Gedare Bloom wrote: On Fri, Feb 5, 2021 at 6:37 AM Sebastian Huber > wrote: This fixes a missing decrement of the number of waiting threads during a barrier wait timeout. Close #4230. Is this bug a problem that

Re: Standalone repository for libnetworking stack

Hello Vijay, On 05/02/2021 19:41, Vijay Kumar Banerjee wrote: Hello, I'm currently working on separating the libnetworking stack into its standalone repository that can be built separately with waf. The current status of the project is that I have a working rtems-libnetworking repository [1]

Re: [PATCH 2/4] bsps/shared/ofw: Use memcpy instead of strncpy

On 05/02/2021 19:22, Gedare Bloom wrote: On Fri, Feb 5, 2021 at 10:41 AM G S Niteesh Babu > wrote: Changed rtems_ofw_get_prop to use memcpy instead of strncpy ---  bsps/shared/ofw/ofw.c | 10 +-  1 file changed, 9 insertions(+), 1 deletion

Re: Standalone repository for libnetworking stack

On Fri, Feb 5, 2021 at 2:54 PM Christian Mauderer wrote: > Hello Vijay, > > On 05/02/2021 19:41, Vijay Kumar Banerjee wrote: > > Hello, > > > > I'm currently working on separating the libnetworking stack into its > > standalone repository that can be built separately with waf. The current > > sta

Re: Standalone repository for libnetworking stack

On 6/2/21 8:28 am, Joel Sherrill wrote: > On Fri, Feb 5, 2021 at 2:54 PM Christian Mauderer > wrote: > > Hello Vijay, > > On 05/02/2021 19:41, Vijay Kumar Banerjee wrote: > > Hello, > > > > I'm currently working on separating the libnetworking stack

Re: [PATCH 3/3] score: Add barrier thread queue operations

On Fri, Feb 5, 2021 at 11:57 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 05/02/2021 18:16, Gedare Bloom wrote: > > > > > On Fri, Feb 5, 2021 at 6:37 AM Sebastian Huber > > > > wrote: > > > > This fixes a missing decrement of

Re: Standalone repository for libnetworking stack

On Fri, Feb 5, 2021 at 4:41 PM Chris Johns wrote: > On 6/2/21 8:28 am, Joel Sherrill wrote: > > On Fri, Feb 5, 2021 at 2:54 PM Christian Mauderer > > wrote: > > > > Hello Vijay, > > > > On 05/02/2021 19:41, Vijay Kumar Banerjee wrote: > > > Hello, > > >

Re: Standalone repository for libnetworking stack

Hello Christian, Joel, Chris, On Fri, Feb 5, 2021 at 3:41 PM Chris Johns wrote: > > On 6/2/21 8:28 am, Joel Sherrill wrote: > > On Fri, Feb 5, 2021 at 2:54 PM Christian Mauderer > > wrote: > > > > Hello Vijay, > > > > On 05/02/2021 19:41, Vijay Kumar Banerjee w

Re: Standalone repository for libnetworking stack

On Fri, Feb 5, 2021, 5:17 PM Vijay Kumar Banerjee wrote: > Hello Christian, Joel, Chris, > > On Fri, Feb 5, 2021 at 3:41 PM Chris Johns wrote: > > > > On 6/2/21 8:28 am, Joel Sherrill wrote: > > > On Fri, Feb 5, 2021 at 2:54 PM Christian Mauderer > > > wrote: > > > >

Re: spcontext01 failure

Thank you for the help. I wanted to make sure that the SMP Strong APA scheduler works on the single processor tests as well. Is there any bsp and debugger which I can use to check this? On Fri, Feb 5, 2021 at 11:21 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 05/02/2021 0

Re: [PATCH 3/4] bsps/shared/ofw: Make rtems_ofw_get_effective_phandle iterative

Hello Gedare, On Fri, Feb 5, 2021 at 11:53 PM Gedare Bloom wrote: > > > On Fri, Feb 5, 2021 at 10:41 AM G S Niteesh Babu > wrote: > >> Refactored recursive rtems_ofw_get_effective_phandle into a >> iterative function. >> --- >> bsps/shared/ofw/ofw.c | 9 + >> 1 file changed, 5 insertio

Re: [PATCH 2/4] bsps/shared/ofw: Use memcpy instead of strncpy

Hello Christian, On Sat, Feb 6, 2021 at 2:33 AM Christian Mauderer wrote: > On 05/02/2021 19:22, Gedare Bloom wrote: > > > > > > On Fri, Feb 5, 2021 at 10:41 AM G S Niteesh Babu > > wrote: > > > > Changed rtems_ofw_get_prop to use memcpy instead of strncpy > >

Re: [PATCH 2/4] bsps/shared/ofw: Use memcpy instead of strncpy

On Fri, Feb 5, 2021 at 11:52 PM Gedare Bloom wrote: > > > On Fri, Feb 5, 2021 at 10:41 AM G S Niteesh Babu > wrote: > >> Changed rtems_ofw_get_prop to use memcpy instead of strncpy >> --- >> bsps/shared/ofw/ofw.c | 10 +- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --gi