Re: [PATCH 0/3] libbsd: Create some basic buildsets.

2018-04-27 Thread Christian Mauderer
Am 27.04.2018 um 04:00 schrieb Joel Sherrill: > > > On Thu, Apr 26, 2018, 8:29 PM Chris Johns > wrote: > > On 26/04/2018 19:50, Christian Mauderer wrote: > > > > But it would be great if I could already get some first > > feedback for these patches. >

Re: [PATCH 1/2] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-27 Thread Cillian O'Donnell
On Fri, 27 Apr 2018, 04:48 Chris Johns, wrote: > On 27/04/2018 08:51, Joel Sherrill wrote: > > > >// Create the set of desired symbols. > >SymbolsToAnalyze = new Coverage::DesiredSymbols(); > > - SymbolsToAnalyze->load( symbolsFile ); > > > > > > I am having trouble seeing wh

Re: [PATCH 0/3] libbsd: Create some basic buildsets.

2018-04-27 Thread Chris Johns
On 27/04/2018 17:01, Christian Mauderer wrote: > Basically I think that the target version of this minimal buildset will > have about the features of the legacy stack - maybe a little less. This is a really good point and a nice thing to have because it provides a simplified environment for users

Re: [PATCH 2/2] rtems-tools/../testing: Add configuration files for coverage analysis.

2018-04-27 Thread Cillian O'Donnell
Yeah the config files are definitely a bit of a pick-a-mix. I only really made changes in the .ini and symbolset.cfg. The rest is mostly yours I guess Joel. You probably have the best idea of what to do with it. I think Chris wants to squash it together, add his changes and make new patches. On Th

Re: [PATCH 1/2] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-27 Thread Chris Johns
On 27/04/2018 17:21, Cillian O'Donnell wrote: > On Fri, 27 Apr 2018, 04:48 Chris Johns, > wrote: > > On 27/04/2018 08:51, Joel Sherrill wrote: > > > >        // Create the set of desired symbols. > >        SymbolsToAnalyze = new Coverage::DesiredSymbols()

Re: [PATCH 2/2] rtems-tools/../testing: Add configuration files for coverage analysis.

2018-04-27 Thread Chris Johns
On 27/04/2018 17:28, Cillian O'Donnell wrote: > Yeah the config files are definitely a bit of a pick-a-mix. I only really made > changes in the .ini and symbolset.cfg. The rest is mostly yours I guess Joel. > You probably have the best idea of what to do with it. I think Chris wants to > squash it

Re: [PATCH 0/3] libbsd: Create some basic buildsets.

2018-04-27 Thread Christian Mauderer
Am 27.04.2018 um 09:24 schrieb Chris Johns: > On 27/04/2018 17:01, Christian Mauderer wrote: >> Basically I think that the target version of this minimal buildset will >> have about the features of the legacy stack - maybe a little less. > > This is a really good point and a nice thing to have bec

Re: [PATCH 1/2] covoar: Add symbol set reader and ELF data parser to covoar.

2018-04-27 Thread Cillian O'Donnell
On Fri, 27 Apr 2018, 08:32 Chris Johns, wrote: > On 27/04/2018 17:21, Cillian O'Donnell wrote: > > On Fri, 27 Apr 2018, 04:48 Chris Johns, > > wrote: > > > > On 27/04/2018 08:51, Joel Sherrill wrote: > > > > > >// Create the set of desired symbols. >

[PATCH v2 1/4] waf: Fix usage of build-include from config.

2018-04-27 Thread Christian Mauderer
--- waf_libbsd.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/waf_libbsd.py b/waf_libbsd.py index 54a60a78..589d21a2 100644 --- a/waf_libbsd.py +++ b/waf_libbsd.py @@ -185,6 +185,7 @@ class Builder(builder.ModuleManager): # Include paths #

[PATCH v2 3/4] tcpdump: Remove unused file.

2018-04-27 Thread Christian Mauderer
--- freebsd/contrib/tcpdump/print-sunrpc.c | 182 - 1 file changed, 182 deletions(-) delete mode 100644 freebsd/contrib/tcpdump/print-sunrpc.c diff --git a/freebsd/contrib/tcpdump/print-sunrpc.c b/freebsd/contrib/tcpdump/print-sunrpc.c deleted file mode 100644 in

[PATCH v2 0/4] libbsd: Create some basic buildsets.

2018-04-27 Thread Christian Mauderer
An updated patch set for this toppic: The last patch should now cleanly disable all INET6 in the minimal configuration. That reduced the code size of the media01 test in the minimal configuration for another 60k: > arm-rtems5-size build/arm-rtems5-atsamv-*/media01.exe textdata bss

[PATCH v2 2/4] waf: Generate a rtems/bsd/modules.h

2018-04-27 Thread Christian Mauderer
The generated file defines a RTEMS_BSD_MODULE_xxx for each enabled module. That is usefull for conditional compilation depending on whether a module is build not. Update #3351. --- waf_libbsd.py | 32 1 file changed, 32 insertions(+) diff --git a/waf_libbsd.py b/

[PATCH v2 4/4] buildset: Add minimal and everything config.

2018-04-27 Thread Christian Mauderer
This adds two new buildset configurations: One that leaves out as much features as possible and one that enables all features. For the default configuration WiFi support is now disabled. To disable IPv6 for the minimal configuration, all -DINET6 are eliminated in libbsd.py. They are now replaced b

Re: odd waf error from examples-v2

2018-04-27 Thread Joel Sherrill
OK .. the waf in my git clone is OK but the copy of waf-2.0.7 I downloaded and dropped in the top directory doesn't work: [joel@rtbf64c examples-v2]$ ./waf distclean Traceback (most recent call last): File "./waf", line 164, in from waflib import Scripting ImportError: No module named wafli

Re: [PATCH 0/2] *** Covoar Outstanding Changes ***

2018-04-27 Thread Cillian O'Donnell
On 26 April 2018 at 08:50, Chris Johns wrote: > On 26/04/2018 16:11, Cillian O'Donnell wrote: > > On Thu, 26 Apr 2018, 03:27 Chris Johns, > > wrote: > > > >> Also, are there any RSB changes outstanding to build a suitable QEMU? > > > > Oh yes, I still have that build. I'

Re: [PATCH 0/2] *** Covoar Outstanding Changes ***

2018-04-27 Thread Chris Johns
On 28/4/18 7:41 am, Cillian O'Donnell wrote: > > > On 26 April 2018 at 08:50, Chris Johns > wrote: > > On 26/04/2018 16:11, Cillian O'Donnell wrote: > > On Thu, 26 Apr 2018, 03:27 Chris Johns, > >

Re: odd waf error from examples-v2

2018-04-27 Thread Chris Johns
On 27/4/18 11:36 pm, Joel Sherrill wrote: > OK .. the waf in my git clone is OK Clone of which repo? > but the copy of waf-2.0.7 I downloaded > and dropped in the top directory Such as: cp ~/Downloads/waf-2.0.7 waf ? Did you have to chmod the copied file? > doesn't work: > > [joel@rtbf64c