Re: [PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-10 Thread Chris Johns
On 10/08/2017 16:41, Christian Mauderer wrote: > > I was more concerned that the include list in builder.py has grown > significantly. If you don't have a problem with that, it's OK. > I will fix this after the merge. >> I could look at making libbsd.py into libbsd/__init__.py with a file per

[PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-10 Thread Christian Mauderer
From: Christian Mauderer There are some cases, where a header is installed into a directory with a different name then it's source directory. In that case, the build might fail because the header is not found. One example would be the . The source for this file is in freebsd/crypto/openssl/crypto

[PATCH 3/3] waf: Move glob operator ** to builder.py

2017-08-10 Thread Christian Mauderer
From: Christian Mauderer This allows a finer decision which headers should be installed. --- builder.py | 26 +- libbsd_waf.py| 30 +++--- waf_generator.py | 4 ++-- 3 files changed, 30 insertions(+), 30 deletions(-) diff --git a/builde

Re [PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-10 Thread Christian Mauderer
Hello Chris and Sichen, I updated the patch "waf_generator: Copy headers if necessary." according to Chris suggestions. @Chris: Could you have a look if it now looks OK for you? @Sichen: Could you replace the first patch in your patch set with this one? I also created a patch that moves the ** o

Re: [PATCH 1/3] waf_generator: Copy headers if necessary.

2017-08-10 Thread Chris Johns
OK with the minor change. On 11/08/2017 04:14, Christian Mauderer wrote: > From: Christian Mauderer > > There are some cases, where a header is installed into a directory with > a different name then it's source directory. In that case, the build > might fail because the header is not found. One

Re: [PATCH 3/3] waf: Move glob operator ** to builder.py

2017-08-10 Thread Chris Johns
OK. On 11/08/2017 04:14, Christian Mauderer wrote: > From: Christian Mauderer > > This allows a finer decision which headers should be installed. > --- > builder.py | 26 +- > libbsd_waf.py| 30 +++--- > waf_generator.py | 4 ++-- > 3 f

[PATCH v2 3/3] waf: Move glob operator ** to builder.py

2017-08-10 Thread Christian Mauderer
From: Christian Mauderer This allows a finer decision which headers should be installed. --- builder.py | 26 +- libbsd_waf.py| 30 +++--- waf_generator.py | 4 ++-- 3 files changed, 30 insertions(+), 30 deletions(-) diff --git a/builde

[PATCH v2 1/3] waf_generator: Copy headers if necessary.

2017-08-10 Thread Christian Mauderer
There are some cases, where a header is installed into a directory with a different name then it's source directory. In that case, the build might fail because the header is not found. One example would be the . The source for this file is in freebsd/crypto/openssl/crypto/opensslv.h. To allow the