Re: [PATCH 5/7] Adding RTEMS support for FREEBSD TTY

On 06/04/17 03:11, Kevin Kirspel wrote: --- rtemsbsd/include/machine/rtems-bsd-commands.h | 2 + rtemsbsd/include/machine/rtems-bsd-kernel-space.h | 1 + rtemsbsd/include/rtems/bsd/local/opt_gdb.h| 1 + rtemsbsd/include/rtems/netcmds-config.h | 2 + rtemsbsd/rt

RE:RE:[PATCH] Update:Change format specifiers to fix 4 warnings.

Great! That looks like a cleaner, more standardized solution. I was just hacking away until the warnings stopped. So can I go ahead and #include or should I wait until is defined before doing any more? Does this work for printk() too? Thanks Joel. ___

RE: [PATCH 5/7] Adding RTEMS support for FREEBSD TTY

I will revert the PPP changes. It will still uses RTEMS termios instead of FREEBSD. Kevin Kirspel Electrical Engineer - Sr. Staff Idexx Roswell 235 Hembree Park Drive Roswell GA 30076 Tel: (770)-510- ext. 81642 Direct: (770)-688-1642 Fax: (770)-510-4445 -Original Message- From: Seba

Re: RE:[PATCH] Update:Change format specifiers to fix 4 warnings.

On Fri, Apr 7, 2017 at 4:15 AM, Cillian O'Donnell wrote: > Great! That looks like a cleaner, more standardized solution. I was just > hacking away until the warnings stopped. So can I go ahead and #include > or should I wait until is defined before > doing any more? Does this work for printk()

[PATCH 1/2] Using inttypes macros fixes 4 format warnings

--- cpukit/libdl/rtl-obj-cache.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/cpukit/libdl/rtl-obj-cache.c b/cpukit/libdl/rtl-obj-cache.c index a4676cf..c859f60 100644 --- a/cpukit/libdl/rtl-obj-cache.c +++ b/cpukit/libdl/rtl-obj-cache.c @@ -22,6 +22,7

[PATCH 2/2] Using inttype macros fixes 39 format warnings

--- .../libcpu/powerpc/mpc5xx/vectors/vectors_init.c | 80 +++--- 1 file changed, 41 insertions(+), 39 deletions(-) diff --git a/c/src/lib/libcpu/powerpc/mpc5xx/vectors/vectors_init.c b/c/src/lib/libcpu/powerpc/mpc5xx/vectors/vectors_init.c index 4a6c5be..ff34a21 100644 --- a/c

Re: RE:[PATCH] Update:Change format specifiers to fix 4 warnings.

On Fri, Apr 7, 2017 at 10:05 AM, Joel Sherrill wrote: > > > On Fri, Apr 7, 2017 at 4:15 AM, Cillian O'Donnell > wrote: >> >> Great! That looks like a cleaner, more standardized solution. I was just >> hacking away until the warnings stopped. So can I go ahead and #include >> or should I wait unt

Re: RE:[PATCH] Update:Change format specifiers to fix 4 warnings.

On Fri, Apr 7, 2017 at 9:58 AM, Gedare Bloom wrote: > On Fri, Apr 7, 2017 at 10:05 AM, Joel Sherrill wrote: > > > > > > On Fri, Apr 7, 2017 at 4:15 AM, Cillian O'Donnell > > > wrote: > >> > >> Great! That looks like a cleaner, more standardized solution. I was just > >> hacking away until the w

[PATCH v2 5/7] Adding RTEMS support for FREEBSD TTY

--- rtemsbsd/include/machine/rtems-bsd-commands.h | 2 + rtemsbsd/include/machine/rtems-bsd-kernel-space.h | 1 + rtemsbsd/include/rtems/bsd/local/opt_gdb.h| 1 + rtemsbsd/include/rtems/netcmds-config.h | 2 + rtemsbsd/rtems/rtems-bsd-shell-stty.c | 40 +++

[PATCH v2 6/7] Adding test cases for FREEBSD termios support through tty

--- .../include/rtems/bsd/test/default-termios-init.h | 158 testsuite/termios/test_main.c | 856 + testsuite/termios/test_termios_driver.c| 136 testsuite/termios/test_termios_driver.h| 32 + testsuite/termios/test_termi

[PATCH v2 4/7] Updating FREEBSD for tty support

--- freebsd/sys/fs/devfs/devfs_int.h | 2 +- freebsd/sys/fs/devfs/devfs_vnops.c | 18 --- freebsd/sys/kern/kern_conf.c | 16 -- freebsd/sys/kern/subr_taskqueue.c | 10 -- freebsd/sys/kern/tty.c | 62 ++ freebsd/sys/kern/

[PATCH v2 3/7] Updating STTY command for use in RTEMS shell

--- freebsd/bin/stty/cchar.c | 9 ++ freebsd/bin/stty/gfmt.c | 6 freebsd/bin/stty/key.c | 9 ++ freebsd/bin/stty/modes.c | 9 ++ freebsd/bin/stty/print.c | 9 ++ freebs

[PATCH v2 7/7] Updating scripts for FREEBSD TTY support

--- libbsd.py | 77 --- libbsd_waf.py | 97 +++ 2 files changed, 163 insertions(+), 11 deletions(-) mode change 100755 => 100644 libbsd.py diff --git a/libbsd.py b/libbsd.py old mode 100755 ne

[PATCH v2 1/7] Adding stty command files from FREEBSD tree

--- freebsd/bin/stty/cchar.c | 142 ++ freebsd/bin/stty/extern.h | 45 +++ freebsd/bin/stty/gfmt.c | 129 freebsd/bin/stty/key.c| 296 ++ freebsd/bin/stty/modes.c | 248 +++

[PATCH 01/01] Undefine stdout in case a BSP includes stdio.h

--- freebsd/sys/dev/ofw/openfirm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/freebsd/sys/dev/ofw/openfirm.c b/freebsd/sys/dev/ofw/openfirm.c index 3e86d8d..9b39502 100644 --- a/freebsd/sys/dev/ofw/openfirm.c +++ b/freebsd/sys/dev/ofw/openfirm.c @@ -82,6 +82,9 @@ static void OF_putchar

[PATCH 05/05] Updating scripts for USB Serial Drivers

--- libbsd.py | 6 +- libbsd_waf.py | 30 ++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/libbsd.py b/libbsd.py index 3aa5610..3129266 100644 --- a/libbsd.py +++ b/libbsd.py @@ -796,7 +796,9 @@ def dev_usb_serial(mm): mod.addKernelSpaceHe

[PATCH 02/05] Add USB headers to support USB Serial drivers

--- freebsd/sys/dev/usb/uftdiio.h | 99 +++ 1 file changed, 99 insertions(+) create mode 100644 freebsd/sys/dev/usb/uftdiio.h diff --git a/freebsd/sys/dev/usb/uftdiio.h b/freebsd/sys/dev/usb/uftdiio.h new file mode 100644 index 000..b624483 --- /dev/nu

[PATCH 03/05] Update USB Serial Driver for use with RTEMS

--- freebsd/sys/dev/usb/serial/usb_serial.c | 12 1 file changed, 12 insertions(+) diff --git a/freebsd/sys/dev/usb/serial/usb_serial.c b/freebsd/sys/dev/usb/serial/usb_serial.c index b5d7ef7..f494b10 100644 --- a/freebsd/sys/dev/usb/serial/usb_serial.c +++ b/freebsd/sys/dev/usb/ser

[PATCH 04/05] Adding USB Serial test

--- testsuite/usbserial01/init.c | 380 +++ 1 file changed, 380 insertions(+) create mode 100644 testsuite/usbserial01/init.c diff --git a/testsuite/usbserial01/init.c b/testsuite/usbserial01/init.c new file mode 100644 index 000..bbefb5f --- /dev/null

LIBBSD USB Serial Patch

The LIBBSD USB Serial patch depends on the LIBBSD TTY patch I sent out earlier. Kevin Kirspel Electrical Engineer - Sr. Staff Idexx Roswell 235 Hembree Park Drive Roswell GA 30076 Tel: (770)-510- ext. 81642 Direct: (770)-688-1642 Fax: (770)-510-4445 ___

Re: [PATCH 1/2] Using inttypes macros fixes 4 format warnings

I'm OK with both these patches but not in a good position to apply them right now. Gedare/Chris.. can you apply these? Thanks. --joel On Fri, Apr 7, 2017 at 9:11 AM, Cillian O'Donnell wrote: > --- > cpukit/libdl/rtl-obj-cache.c | 21 - > 1 file changed, 12 insertions(+),

Re: [PATCH 1/2] Using inttypes macros fixes 4 format warnings

Thanks! I just went ahead and pushed these. Testing will hopefully occur over the weekend. Good eye for going for a file with a lot of warnings. :) --joel On Fri, Apr 7, 2017 at 3:29 PM, Joel Sherrill wrote: > I'm OK with both these patches but not in a good > position to apply them right now

[PATCH 08/11] Added inttype, fix 1 format warning

--- c/src/lib/libbsp/powerpc/mvme5500/pci/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/powerpc/mvme5500/pci/pci.c b/c/src/lib/libbsp/powerpc/mvme5500/pci/pci.c index 8601721..bef0173 100644 --- a/c/src/lib/libbsp/powerpc/mvme5500/pci/pci.c +++ b/c/s

[PATCH 05/11] Using inttype macro, fixes 1 format warning.

--- c/src/lib/libbsp/sparc64/shared/helenos/boot/sparc64/loader/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/sparc64/shared/helenos/boot/sparc64/loader/main.c b/c/src/lib/libbsp/sparc64/shared/helenos/boot/sparc64/loader/main.c index f063ad7..f52c2

[PATCH 01/11] Using inttype macro, fix 1 format warning

--- c/src/lib/libbsp/powerpc/shared/pci/detect_raven_bridge.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/powerpc/shared/pci/detect_raven_bridge.c b/c/src/lib/libbsp/powerpc/shared/pci/detect_raven_bridge.c index fc2127e..423dc6f 100644 --- a/c/src/lib/l

[PATCH 06/11] Inserted inttype macros, fix 11 format warnings.

When I got rid of the casts I was left with char * and couldn't find an inttype to fit it so I left the casts in. --- .../lib/libbsp/powerpc/virtex5/startup/bspstart.c | 25 +++--- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/virtex5/sta

[PATCH 07/11] Inserted inttypes, fixes 11 format warnings.

Like virtex5 I couldn't get rid of the casts. --- .../lib/libbsp/powerpc/virtex4/startup/bspstart.c | 25 +++--- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/virtex4/startup/bspstart.c b/c/src/lib/libbsp/powerpc/virtex4/startup/bspstart

[PATCH 03/11] Using inttype macro, fix 1 format warning

--- cpukit/score/cpu/i386/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cpukit/score/cpu/i386/cpu.c b/cpukit/score/cpu/i386/cpu.c index d839f1e..447d8ae 100644 --- a/cpukit/score/cpu/i386/cpu.c +++ b/cpukit/score/cpu/i386/cpu.c @@ -104,7 +104,8 @@ void _CPU_Initialize

[PATCH 02/11] Using inttype macro, fix 1 format warning

--- c/src/libchip/network/dec21140.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/c/src/libchip/network/dec21140.c b/c/src/libchip/network/dec21140.c index 3bfc91d..b76c02a 100644 --- a/c/src/libchip/network/dec21140.c +++ b/c/src/libchip/network/dec21140.c @@ -36,6 +36,7

[PATCH 04/11] Changes inttype used and adds casts, fixes 6 format warnings

Unfortunately I couldn't figure how to do this without casts. Either 32 or 64 bit was unhappy one way or the other. Type time_t seems to be particularly tricky. --- cpukit/rtems/src/ratemonreportstatistics.c | 36 +++--- 1 file changed, 18 insertions(+), 18 deletions(-) di

[PATCH 09/11] Added inttypes, fixes 11 format warnings.

--- c/src/lib/libbsp/powerpc/haleakala/mmu/mmu_405.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/c/src/lib/libbsp/powerpc/haleakala/mmu/mmu_405.c b/c/src/lib/libbsp/powerpc/haleakala/mmu/mmu_405.c index f57defb..38a0949 100644 --- a/c/src/lib/libbsp/p

[PATCH 10/11] Added inttypes, fixes 6 format warnings

--- c/src/lib/libbsp/m68k/mrm332/console/sci.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/c/src/lib/libbsp/m68k/mrm332/console/sci.c b/c/src/lib/libbsp/m68k/mrm332/console/sci.c index 1e92d6d..8e44f22 100644 --- a/c/src/lib/libbsp/m68k/mrm332/console/sci.c +

[PATCH 11/11] Change inttype used and add casts, fixes 6 format warnings.

Unfortunately I couldn't figure out how to do this without casts. Either 32 or 64 bit was unhappy one way or the other. Type time_t seems to be particularly tricky. --- cpukit/rtems/src/ratemonreportstatistics.c | 36 +++--- 1 file changed, 18 insertions(+), 18 deletions(-)

RE:RE:Using inttypes macros fixes 4 format warnings

Thanks Joel! Plenty more were that came from below. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

RE:[PATCH 04/11] Changes inttype used and adds casts, fixes 6 format warnings

IGNORE THIS ONE. It's a duplicate, that still has warnings. I couldn't figure out how to get rid of it. I'm new to git. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: RE:Using inttypes macros fixes 4 format warnings

On Fri, Apr 7, 2017 at 5:43 PM, Cillian O'Donnell wrote: > Thanks Joel! > No problem. The printf-format warnings are mostly easy to fix. But doing it right can be tedious. I have had my share of them tossed away for missing a detail. > > Plenty more were that came from below. > Nothing was at

Re: [PATCH 06/11] Inserted inttype macros, fix 11 format warnings.

On Fri, Apr 7, 2017 at 5:37 PM, Cillian O'Donnell wrote: > When I got rid of the casts I was left with char * and couldn't find an > inttype to fit it so I left the casts in. > char * can be printed with %p. printk() should support that but check. Do a simple test on Linux to see but I don't thi

Re: [PATCH 07/11] Inserted inttypes, fixes 11 format warnings.

Many of the values printed appear to be addresses. If they are pointers, use %p. --joel On Fri, Apr 7, 2017 at 5:37 PM, Cillian O'Donnell wrote: > Like virtex5 I couldn't get rid of the casts. > --- > .../lib/libbsp/powerpc/virtex4/startup/bspstart.c | 25 > +++--- > 1 file ch

Re: [PATCH 04/11] Changes inttype used and adds casts, fixes 6 format warnings

On Fri, Apr 7, 2017 at 5:50 PM, Cillian O'Donnell wrote: > IGNORE THIS ONE. > > It's a duplicate, that still has warnings. I couldn't figure out how to > get rid of it. I'm new to git. > > This might be one where PRItime_t needs to be defined in rtems/inttypes.h and that used. I think that's the

Re: [PATCH 04/11] Changes inttype used and adds casts, fixes 6 format warnings

On Fri, Apr 7, 2017 at 7:05 PM, Joel Sherrill wrote: > > > On Fri, Apr 7, 2017 at 5:50 PM, Cillian O'Donnell > wrote: >> >> IGNORE THIS ONE. >> >> It's a duplicate, that still has warnings. I couldn't figure out how to >> get rid of it. I'm new to git. >> > > This might be one where PRItime_t nee