Re: [PATCH 4/5] termios: Use IMFS nodes for new Termios devices

2016-09-19 Thread Chris Johns
On 16/09/2016 22:23, Sebastian Huber wrote: However, the device file system should go away in the future. Please raise a ticket if one does not exist. Thanks Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 4/5] termios: Use IMFS nodes for new Termios devices

2016-09-19 Thread Sebastian Huber
On 19/09/16 09:44, Chris Johns wrote: On 16/09/2016 22:23, Sebastian Huber wrote: However, the device file system should go away in the future. Please raise a ticket if one does not exist. I added one: https://devel.rtems.org/ticket/2786 -- Sebastian Huber, embedded brains GmbH Address :

Re: [PATCH] cpukit: Add nxp-sc16is752 serial device driver

2016-09-19 Thread Sebastian Huber
Please note that this is the first Termios device driver that is independent of a BSP, CPU architecture and console driver. It is currently work in progress and lacks support for interrupts. We will add this probably in one or two weeks. -- Sebastian Huber, embedded brains GmbH Address : Dorn

Re: [PATCH] cpukit: Add nxp-sc16is752 serial device driver

2016-09-19 Thread Gedare Bloom
It will be good to have some documentation (BSP/driver manual) about how to write these kind of termios drivers. Usually without it we will see someone just copy-paste this one and modify until they get it right... So lacking a plain english doc, this "first" implementation should provide enough co

Re: [PATCH] cpukit: Add nxp-sc16is752 serial device driver

2016-09-19 Thread Sebastian Huber
Hello Joel, - Joel Sherrill schrieb: > Sebastian, > > This is yet another style of serial port driver in recent history and > the software tax hasn't been paid on the last round of changes. this is not a new style of serial port drivers. It uses the new Termios device driver model which I

Re: [PATCH] cpukit: Add nxp-sc16is752 serial device driver

2016-09-19 Thread Alan Cudmore
I applied this patch and tried building the raspberrypi BSP and got this error: ../../../../../../../rtems-src/rtems/c/src/../../cpukit/dev/serial/nxp-sc16is752.c:17:27: fatal error: bsp/atsam-spi.h: No such file or directory #include Will this only build for the atsam BSP? I am interested in

Re: [PATCH] cpukit: Add nxp-sc16is752 serial device driver

2016-09-19 Thread Sebastian Huber
Sorry, this is a bug in the driver. We will fix this before we commit it. - Am 19. Sep 2016 um 20:53 schrieb Alan Cudmore alan.cudm...@gmail.com: > I applied this patch and tried building the raspberrypi BSP and got this > error: > ../../../../../../../rtems-src/rtems/c/src/../../cpukit/dev

Re: [PATCH] cpukit: Add nxp-sc16is752 serial device driver

2016-09-19 Thread Alan Cudmore
Thanks.. No hurry, I need to implement the new SPI api for the Pi anyway, Alan > On Sep 19, 2016, at 2:56 PM, Sebastian Huber > wrote: > > Sorry, this is a bug in the driver. We will fix this before we commit it. > > - Am 19. Sep 2016 um 20:53 schrieb Alan Cudmore alan.cudm...@gmail.com:

Re: [PATCH] cpukit: Add nxp-sc16is752 serial device driver

2016-09-19 Thread Sebastian Huber
Ok, it will be probably next week, since Alex is on holiday. For an example SPI driver see https://git.rtems.org/rtems/tree/c/src/lib/libbsp/arm/atsam/spi/atsam_spi_bus.c The main part of the driver is the bus transfer handler, e.g. |static int atsam_spi_transfer( spi_bus *base, const spi_ioc_

Re: [PATCH] cpukit: Add nxp-sc16is752 serial device driver

2016-09-19 Thread Chris Johns
On 20/09/2016 02:13, Sebastian Huber wrote: With the recent change for the new Termios device driver model its easier to move the existing console drivers, since there is no need to maintain major/minor numbers anymore. The drawback is that you have to use IMFS as the base file system. Howe