Re: rtems waf, examples, and RTEMS_POSIX_API

2020-12-01 Thread Chris Johns
On 2/12/20 3:39 am, Gedare Bloom wrote: > > > On Tue, Dec 1, 2020 at 12:33 AM Sebastian Huber > > > wrote: > > On 01/12/2020 07:49, Chris Johns wrote: > > > On 1/12/20 5:31 pm, Sebastian Huber wrote: > >> On 30/11/2020 21:43, Joel Sherrill

Re: rtems waf, examples, and RTEMS_POSIX_API

2020-12-01 Thread Gedare Bloom
On Tue, Dec 1, 2020 at 12:33 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 01/12/2020 07:49, Chris Johns wrote: > > > On 1/12/20 5:31 pm, Sebastian Huber wrote: > >> On 30/11/2020 21:43, Joel Sherrill wrote: > >>> On Mon, Nov 30, 2020 at 1:06 PM Sebastian Huber > >>> >>>

Re: rtems waf, examples, and RTEMS_POSIX_API

2020-11-30 Thread Sebastian Huber
On 01/12/2020 07:49, Chris Johns wrote: On 1/12/20 5:31 pm, Sebastian Huber wrote: On 30/11/2020 21:43, Joel Sherrill wrote: On Mon, Nov 30, 2020 at 1:06 PM Sebastian Huber mailto:sebastian.hu...@embedded-brains.de>> wrote:     On 30/11/2020 20:00, Joel Sherrill wrote:     >     Applications

Re: rtems waf, examples, and RTEMS_POSIX_API

2020-11-30 Thread Chris Johns
On 1/12/20 5:31 pm, Sebastian Huber wrote: > On 30/11/2020 21:43, Joel Sherrill wrote: >> On Mon, Nov 30, 2020 at 1:06 PM Sebastian Huber >> > > wrote: >>     On 30/11/2020 20:00, Joel Sherrill wrote: >>     >     Applications can use something like: >>   

Re: rtems waf, examples, and RTEMS_POSIX_API

2020-11-30 Thread Sebastian Huber
On 30/11/2020 21:43, Joel Sherrill wrote: On Mon, Nov 30, 2020 at 1:06 PM Sebastian Huber > wrote: On 30/11/2020 20:00, Joel Sherrill wrote: >     Applications can use something like: > >     #if __RTEMS_MAJOR__ >= 5 > >   

Re: rtems waf, examples, and RTEMS_POSIX_API

2020-11-30 Thread Joel Sherrill
On Mon, Nov 30, 2020 at 1:06 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 30/11/2020 20:00, Joel Sherrill wrote: > > > Applications can use something like: > > > > #if __RTEMS_MAJOR__ >= 5 > > > > POSIX threads are always enabled ... > > > > #endif > > > > >

Re: rtems waf, examples, and RTEMS_POSIX_API

2020-11-30 Thread Sebastian Huber
On 30/11/2020 20:00, Joel Sherrill wrote: Applications can use something like: #if __RTEMS_MAJOR__ >= 5 POSIX threads are always enabled ... #endif This is a change to our public API that was completely unnecessary. We do not require changes to application code when it can

Re: rtems waf, examples, and RTEMS_POSIX_API

2020-11-30 Thread Sebastian Huber
On 30/11/2020 20:00, Joel Sherrill wrote: > Similarly, RTEMS_POSIX_API should probably always be set and another > macro provided for POSIX signals. > > The meaning changed without considering the impact. We need to account > for this. If RTEMS_POSIX_API is defin

Re: rtems waf, examples, and RTEMS_POSIX_API

2020-11-30 Thread Joel Sherrill
On Mon, Nov 30, 2020, 12:56 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Hello Joel, > > On 30/11/2020 19:40, Joel Sherrill wrote: > > if rtems.check_posix(bld): > > bld.recurse('posix_hello_world') > > bld.recurse('both_hello') > if these examples don't us

Re: rtems waf, examples, and RTEMS_POSIX_API

2020-11-30 Thread Sebastian Huber
Hello Joel, On 30/11/2020 19:40, Joel Sherrill wrote:     if rtems.check_posix(bld):         bld.recurse('posix_hello_world')         bld.recurse('both_hello') if these examples don't use signals, I would just remove the check. I suspect rtems_check_posix() should always return true now and

rtems waf, examples, and RTEMS_POSIX_API

2020-11-30 Thread Joel Sherrill
Hi With more POSIX enabled by default, the RTEMS_POSIX_API flag has changed meanings and this has broken the meaning of checking for POSIX in rtems_waf. The rtems-examples use code like this which now turns off all POSIX examples because POSIX signals are disabled. if rtems.check_posix(bld):