On 9/2/2015 8:43 AM, Martin Galvan wrote:
On Wed, Sep 2, 2015 at 10:39 AM, Gedare Bloom wrote:
Joel,
Coordinate your patch/fixes with this patch. (I do prefer the separate
patches that Joel gave. Small atomic commits are better.)
Gedare
I thought he'd seen this e-mail :)
I agree that small
On Wed, Sep 2, 2015 at 10:39 AM, Gedare Bloom wrote:
> Joel,
> Coordinate your patch/fixes with this patch. (I do prefer the separate
> patches that Joel gave. Small atomic commits are better.)
> Gedare
I thought he'd seen this e-mail :)
I agree that small atomic commits are better. However, the
Looks OK to me.
>>
>> On Tue, Sep 1, 2015 at 3:10 PM, Martin Galvan
>> wrote:
>>> This patch fixes the following CppCheck errors found throughout the code:
>>>
>>> [c/src/lib/libbsp/shared/umon/umon.h:21]: (error) Invalid number of
>>> ch
On Tue, Sep 1, 2015 at 5:43 PM, Joel Sherrill wrote:
>
>
> On 9/1/2015 2:10 PM, Martin Galvan wrote:
>>
>> Hi everyone!
>>
>> I just ran CppCheck again on a fresh clone of the git repo and saw the
>> number of error reports was quite smaller than what I reported before.
>> That's because my previo
Apply to 4.11 and master
On Wed, Sep 2, 2015 at 9:35 AM, Gedare Bloom wrote:
> Looks OK to me.
>
> On Tue, Sep 1, 2015 at 3:10 PM, Martin Galvan
> wrote:
>> This patch fixes the following CppCheck errors found throughout the code:
>>
>> [c/src/lib/libbsp/shared/um
Looks OK to me.
On Tue, Sep 1, 2015 at 3:10 PM, Martin Galvan
wrote:
> This patch fixes the following CppCheck errors found throughout the code:
>
> [c/src/lib/libbsp/shared/umon/umon.h:21]: (error) Invalid number of character
> ({) when these macros are defined: '__cplu
On 9/1/2015 2:10 PM, Martin Galvan wrote:
Hi everyone!
I just ran CppCheck again on a fresh clone of the git repo and saw the
number of error reports was quite smaller than what I reported before.
That's because my previous run was on a (quite older) version; most of
those must've been fixed a
Hi everyone!
I just ran CppCheck again on a fresh clone of the git repo and saw the
number of error reports was quite smaller than what I reported before.
That's because my previous run was on a (quite older) version; most of
those must've been fixed already.
Some of the error reports remain, tho
This patch fixes the following CppCheck errors found throughout the code:
[c/src/lib/libbsp/shared/umon/umon.h:21]: (error) Invalid number of character
({) when these macros are defined: '__cplusplus'.
[cpukit/libmisc/dumpbuf/dumpbuf.c:69]: (error) Undefined behavior: Variable
'
On Thu, Aug 27, 2015 at 6:38 PM, Joel Sherrill
wrote:
>
>
> On 8/27/2015 4:15 PM, Martin Galvan wrote:
>>
>> On Thu, Aug 27, 2015 at 6:10 PM, Daniel Gutson
>> wrote:
>>>
>>> Maybe we can just provide the list until we provide the fixes? Martín?
>>
>>
>> Gladly. Keep in mind we ran cppcheck only o
On 8/27/2015 4:22 PM, Martin Galvan wrote:
On Thu, Aug 27, 2015 at 6:19 PM, Daniel Gutson
wrote:
Please note too that there are some false positives, like the realloc one.
Actually, we ruled out most false positives. IIRC that one is an actual bug.
Btw, sorry for the Spanish comment there.
On 8/27/2015 4:15 PM, Martin Galvan wrote:
On Thu, Aug 27, 2015 at 6:10 PM, Daniel Gutson
wrote:
Maybe we can just provide the list until we provide the fixes? Martín?
Gladly. Keep in mind we ran cppcheck only on the modules we use
(though some things may've slipped in, like nios):
Most o
e
> >>
> >> On Wed, Aug 12, 2015 at 5:43 PM, Daniel Gutson
> >> mailto:daniel.gut...@tallertechnologies.com>> wrote:
> >> > Hi guys,
> >> >
> >> > we will be posting patches for a number of errors reported by
> &
On Thu, Aug 27, 2015 at 6:19 PM, Daniel Gutson
wrote:
> Please note too that there are some false positives, like the realloc one.
Actually, we ruled out most false positives. IIRC that one is an actual bug.
Btw, sorry for the Spanish comment there. It means that if we don't
initialize _ccr we j
Please note too that there are some false positives, like the realloc one.
On Thu, Aug 27, 2015 at 6:15 PM, Martin Galvan
wrote:
> On Thu, Aug 27, 2015 at 6:10 PM, Daniel Gutson
> wrote:
>> Maybe we can just provide the list until we provide the fixes? Martín?
>
> Gladly. Keep in mind we ran cpp
On Thu, Aug 27, 2015 at 6:10 PM, Daniel Gutson
wrote:
> Maybe we can just provide the list until we provide the fixes? Martín?
Gladly. Keep in mind we ran cppcheck only on the modules we use
(though some things may've slipped in, like nios):
[c/src/lib/libbsp/shared/umon/umon.h:21]: (error) Inva
t; from
>> > >> which master is slowly diverging. Any patches you want applied
>> before
>> > >> the official release need to be (1) associated with a ticket on
>> Trac,
>> > >> and (2) apply to both
t applied before
> >> the official release need to be (1) associated with a ticket on Trac,
> >> and (2) apply to both the 4.11 and master branches.
> >>
> >> Gedare
> >>
> >> On Wed, Aug 12, 2015 at 5:43 PM, Daniel Gutson
> >> mailto:d
ed on rtems.git/4.11 branch, from
> >> which master is slowly diverging. Any patches you want applied before
> >> the official release need to be (1) associated with a ticket on Trac,
> >> and (2) apply to both the 4.11 and master branches.
> >>
> >> Geda
nches.
>>
>> Gedare
>>
>> On Wed, Aug 12, 2015 at 5:43 PM, Daniel Gutson
>> wrote:
>> > Hi guys,
>> >
>> > we will be posting patches for a number of errors reported by
>> > cppcheck (errors that we can confirm are not false positiv
fore
> the official release need to be (1) associated with a ticket on Trac,
> and (2) apply to both the 4.11 and master branches.
>
> Gedare
>
> On Wed, Aug 12, 2015 at 5:43 PM, Daniel Gutson
> wrote:
> > Hi guys,
> >
> > we will be posting patches for a num
, 2015 at 5:43 PM, Daniel Gutson
wrote:
> Hi guys,
>
> we will be posting patches for a number of errors reported by
> cppcheck (errors that we can confirm are not false positives).
> Please hold on any release.
>
>Daniel.
>
> --
>
> Daniel F. Gutson
> Ch
Hi guys,
we will be posting patches for a number of errors reported by
cppcheck (errors that we can confirm are not false positives).
Please hold on any release.
Daniel.
--
Daniel F. Gutson
Chief Engineering Officer, SPD
San Lorenzo 47, 3rd Floor, Office 5
Córdoba, Argentina
Phone
23 matches
Mail list logo
