Re: _TOD_Set lock release question

2019-12-09 Thread Joel Sherrill
I think I have implemented what you suggested and my new test is passing on positive and negative cases. Hopefully this version is ready to merge so I can begin to test the new build system. Thanks. --joel On Wed, Dec 4, 2019 at 12:51 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wr

Re: _TOD_Set lock release question

2019-12-03 Thread Sebastian Huber
On 04/12/2019 04:04, Joel Sherrill wrote: Hi _TOD_Set() currently can't fail. With the addition of the TOD hooks, if a BSP hook returns false, then _TOD_Set will fail. This requires that the lock acquired by _TOD_Acquire before _TOD_Set is invoked as in rtems_clock_set() should be released on th

_TOD_Set lock release question

2019-12-03 Thread Joel Sherrill
Hi _TOD_Set() currently can't fail. With the addition of the TOD hooks, if a BSP hook returns false, then _TOD_Set will fail. This requires that the lock acquired by _TOD_Acquire before _TOD_Set is invoked as in rtems_clock_set() should be released on the failure path. I don't see a _TOD_Release