Re: Warning Flags Disappeared

2018-05-08 Thread Sebastian Huber
On 08/05/18 11:50, Chris Johns wrote: On 8/5/18 7:18 pm, Sebastian Huber wrote: This CFLAGS is not set before line 3071 in the script. The caller must have provided it. I don't know how the caller did achieve this and why. Is it ... CFLAGS="-Wxx -Wyyy -Os" ../rtems/configure ... ? This

Re: Warning Flags Disappeared

2018-05-08 Thread Chris Johns
On 8/5/18 7:18 pm, Sebastian Huber wrote: > > This CFLAGS is not set before line 3071 in the script. The caller must have > provided it. I don't know how the caller did achieve this and why. > Is it ... CFLAGS="-Wxx -Wyyy -Os" ../rtems/configure ... ? Chris _

Re: Warning Flags Disappeared

2018-05-08 Thread Sebastian Huber
On 08/05/18 11:10, Chris Johns wrote: On 8/5/18 5:17 pm, Sebastian Huber wrote: This change adds the warning flags. I don't know why CFLAGS is now present. What do you mean by this last sentence? We have: grep '\' -n c/src/configure 640:CFLAGS 759:CFLAGS 1332:To assign environment variables

Re: Warning Flags Disappeared

2018-05-08 Thread Chris Johns
On 8/5/18 5:17 pm, Sebastian Huber wrote: > This change adds the warning flags. I don't know why CFLAGS is now present. What do you mean by this last sentence? > There could be a problem somewhere else. The support was added back in 2011 )d71462b4eb38efbcda6d429a0a61749d7a89e195). I moved this:

Re: Warning Flags Disappeared

2018-05-08 Thread Sebastian Huber
This change adds the warning flags. I don't know why CFLAGS is now present. There could be a problem somewhere else. diff --git a/c/src/configure.ac b/c/src/configure.ac index f4428ed221..7e4986e03d 100644 --- a/c/src/configure.ac +++ b/c/src/configure.ac @@ -100,7 +100,7 @@ RTEMS_PROG_CCAS  RTE

Re: Warning Flags Disappeared

2018-04-19 Thread Sebastian Huber
The problem is in c/src/configure.ac: # Was CFLAGS set? rtems_cv_CFLAGS_set="${CFLAGS+set}" In this line CFLAGS is set. Later we have: # Append warning flags if CFLAGS wasn't set. AS_IF([test "$GCC" = yes && test "$rtems_cv_CFLAGS_set" != set], [CFLAGS="$CFLAGS -Wall -Wmissing-prototypes -Wimp

Warning Flags Disappeared

2018-04-18 Thread Joel Sherrill
Hi Between approximately 3/30 and 4/11, the warning flags disappeared from the build. This needs to be fixed. I tried to git bisect it and didn't have any luck. I didn't make any of the changes that would have broken this so am at a disadvantage. I would politely request that this