Re: Unused macro: CPU_ISR_PASSES_FRAME_POINTER

2014-08-09 Thread Joel Sherrill
You don't protect or1k specific code with this. It is only supposed to be used in generic code. I suspect the generic clock framework has a cast to cover this up On August 9, 2014 3:04:09 AM CDT, Hesham Moustafa wrote: >I can use this in my port from my assembly code part of _ISR_Handler >jus

Re: Unused macro: CPU_ISR_PASSES_FRAME_POINTER

2014-08-09 Thread Hesham Moustafa
I can use this in my port from my assembly code part of _ISR_Handler just before calling the user C Handler. Something like putting #if CPU_ISR_PASSES_FRAME_POINTER l.add r4, sp, r0 #endif where r3 and r4 are the first and second arguments respectively. RTEMS Clock_isr() (which I use for tick ti

Re: Unused macro: CPU_ISR_PASSES_FRAME_POINTER

2014-08-08 Thread Joel Sherrill
On 8/8/2014 10:11 AM, Gedare Bloom wrote: > On Fri, Aug 8, 2014 at 10:52 AM, Joel Sherrill > wrote: >> On 8/8/2014 9:38 AM, Hesham Moustafa wrote: >>> On Fri, Aug 8, 2014 at 4:02 PM, Joel Sherrill >>> wrote: On 8/8/2014 8:54 AM, Gedare Bloom wrote: > Hi, > The macro CPU_ISR_PASSES_

Re: Unused macro: CPU_ISR_PASSES_FRAME_POINTER

2014-08-08 Thread Gedare Bloom
On Fri, Aug 8, 2014 at 10:52 AM, Joel Sherrill wrote: > > On 8/8/2014 9:38 AM, Hesham Moustafa wrote: >> On Fri, Aug 8, 2014 at 4:02 PM, Joel Sherrill >> wrote: >>> On 8/8/2014 8:54 AM, Gedare Bloom wrote: Hi, The macro CPU_ISR_PASSES_FRAME_POINTER is part of a cpu port defined in

Re: Unused macro: CPU_ISR_PASSES_FRAME_POINTER

2014-08-08 Thread Joel Sherrill
On 8/8/2014 9:38 AM, Hesham Moustafa wrote: > On Fri, Aug 8, 2014 at 4:02 PM, Joel Sherrill > wrote: >> On 8/8/2014 8:54 AM, Gedare Bloom wrote: >>> Hi, >>> The macro CPU_ISR_PASSES_FRAME_POINTER is part of a cpu port defined >>> in cpu.h, but this macro seems to be unused. I don't know what the

Re: Unused macro: CPU_ISR_PASSES_FRAME_POINTER

2014-08-08 Thread Hesham Moustafa
On Fri, Aug 8, 2014 at 4:02 PM, Joel Sherrill wrote: > > On 8/8/2014 8:54 AM, Gedare Bloom wrote: >> Hi, >> The macro CPU_ISR_PASSES_FRAME_POINTER is part of a cpu port defined >> in cpu.h, but this macro seems to be unused. I don't know what the >> purpose of it was intended. Anyway, it appears t

Re: Unused macro: CPU_ISR_PASSES_FRAME_POINTER

2014-08-08 Thread Joel Sherrill
On 8/8/2014 8:54 AM, Gedare Bloom wrote: > Hi, > The macro CPU_ISR_PASSES_FRAME_POINTER is part of a cpu port defined > in cpu.h, but this macro seems to be unused. I don't know what the > purpose of it was intended. Anyway, it appears to be wrong for some > architectures (ARM and sparc64 at least

Unused macro: CPU_ISR_PASSES_FRAME_POINTER

2014-08-08 Thread Gedare Bloom
Hi, The macro CPU_ISR_PASSES_FRAME_POINTER is part of a cpu port defined in cpu.h, but this macro seems to be unused. I don't know what the purpose of it was intended. Anyway, it appears to be wrong for some architectures (ARM and sparc64 at least, maybe others). Should we remove the macro, or find