Hi Punit,
Great to see PWM driver working
Besides Martin has suggested, I would like to add few points.
On 21 June 2016 at 21:56, Punit Vara wrote:
> This patch adds required definitions, registers definitions and
> testsuit to
> test pwm driver for beagle bone black.
> ---
On Wed, Jun 22, 2016 at 12:32 AM, punit vara wrote:
> Thank you very much for detailed review. I will do each changes you
> suggested. Though I have some specific doubt I would like to ask as
> following.
Sure. We were discussing it with Ben and agreed that not all these
changes are *required*, e
Thank you very much for detailed review. I will do each changes you
suggested. Though I have some specific doubt I would like to ask as
following.
On Wed, Jun 22, 2016 at 1:07 AM, Martin Galvan
wrote:
> Hi Punit, thanks for sending this. If I understood correctly this is the
> BBBIO code
> plus
Hi Punit, thanks for sending this. If I understood correctly this is the BBBIO
code
plus some changes of your own, right? If so, I think it would be best to send a
patch
with the BBBIO code as is, and then another with your changes on top of it. I
think
that was what we were going for with Start
This patch adds required definitions, registers definitions and
testsuit to
test pwm driver for beagle bone black.
---
c/src/lib/libbsp/arm/beagle/Makefile.am | 3 +
c/src/lib/libbsp/arm/beagle/pwm/bbb-pwm.c| 345 ++
c/src/lib/libbsp/shared/inclu
