Re: cppcheck errors

2015-09-02 Thread Gedare Bloom
On Tue, Sep 1, 2015 at 5:43 PM, Joel Sherrill wrote: > > > On 9/1/2015 2:10 PM, Martin Galvan wrote: >> >> Hi everyone! >> >> I just ran CppCheck again on a fresh clone of the git repo and saw the >> number of error reports was quite smaller than what I reported before. >> That's because my previo

Re: cppcheck errors

2015-09-01 Thread Joel Sherrill
On 9/1/2015 2:10 PM, Martin Galvan wrote: Hi everyone! I just ran CppCheck again on a fresh clone of the git repo and saw the number of error reports was quite smaller than what I reported before. That's because my previous run was on a (quite older) version; most of those must've been fixed a

Re: cppcheck errors

2015-09-01 Thread Martin Galvan
Hi everyone! I just ran CppCheck again on a fresh clone of the git repo and saw the number of error reports was quite smaller than what I reported before. That's because my previous run was on a (quite older) version; most of those must've been fixed already. Some of the error reports remain, tho

Re: cppcheck errors

2015-08-28 Thread Daniel Gutson
On Thu, Aug 27, 2015 at 6:38 PM, Joel Sherrill wrote: > > > On 8/27/2015 4:15 PM, Martin Galvan wrote: >> >> On Thu, Aug 27, 2015 at 6:10 PM, Daniel Gutson >> wrote: >>> >>> Maybe we can just provide the list until we provide the fixes? Martín? >> >> >> Gladly. Keep in mind we ran cppcheck only o

obsolete h8300 was Re: cppcheck errors

2015-08-27 Thread Joel Sherrill
On 8/27/2015 4:22 PM, Martin Galvan wrote: On Thu, Aug 27, 2015 at 6:19 PM, Daniel Gutson wrote: Please note too that there are some false positives, like the realloc one. Actually, we ruled out most false positives. IIRC that one is an actual bug. Btw, sorry for the Spanish comment there.

Re: cppcheck errors

2015-08-27 Thread Joel Sherrill
On 8/27/2015 4:15 PM, Martin Galvan wrote: On Thu, Aug 27, 2015 at 6:10 PM, Daniel Gutson wrote: Maybe we can just provide the list until we provide the fixes? Martín? Gladly. Keep in mind we ran cppcheck only on the modules we use (though some things may've slipped in, like nios): Most o

Re: cppcheck errors

2015-08-27 Thread Joel Sherrill
On 8/27/2015 4:10 PM, Daniel Gutson wrote: On Thu, Aug 27, 2015 at 6:06 PM, Joel Sherrill wrote: On 8/13/2015 10:52 AM, Daniel Gutson wrote: El 13/8/2015 12:49, "Gedare Bloom" mailto:ged...@gwu.edu>> escribió: > > Daniel, > > Unknown deadline right now. Probably whenever Joel can

Re: cppcheck errors

2015-08-27 Thread Martin Galvan
On Thu, Aug 27, 2015 at 6:19 PM, Daniel Gutson wrote: > Please note too that there are some false positives, like the realloc one. Actually, we ruled out most false positives. IIRC that one is an actual bug. Btw, sorry for the Spanish comment there. It means that if we don't initialize _ccr we j

Re: cppcheck errors

2015-08-27 Thread Daniel Gutson
Please note too that there are some false positives, like the realloc one. On Thu, Aug 27, 2015 at 6:15 PM, Martin Galvan wrote: > On Thu, Aug 27, 2015 at 6:10 PM, Daniel Gutson > wrote: >> Maybe we can just provide the list until we provide the fixes? Martín? > > Gladly. Keep in mind we ran cpp

Re: cppcheck errors

2015-08-27 Thread Martin Galvan
On Thu, Aug 27, 2015 at 6:10 PM, Daniel Gutson wrote: > Maybe we can just provide the list until we provide the fixes? Martín? Gladly. Keep in mind we ran cppcheck only on the modules we use (though some things may've slipped in, like nios): [c/src/lib/libbsp/shared/umon/umon.h:21]: (error) Inva

Re: cppcheck errors

2015-08-27 Thread Daniel Gutson
On Thu, Aug 27, 2015 at 6:06 PM, Joel Sherrill wrote: > > > On 8/13/2015 10:52 AM, Daniel Gutson wrote: >> >> >> El 13/8/2015 12:49, "Gedare Bloom" > > escribió: >> > >> > Daniel, >> > >> > Unknown deadline right now. Probably whenever Joel can get around to >> > it! Re

Re: cppcheck errors

2015-08-27 Thread Joel Sherrill
On 8/13/2015 10:52 AM, Daniel Gutson wrote: El 13/8/2015 12:49, "Gedare Bloom" mailto:ged...@gwu.edu>> escribió: > > Daniel, > > Unknown deadline right now. Probably whenever Joel can get around to > it! Realistically, we can create a bugfix "dot release" anytime after > the release sub

Re: cppcheck errors

2015-08-13 Thread Daniel Gutson
El 13/8/2015 12:49, "Gedare Bloom" escribió: > > Daniel, > > Unknown deadline right now. Probably whenever Joel can get around to > it! Realistically, we can create a bugfix "dot release" anytime after > the release subject to user demand. So, even if you miss the 4.11.0 > release with your patche

Re: cppcheck errors

2015-08-13 Thread Gedare Bloom
Daniel, Unknown deadline right now. Probably whenever Joel can get around to it! Realistically, we can create a bugfix "dot release" anytime after the release subject to user demand. So, even if you miss the 4.11.0 release with your patches, we can cut a 4.11.1 after applying the patches if you ne

Re: cppcheck errors

2015-08-13 Thread Daniel Gutson
Hi Gedare, What's the deadline for the official release, if any? El 13/8/2015 7:15, "Gedare Bloom" escribió: > Daniel, > > The release has (unofficially) happened on rtems.git/4.11 branch, from > which master is slowly diverging. Any patches you want applied before > the official release nee

Re: cppcheck errors

2015-08-13 Thread Gedare Bloom
Daniel, The release has (unofficially) happened on rtems.git/4.11 branch, from which master is slowly diverging. Any patches you want applied before the official release need to be (1) associated with a ticket on Trac, and (2) apply to both the 4.11 and master branches. Gedare On Wed, Aug 12, 20