Re: code review: help implementing clock_montonic

2021-06-08 Thread zack_on_the_speed_chanel
hello, I used rtems_timespec_subtract to do all the arithmetic, I think that I have addressed the thing you wanted me to fix. Should I send a patch for you to look at? Zack Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Tuesday, June 8th, 2021 at 4:34 PM, Gedare Bloo

Re: code review: help implementing clock_montonic

2021-06-08 Thread zack_on_the_speed_chanel
ping Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Saturday, May 15th, 2021 at 9:22 PM, zack_on_the_speed_chanel wrote: > Use helper functions in rtems/timespec.h or score/timespec.h > > > (depending where you implement your code, in this case, you probably > > > > u

Re: code review: help implementing clock_montonic

2021-06-08 Thread Gedare Bloom
On Tue, Jun 8, 2021 at 12:05 PM zack_on_the_speed_chanel wrote: > > hello, > I used rtems_timespec_subtract to do all the arithmetic, I think that I > have addressed the thing you wanted me to fix. Should I send a patch for you > to look at? > Sure, if you're happy with it and/or have specific

Re: code review: help implementing clock_montonic

2021-06-08 Thread Gedare Bloom
At this point, we probably need to see some more code. I can't piece together what you've done from the scattered emails here. Hopefully, the use of the helper methods fixes the previous concern I had. On Tue, Jun 8, 2021 at 9:20 AM zack_on_the_speed_chanel wrote: > > ping > > Sent with ProtonMa

Re: code review: help implementing clock_montonic

2021-05-15 Thread zack_on_the_speed_chanel
Use helper functions in rtems/timespec.h or score/timespec.h > (depending where you implement your code, in this case, you probably > use the score services). I did it using rtems subtract function. rtems_timespec_subtract (now, expire, result); where now expire and result are all timespec

Re: code review: help implementing clock_montonic

2021-05-13 Thread Gedare Bloom
On Wed, May 12, 2021 at 2:42 PM zack_on_the_speed_chanel wrote: > > > This ticket mostly references the need for a test. Have you tried to > > write a test for the missing functionality? > > > How I made a test for it was to create the timer using timer_create() . It > also said to use a previous

Re: code review: help implementing clock_montonic

2021-05-12 Thread zack_on_the_speed_chanel
> This ticket mostly references the need for a test. Have you tried to > write a test for the missing functionality? > How I made a test for it was to create the timer using timer_create() . It also said to use a previous test with timer_realtime and i tested it with sometime similar to PSXtimer

Re: code review: help implementing clock_montonic

2021-05-10 Thread Gedare Bloom
On Fri, May 7, 2021 at 12:53 PM zack_on_the_speed_chanel wrote: > > hello, > > Currenttly i'm trying to implement the clock_monotonic which was part of > ticket #3889. So far these are the changes are as follows > This ticket mostly references the need for a test. Have you tried to write a test