Re: Subject: Add PWM driver for beagle bone black

2016-06-22 Thread Martin Galvan
On Wed, Jun 22, 2016 at 12:32 AM, punit vara wrote: > Thank you very much for detailed review. I will do each changes you > suggested. Though I have some specific doubt I would like to ask as > following. Sure. We were discussing it with Ben and agreed that not all these changes are *required*, e

Re: Subject: Add PWM driver for beagle bone black

2016-06-21 Thread punit vara
Thank you very much for detailed review. I will do each changes you suggested. Though I have some specific doubt I would like to ask as following. On Wed, Jun 22, 2016 at 1:07 AM, Martin Galvan wrote: > Hi Punit, thanks for sending this. If I understood correctly this is the > BBBIO code > plus

Re: Subject: Add PWM driver for beagle bone black

2016-06-21 Thread Martin Galvan
Hi Punit, thanks for sending this. If I understood correctly this is the BBBIO code plus some changes of your own, right? If so, I think it would be best to send a patch with the BBBIO code as is, and then another with your changes on top of it. I think that was what we were going for with Start