Re: Instructions to send a Patch

2019-06-01 Thread Vaibhav Gupta
On Thu, 30 May, 2019, 2:48 PM Aditya Upadhyay, wrote: > On Thu, May 30, 2019 at 12:52 AM Gedare Bloom wrote: > > > > On Tue, May 28, 2019 at 8:23 PM Vaibhav Gupta > wrote: > > > > > > > > > > > > On Tue, May 28, 2019 at 11:47 AM Aditya Upadhyay > wrote: > > >> > > >> On Mon, May 27, 2019 at 10

Re: Instructions to send a Patch

2019-05-30 Thread Vaibhav Gupta
On Thu, 30 May, 2019, 12:52 AM Gedare Bloom, wrote: > On Tue, May 28, 2019 at 8:23 PM Vaibhav Gupta > wrote: > > > > > > > > On Tue, May 28, 2019 at 11:47 AM Aditya Upadhyay > wrote: > >> > >> On Mon, May 27, 2019 at 10:42 PM Vaibhav Gupta < > vaibhavgupt...@gmail.com> wrote: > >> > > >> > Hell

Re: Instructions to send a Patch

2019-05-30 Thread Vaibhav Gupta
On Thu, 30 May, 2019, 2:48 PM Aditya Upadhyay, wrote: > On Thu, May 30, 2019 at 12:52 AM Gedare Bloom wrote: > > > > On Tue, May 28, 2019 at 8:23 PM Vaibhav Gupta > wrote: > > > > > > > > > > > > On Tue, May 28, 2019 at 11:47 AM Aditya Upadhyay > wrote: > > >> > > >> On Mon, May 27, 2019 at 10

Re: Instructions to send a Patch

2019-05-30 Thread Aditya Upadhyay
On Thu, May 30, 2019 at 12:52 AM Gedare Bloom wrote: > > On Tue, May 28, 2019 at 8:23 PM Vaibhav Gupta > wrote: > > > > > > > > On Tue, May 28, 2019 at 11:47 AM Aditya Upadhyay > > wrote: > >> > >> On Mon, May 27, 2019 at 10:42 PM Vaibhav Gupta > >> wrote: > >> > > >> > Hello, okay I will ke

Re: Instructions to send a Patch

2019-05-29 Thread Gedare Bloom
On Tue, May 28, 2019 at 8:23 PM Vaibhav Gupta wrote: > > > > On Tue, May 28, 2019 at 11:47 AM Aditya Upadhyay wrote: >> >> On Mon, May 27, 2019 at 10:42 PM Vaibhav Gupta >> wrote: >> > >> > Hello, okay I will keep that in mind. >> > . >> > . >> > . >> > . >> > But there is one problem with this

Re: Instructions to send a Patch

2019-05-28 Thread Vaibhav Gupta
On Tue, May 28, 2019 at 9:54 PM Joel Sherrill wrote: > Also the newlib community really appreciates it if we review the patches > on the RTEMS development list first. When the patch is OK, then it can go > to the newlib list. > Yeah, this is why I sent the patch on devel; for review. > > --joel

Re: Instructions to send a Patch

2019-05-28 Thread Vaibhav Gupta
On Tue, May 28, 2019 at 11:47 AM Aditya Upadhyay wrote: > On Mon, May 27, 2019 at 10:42 PM Vaibhav Gupta > wrote: > > > > Hello, okay I will keep that in mind. > > . > > . > > . > > . > > But there is one problem with this patch then. > > . > > . > > If i just copy-paste ndbm.h, db.h(needed by n

Re: Instructions to send a Patch

2019-05-28 Thread Joel Sherrill
Also the newlib community really appreciates it if we review the patches on the RTEMS development list first. When the patch is OK, then it can go to the newlib list. --joel On Mon, May 27, 2019 at 12:12 PM Vaibhav Gupta wrote: > Hello, okay I will keep that in mind. > . > . > . > . > But there

Re: Instructions to send a Patch

2019-05-27 Thread Aditya Upadhyay
On Mon, May 27, 2019 at 10:42 PM Vaibhav Gupta wrote: > > Hello, okay I will keep that in mind. > . > . > . > . > But there is one problem with this patch then. > . > . > If i just copy-paste ndbm.h, db.h(needed by ndbm.h) and ndbm.c and make the > entry of ndbm.c in Makefile.am. > Then run 'aut

Re: Instructions to send a Patch

2019-05-27 Thread Vaibhav Gupta
Hello, okay I will keep that in mind. . . . . But there is one problem with this patch then. . . If i just copy-paste ndbm.h, db.h(needed by ndbm.h) and ndbm.c and make the entry of ndbm.c in Makefile.am. Then run 'autoreconf' to add the entry for ndbm.c in Makefile.in. And then run `make` comman