Re: Inlined code

2018-08-09 Thread Joel Sherrill
On Thu, Aug 9, 2018, 11:50 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > - Am 6. Aug 2018 um 21:14 schrieb joel j...@rtems.org: > [...] > > We looked at a lot of generated assembly. Sometimes we would see > > large methods being inlined multiple times. This would increase t

Re: Inlined code

2018-08-09 Thread Sebastian Huber
- Am 6. Aug 2018 um 21:14 schrieb joel j...@rtems.org: [...] > We looked at a lot of generated assembly. Sometimes we would see > large methods being inlined multiple times. This would increase the overall > size of an RTEMS application. But size is not the only impact of inlining. > If an inli

Re: Inlined code

2018-08-07 Thread Joel Sherrill
On Tue, Aug 7, 2018 at 12:48 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 06/08/18 21:14, Joel Sherrill wrote: > > >> >> On Mon, Aug 6, 2018 at 1:21 AM, Chris Johns > chr...@rtems.org>> wrote: >> >> On 06/08/2018 16:12, Christian Mauderer wrote: >> > Am 06.08.2018

Re: Inlined code

2018-08-06 Thread Sebastian Huber
On 06/08/18 21:14, Joel Sherrill wrote: On Mon, Aug 6, 2018 at 1:21 AM, Chris Johns > wrote: On 06/08/2018 16:12, Christian Mauderer wrote: > Am 06.08.2018 um 07:31 schrieb Chris Johns: >> On 06/08/2018 10:51, Chris Johns wrote: >>> On 05/08/2018 19:39

Re: Inlined code

2018-08-06 Thread Chris Johns
On 07/08/2018 05:14, Joel Sherrill wrote: > > On Mon, Aug 6, 2018 at 1:21 AM, Chris Johns > wrote: > > On 06/08/2018 16:12, Christian Mauderer wrote: > > Am 06.08.2018 um 07:31 schrieb Chris Johns: > >> On 06/08/2018 10:51, Chris Johns wrote: > >>> On 05/

Re: Inlined code

2018-08-06 Thread Joel Sherrill
On Mon, Aug 6, 2018 at 1:21 AM, Chris Johns wrote: > On 06/08/2018 16:12, Christian Mauderer wrote: > > Am 06.08.2018 um 07:31 schrieb Chris Johns: > >> On 06/08/2018 10:51, Chris Johns wrote: > >>> On 05/08/2018 19:39, Christian Mauderer wrote: > Am 05.08.2018 um 04:00 schrieb Chris Johns:

Re: Inlined code

2018-08-05 Thread Chris Johns
On 06/08/2018 16:12, Christian Mauderer wrote: > Am 06.08.2018 um 07:31 schrieb Chris Johns: >> On 06/08/2018 10:51, Chris Johns wrote: >>> On 05/08/2018 19:39, Christian Mauderer wrote: Am 05.08.2018 um 04:00 schrieb Chris Johns: > Hi, > > I have been working on migrating covoar i

Re: Inlined code

2018-08-05 Thread Christian Mauderer
Am 06.08.2018 um 07:31 schrieb Chris Johns: > On 06/08/2018 10:51, Chris Johns wrote: >> On 05/08/2018 19:39, Christian Mauderer wrote: >>> Am 05.08.2018 um 04:00 schrieb Chris Johns: Hi, I have been working on migrating covoar in the rtems-tools repo to DWARF. The goal is

Re: Inlined code

2018-08-05 Thread Chris Johns
On 06/08/2018 15:30, Sebastian Huber wrote: > Hello Chris, > > this looks like a very interesting tool. The justification for an inline > function must be done case by case. I agree. I think a workable pattern will appear and my hope is this tool can be taught what is OK and what is not. I hope

Re: Inlined code

2018-08-05 Thread Chris Johns
On 06/08/2018 10:51, Chris Johns wrote: > On 05/08/2018 19:39, Christian Mauderer wrote: >> Am 05.08.2018 um 04:00 schrieb Chris Johns: >>> Hi, >>> >>> I have been working on migrating covoar in the rtems-tools repo to DWARF. >>> The >>> goal is remove objdump parsing and to get accurate details a

Re: Inlined code

2018-08-05 Thread Sebastian Huber
Hello Chris, this looks like a very interesting tool. The justification for an inline function must be done case by case. On 05/08/18 04:00, Chris Johns wrote: inlined repeats : 19172 16 __sprint_r This is a small function. GCC decided that it is worth inlining. With -O2 GCC doesn't ca

Re: Inlined code

2018-08-05 Thread Chris Johns
On 05/08/2018 19:39, Christian Mauderer wrote: > Am 05.08.2018 um 04:00 schrieb Chris Johns: >> Hi, >> >> I have been working on migrating covoar in the rtems-tools repo to DWARF. The >> goal is remove objdump parsing and to get accurate details about the >> functions >> being covered. This is an

Re: Inlined code

2018-08-05 Thread Christian Mauderer
Am 05.08.2018 um 04:00 schrieb Chris Johns: > Hi, > > I have been working on migrating covoar in the rtems-tools repo to DWARF. The > goal is remove objdump parsing and to get accurate details about the functions > being covered. This is an unfunded task. > > The work has resulted in a close exam