Re: Driver complaint to SD Host Controller Specification 3.0

2016-06-07 Thread Sebastian Huber
On 04/06/16 06:09, Mudit Jain wrote: Apologies regarding that. No need to apology, but please try to improve the guideline if something is unclear. If you don't understand something or there is something unclear or not reasonable, then please ask questions. Some of the lines that showed

Re: Driver complaint to SD Host Controller Specification 3.0

2016-06-07 Thread Mudit Jain
Hi all, I have procured a RPi Model B and was testing the ported driver on the same. This is where it hangs. -- *** LIBBSD SDHCI 01 TEST *** nexus0: bcm_dma0: on nexus0 sdhci_bcm0: on nexus0 ---

Re: Driver complaint to SD Host Controller Specification 3.0

2016-06-03 Thread Chris Johns
On 3/06/2016 10:20 PM, Sebastian Huber wrote: On 03/06/16 13:20, Mudit Jain wrote: In the latest commit I have followed the FreeBSD port guidelines given libbsd.txt using the tools to port the code. Sorry for being pedantic, but please follow the guidelines exactly: I will add we have to be

Re: Driver complaint to SD Host Controller Specification 3.0

2016-06-03 Thread Mudit Jain
Hi, Apologies regarding that. Some of the lines that showed '-' were because changes were committed on the old changes which were not right. However, I have created a new branch where the commits are much cleaner. https://github.com/spark1729/rtems-libbsd/commits/RPI_SD On Fri, Jun 3, 2016 at

Re: Driver complaint to SD Host Controller Specification 3.0

2016-06-03 Thread Sebastian Huber
On 03/06/16 13:20, Mudit Jain wrote: In the latest commit I have followed the FreeBSD port guidelines given libbsd.txt using the tools to port the code. Sorry for being pedantic, but please follow the guidelines exactly: "Only add lines. If your patch contains lines starting with a '-', then

Re: Driver complaint to SD Host Controller Specification 3.0

2016-06-03 Thread Mudit Jain
Hi, Yes Sebastian, that change was not required. I have rebased, removing that change and have pushed the same. Link Andre, as per your feedback, I have removed the ofw bus. In the latest commit I have followed the FreeBSD port guid

Re: Driver complaint to SD Host Controller Specification 3.0

2016-06-01 Thread André Marques
Hello mudit, Às 09:13 de 30-05-2016, Mudit Jain escreveu: Hi all, I have ported the code from the present FreeBSD. Link : https://github.com/spark1729/rtems-libbsd/commits/rpi_sd_card Kindly review the same and suggest changes. The commits are a bit unstructured, the second last one being a

Re: Driver complaint to SD Host Controller Specification 3.0

2016-05-31 Thread Sebastian Huber
Hello Mudit, On 30/05/16 10:13, Mudit Jain wrote: Hi all, I have ported the code from the present FreeBSD. Link : https://github.com/spark1729/rtems-libbsd/commits/rpi_sd_card nice work. Kindly review the same and suggest changes. The commits are a bit unstructured, the second last one b

Re: Driver complaint to SD Host Controller Specification 3.0

2016-05-30 Thread Mudit Jain
Hi all, I have ported the code from the present FreeBSD. Link : https://github.com/spark1729/rtems-libbsd/commits/rpi_sd_card Kindly review the same and suggest changes. The commits are a bit unstructured, the second last one being a huge one. I will be breaking it down into smaller and logical

Re: Driver complaint to SD Host Controller Specification 3.0

2016-05-26 Thread Sebastian Huber
On 26/05/16 16:06, Mudit Jain wrote: Hi Sebastian & Andre, In the last IRC meeting, Gedare had mentioned that you have previously worked on the SD card driver. I was working on the SD Card driver for Rpi. I was going through the driver code that has been ported. I was able to browse and g

Re: Driver complaint to SD Host Controller Specification 3.0

2016-05-26 Thread André Marques
Hello mudit, Às 15:06 de 26-05-2016, Mudit Jain escreveu: Hi Sebastian & Andre, In the last IRC meeting, Gedare had mentioned that you have previously worked on the SD card driver. I was working on the SD Card driver for Rpi. I was going through the driver code that has been ported. I was a