Re: [PATCH v4 2/3] libmisc/shell: Add flashdev command

2023-05-16 Thread Joel Sherrill
Aaron, Please look at my recent post to devel@ about new defects reported by Coverity Scan. There are two in main_flashdev.c. One is really easy and reflects a missing close(fd) on an error path. The other looks harder. I don't see how flashdev ever gets set. Looks like a NULL is passed to a lot o

Re: [PATCH v4 2/3] libmisc/shell: Add flashdev command

2023-05-15 Thread Gedare Bloom
On Sun, Apr 30, 2023 at 11:20 PM wrote: > > From: Aaron Nyholm > > --- > cpukit/include/rtems/shellconfig.h | 7 + > cpukit/libmisc/shell/main_flashdev.c | 592 +++ > spec/build/cpukit/objshell.yml | 1 + > 3 files changed, 600 insertions(+) > create mode 100