On 17/07/2019 11:10, Nils Hölscher wrote:
> Hi,
>
> +#define VM_MEMATTR_DEFAULT 0
> +#define VM_MEMATTR_UNCACHEABLE 1
>
>
> Are you sure that these values are correct in general?
> BSD defines this only for ARM versions smaller 6.
> https://github.com/freebsd/freebsd/blob/1d6e4247415d26
On Wed, 17 Jul 2019 at 09:03, Vijay Kumar Banerjee
wrote:
> ---
> freebsd/sys/kern/kern_conf.c | 8 +++
> freebsd/sys/sys/conf.h | 2 +-
> rtemsbsd/include/machine/vm.h | 2 ++
> rtemsbsd/sys/fs/devfs/devfs_devs.c | 34 ++
> testsuite/cde
On 17/07/2019 09:02, Vijay Kumar Banerjee wrote:
+static int
+testmmap(struct cdev *dev, vm_ooffset_t offset, vm_paddr_t *paddr,
+ int nprot, vm_memattr_t *memattr)
+{
+ test_state *state = dev->si_drv1;
+
Please add assertions for all parameters.
+ assert(*state == TEST_K
On 17/07/2019 09:02, Vijay Kumar Banerjee wrote:
+ if (td != 0) {
+ if (cdev == NULL) {
+ error = ENXIO;
+ }
Suppose cdev == NULL, then you have a NULL pointer access here:
+ if (cdev->si_flags & SI_ALIAS) {
+
