On 20/4/2023 7:42 am, Gedare Bloom wrote:
> On Mon, Apr 17, 2023 at 9:55 PM Chris Johns wrote:
>>
>> On 18/4/2023 1:48 pm, Gedare Bloom wrote:
>>> On Sun, Apr 16, 2023 at 6:48 PM Aaron Nyholm
>>> wrote:
As for the RTEMS_FLASHDEV_MAX_REGIONS being set at 32 I chose the value as
it seame
On Mon, Apr 17, 2023 at 9:55 PM Chris Johns wrote:
>
> On 18/4/2023 1:48 pm, Gedare Bloom wrote:
> > On Sun, Apr 16, 2023 at 6:48 PM Aaron Nyholm
> > wrote:
> >> As for the RTEMS_FLASHDEV_MAX_REGIONS being set at 32 I chose the value as
> >> it seamed a good balance between memory usage and func
On 18/4/2023 1:48 pm, Gedare Bloom wrote:
> On Sun, Apr 16, 2023 at 6:48 PM Aaron Nyholm
> wrote:
>> As for the RTEMS_FLASHDEV_MAX_REGIONS being set at 32 I chose the value as
>> it seamed a good balance between memory usage and function. I wanted to
>> avoid using malloc as your previous feedba
On Sun, Apr 16, 2023 at 6:48 PM Aaron Nyholm
wrote:
>
> Hi Gedare,
>
> Thanks for the feedback you’ve provided. I have a couple questions.
>
> You suggest refactoring the callouts into another sturct, I’m happy to do so.
> I originally chose not to as I was was basing the high level structure off
Hi Gedare,
Thanks for the feedback you’ve provided. I have a couple questions.
You suggest refactoring the callouts into another sturct, I’m happy to do so. I
originally chose not to as I was was basing the high level structure off the
i2c API already in RTEMS. Just clarifying it’s worth doing.
I focused my review on the API. See below.
On Thu, Apr 6, 2023 at 1:08 AM wrote:
>
> From: Aaron Nyholm
>
[...]
> diff --git a/cpukit/include/dev/flash/flashdev.h
> b/cpukit/include/dev/flash/flashdev.h
> new file mode 100644
> index 00..5d53ea7b97
> --- /dev/null
> +++ b/cpukit/include
