Re: [PATCH v2] Add mmap

2019-07-17 Thread Vijay Kumar Banerjee
On Wed, Jul 17, 2019 at 10:26 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 16/07/2019 21:47, Vijay Kumar Banerjee wrote: > > + rv = mmap(NULL, 1, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); > > + assert(rv != MAP_FAILED); > > + > > Please change this to: > > assert(

Re: [PATCH v2] Add mmap

2019-07-16 Thread Sebastian Huber
On 16/07/2019 21:47, Vijay Kumar Banerjee wrote: + rv = mmap(NULL, 1, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + assert(rv != MAP_FAILED); + Please change this to: assert(rv == 0); Please add assertions for the flags (PROT*, MAP*) to your mmap handler. -- Sebastian Huber, embe