Re: [PATCH libbsd] mmcsd: Fix missing MMCBUS_RELEASE_BUS.

2020-04-01 Thread Christian Mauderer
Hello Sebastian, thanks for the review. On 01/04/2020 10:41, Sebastian Huber wrote: > On 01/04/2020 10:03, Christian Mauderer wrote: > >> The rtems_bsd_mmcsd_attach_worker acquired the bus without releasing it. >> Fix that by only acquire the bus if necessary (during initialization and >> during

Re: [PATCH libbsd] mmcsd: Fix missing MMCBUS_RELEASE_BUS.

2020-04-01 Thread Sebastian Huber
On 01/04/2020 10:41, Sebastian Huber wrote:     for (i = 0; i < buffer_count; ++i) { @@ -394,6 +399,7 @@ rtems_bsd_mmcsd_disk_read_write(struct mmcsd_part *part, rtems_blkdev_request *b   error:     MMCSD_DISK_UNLOCK(part); +    MMCBUS_RELEASE_BUS(device_get_parent(dev), dev);    

Re: [PATCH libbsd] mmcsd: Fix missing MMCBUS_RELEASE_BUS.

2020-04-01 Thread Sebastian Huber
On 01/04/2020 10:03, Christian Mauderer wrote: The rtems_bsd_mmcsd_attach_worker acquired the bus without releasing it. Fix that by only acquire the bus if necessary (during initialization and during read / writes). --- freebsd/sys/dev/mmc/mmcsd.c | 8 ++-- 1 file changed, 6 insertions(+)